From: Neil Armstrong <neil.armstrong@linaro.org>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Hector Martin" <marcan@marcan.st>,
"Sven Peter" <sven@svenpeter.dev>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Vincent Shih" <vincent.sunplus@gmail.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Anson Huang" <Anson.Huang@nxp.com>,
"Andrew-CT Chen" <andrew-ct.chen@mediatek.com>,
"Lala Lin" <lala.lin@mediatek.com>,
"Komal Bajaj" <quic_kbajaj@quicinc.com>,
"Kumar Thella" <sthella@codeaurora.org>,
"Keiji Hayashibara" <hayashibara.keiji@socionext.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, asahi@lists.linux.dev,
linux-arm-msm@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-rtc@vger.kernel.org,
linux-mediatek@lists.infradead.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V2] dt-bindings: nvmem: move deprecated cells binding to its own file
Date: Tue, 3 Oct 2023 09:40:10 +0200 [thread overview]
Message-ID: <7c18a0f6-48a9-4ec9-90d0-3fe7268e93ad@linaro.org> (raw)
In-Reply-To: <20231003064018.7502-1-zajec5@gmail.com>
On 03/10/2023 08:40, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Support for old NVMEM fixed cells was deprecated in favour of
> "fixed-layout". It's still part of the nvmem.yaml though and may be
> unknowingly used by new bindings added without much of analyze.
>
> To make it more difficult to accidentally support old syntax move its
> binding to separated file with "deprecated" in its name.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> V2: Fix path to nvmem-deprecated-cells.yaml in amlogic,meson6-rtc.yaml
>
> .../devicetree/bindings/mtd/mtd.yaml | 7 ++++-
> .../bindings/mtd/partitions/nvmem-cells.yaml | 1 +
> .../nvmem/amlogic,meson-gxbb-efuse.yaml | 1 +
> .../bindings/nvmem/amlogic,meson6-efuse.yaml | 1 +
For Amlogic/Meson bindings:
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
> .../bindings/nvmem/apple,efuses.yaml | 1 +
> .../devicetree/bindings/nvmem/imx-ocotp.yaml | 1 +
> .../bindings/nvmem/mediatek,efuse.yaml | 1 +
> .../nvmem/microchip,sama7g5-otpc.yaml | 1 +
> .../devicetree/bindings/nvmem/mxs-ocotp.yaml | 1 +
> .../nvmem/nvmem-deprecated-cells.yaml | 28 +++++++++++++++++++
> .../devicetree/bindings/nvmem/nvmem.yaml | 9 ------
> .../bindings/nvmem/qcom,qfprom.yaml | 1 +
> .../bindings/nvmem/qcom,sec-qfprom.yaml | 1 +
> .../bindings/nvmem/qcom,spmi-sdam.yaml | 1 +
> .../bindings/nvmem/rockchip,otp.yaml | 1 +
> .../bindings/nvmem/rockchip-efuse.yaml | 1 +
> .../nvmem/socionext,uniphier-efuse.yaml | 1 +
> .../bindings/nvmem/sunplus,sp7021-ocotp.yaml | 1 +
> .../bindings/rtc/amlogic,meson6-rtc.yaml | 1 +
> 19 files changed, 50 insertions(+), 10 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/nvmem/nvmem-deprecated-cells.yaml
>
> diff --git a/Documentation/devicetree/bindings/mtd/mtd.yaml b/Documentation/devicetree/bindings/mtd/mtd.yaml
> index b82ca03e969c..f322290ee516 100644
> --- a/Documentation/devicetree/bindings/mtd/mtd.yaml
> +++ b/Documentation/devicetree/bindings/mtd/mtd.yaml
> @@ -43,7 +43,12 @@ patternProperties:
> deprecated: true
>
> "^otp(-[0-9]+)?$":
> - $ref: ../nvmem/nvmem.yaml#
> + type: object
> +
> + allOf:
> + - $ref: ../nvmem/nvmem.yaml#
> + - $ref: ../nvmem/nvmem-deprecated-cells.yaml#
> +
> unevaluatedProperties: false
>
> description: |
> diff --git a/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> index 5474d63268dc..9518281007af 100644
> --- a/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> +++ b/Documentation/devicetree/bindings/mtd/partitions/nvmem-cells.yaml
> @@ -19,6 +19,7 @@ maintainers:
> allOf:
> - $ref: /schemas/mtd/partitions/partition.yaml#
> - $ref: /schemas/nvmem/nvmem.yaml#
> + - $ref: /schemas/nvmem/nvmem-deprecated-cells.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/nvmem/amlogic,meson-gxbb-efuse.yaml b/Documentation/devicetree/bindings/nvmem/amlogic,meson-gxbb-efuse.yaml
> index e49c2754ff55..9801fe6f91b5 100644
> --- a/Documentation/devicetree/bindings/nvmem/amlogic,meson-gxbb-efuse.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/amlogic,meson-gxbb-efuse.yaml
> @@ -11,6 +11,7 @@ maintainers:
>
> allOf:
> - $ref: nvmem.yaml#
> + - $ref: nvmem-deprecated-cells.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/nvmem/amlogic,meson6-efuse.yaml b/Documentation/devicetree/bindings/nvmem/amlogic,meson6-efuse.yaml
> index 84b3dfd21e09..b5cf740f96fa 100644
> --- a/Documentation/devicetree/bindings/nvmem/amlogic,meson6-efuse.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/amlogic,meson6-efuse.yaml
> @@ -12,6 +12,7 @@ maintainers:
>
> allOf:
> - $ref: nvmem.yaml#
> + - $ref: nvmem-deprecated-cells.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/nvmem/apple,efuses.yaml b/Documentation/devicetree/bindings/nvmem/apple,efuses.yaml
> index e0860b6b85f3..d3abdafdbca0 100644
> --- a/Documentation/devicetree/bindings/nvmem/apple,efuses.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/apple,efuses.yaml
> @@ -16,6 +16,7 @@ maintainers:
>
> allOf:
> - $ref: nvmem.yaml#
> + - $ref: nvmem-deprecated-cells.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml b/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml
> index 99e60d713dac..be1314454bec 100644
> --- a/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/imx-ocotp.yaml
> @@ -16,6 +16,7 @@ description: |
>
> allOf:
> - $ref: nvmem.yaml#
> + - $ref: nvmem-deprecated-cells.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> index 7ec2988b597e..cf5f9e22bb7e 100644
> --- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> @@ -16,6 +16,7 @@ maintainers:
>
> allOf:
> - $ref: nvmem.yaml#
> + - $ref: nvmem-deprecated-cells.yaml#
>
> properties:
> $nodename:
> diff --git a/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml b/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml
> index a296d348adb4..cc25f2927682 100644
> --- a/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/microchip,sama7g5-otpc.yaml
> @@ -16,6 +16,7 @@ description: |
>
> allOf:
> - $ref: nvmem.yaml#
> + - $ref: nvmem-deprecated-cells.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/nvmem/mxs-ocotp.yaml b/Documentation/devicetree/bindings/nvmem/mxs-ocotp.yaml
> index a9b822aeaa7e..f43186f98607 100644
> --- a/Documentation/devicetree/bindings/nvmem/mxs-ocotp.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/mxs-ocotp.yaml
> @@ -11,6 +11,7 @@ maintainers:
>
> allOf:
> - $ref: nvmem.yaml#
> + - $ref: nvmem-deprecated-cells.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/nvmem/nvmem-deprecated-cells.yaml b/Documentation/devicetree/bindings/nvmem/nvmem-deprecated-cells.yaml
> new file mode 100644
> index 000000000000..951af28bbfb3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/nvmem-deprecated-cells.yaml
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/nvmem/nvmem-deprecated-cells.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVMEM old syntax for fixed cells
> +
> +maintainers:
> + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> +
> +description: |
> + Before introducing NVMEM layouts all NVMEM (fixed) cells were defined
> + as direct device subnodes. That syntax was replaced by "fixed-layout"
> + and is deprecated now. No new bindings should use it.
> +
> +patternProperties:
> + "@[0-9a-f]+(,[0-7])?$":
> + type: object
> + allOf:
> + - $ref: layouts/fixed-cell.yaml
> + - properties:
> + compatible: false
> + deprecated: true
> +
> +additionalProperties: true
> +
> +...
> diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> index 9f921d940142..4fd015d402ce 100644
> --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> @@ -46,15 +46,6 @@ properties:
> container may reference more advanced (dynamic) layout
> parsers.
>
> -patternProperties:
> - "@[0-9a-f]+(,[0-7])?$":
> - type: object
> - allOf:
> - - $ref: layouts/fixed-cell.yaml
> - - properties:
> - compatible: false
> - deprecated: true
> -
> additionalProperties: true
>
> examples:
> diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
> index 8740938c32eb..8c8f05d9eaf1 100644
> --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
> @@ -11,6 +11,7 @@ maintainers:
>
> allOf:
> - $ref: nvmem.yaml#
> + - $ref: nvmem-deprecated-cells.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/nvmem/qcom,sec-qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,sec-qfprom.yaml
> index 9b133f783d29..2ada2099946d 100644
> --- a/Documentation/devicetree/bindings/nvmem/qcom,sec-qfprom.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/qcom,sec-qfprom.yaml
> @@ -16,6 +16,7 @@ description:
>
> allOf:
> - $ref: nvmem.yaml#
> + - $ref: nvmem-deprecated-cells.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml b/Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml
> index cd980def97b8..068bedf5dbc9 100644
> --- a/Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/qcom,spmi-sdam.yaml
> @@ -16,6 +16,7 @@ description: |
>
> allOf:
> - $ref: nvmem.yaml#
> + - $ref: nvmem-deprecated-cells.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
> index 9c6eff788928..a44d44b32809 100644
> --- a/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
> @@ -49,6 +49,7 @@ required:
>
> allOf:
> - $ref: nvmem.yaml#
> + - $ref: nvmem-deprecated-cells.yaml#
>
> - if:
> properties:
> diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.yaml b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.yaml
> index c5403e149080..b80fd8d1ae5b 100644
> --- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.yaml
> @@ -11,6 +11,7 @@ maintainers:
>
> allOf:
> - $ref: nvmem.yaml#
> + - $ref: nvmem-deprecated-cells.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml b/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml
> index efccc5aacbe0..e27cbae2d63a 100644
> --- a/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml
> @@ -12,6 +12,7 @@ maintainers:
>
> allOf:
> - $ref: nvmem.yaml#
> + - $ref: nvmem-deprecated-cells.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml b/Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml
> index da3f1de7d281..af97eeb8316c 100644
> --- a/Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/sunplus,sp7021-ocotp.yaml
> @@ -12,6 +12,7 @@ maintainers:
>
> allOf:
> - $ref: nvmem.yaml#
> + - $ref: nvmem-deprecated-cells.yaml#
>
> properties:
> compatible:
> diff --git a/Documentation/devicetree/bindings/rtc/amlogic,meson6-rtc.yaml b/Documentation/devicetree/bindings/rtc/amlogic,meson6-rtc.yaml
> index 8bf7d3a9be98..3a4551253e3e 100644
> --- a/Documentation/devicetree/bindings/rtc/amlogic,meson6-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/amlogic,meson6-rtc.yaml
> @@ -13,6 +13,7 @@ maintainers:
> allOf:
> - $ref: rtc.yaml#
> - $ref: /schemas/nvmem/nvmem.yaml#
> + - $ref: /schemas/nvmem/nvmem-deprecated-cells.yaml#
>
> properties:
> compatible:
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-10-03 7:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 6:40 Rafał Miłecki
2023-10-03 7:40 ` Neil Armstrong [this message]
2023-10-05 10:01 ` Heiko Stübner
2023-10-06 16:16 ` Rob Herring
2023-10-07 10:08 ` Srinivas Kandagatla
2023-10-24 14:24 ` Rob Herring
2023-10-24 15:41 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c18a0f6-48a9-4ec9-90d0-3fe7268e93ad@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=Anson.Huang@nxp.com \
--cc=a.zummo@towertech.it \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alyssa@rosenzweig.io \
--cc=andersson@kernel.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=asahi@lists.linux.dev \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=hayashibara.keiji@socionext.com \
--cc=heiko@sntech.de \
--cc=jbrunet@baylibre.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lala.lin@mediatek.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mhiramat@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=quic_kbajaj@quicinc.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=sthella@codeaurora.org \
--cc=sven@svenpeter.dev \
--cc=vigneshr@ti.com \
--cc=vincent.sunplus@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®