From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97C22C3600B for ; Mon, 31 Mar 2025 13:24:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QN0P+BWT/JQDL7yGRnS0+nUT7+S5K/XWxFrEDE+y3LM=; b=1RWg+Ecsst7eoqnN/f0OuFJlEW xtaA0UKCDbD+ixhqvHw0K5x/P/kgMKPzxM60lPlLDU4c5UJfDKn1JjWFLLqm4OOTtSOjG//tm72lP z2sDFwCC8QwWYOM/a+2SJoaqpym3tJxiPZ2WMkUhSZFxPfRGOyDcV8Hx/pQxAjk+0oKPhmA+P2Ddn TLxWeCYHwndSppo6AGA1/v0uRcLbtnGDmdSwYG23GeTdASBPGBrlgygXRDBUXth2zATMFBNvb6ZR4 Uz0GZZkbYq5Et2bgqkHNDa0wur7Vwj++ix8R6ZY7sJwPbePd9kS7LI2mi0hrPHa9hyyVxL5VthFvs HHXhtvSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzF7H-00000000RDl-43Pp; Mon, 31 Mar 2025 13:23:51 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzF5Y-00000000R2m-31Oi for linux-amlogic@lists.infradead.org; Mon, 31 Mar 2025 13:22:06 +0000 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-39ac8e7688aso3572789f8f.2 for ; Mon, 31 Mar 2025 06:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743427323; x=1744032123; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=/rYByIuq0b2PjmjfZxltk1e0AePkOWa/aML/nirCPWw=; b=oOUTVP2xpMYxkrEmQzms/6bgEyCs5j8tFuAfuyol8AMwkPp44/dEbp185UXZaHsvGd Lll5hds0y/VFJ3Nz/zI7kh1K+5a6bsDaY0SReD0lZ3WIvHz3kU4dToB4X2pqQn3yfd/s IIJ3yEBRj8s8VwrIUXI7HoVwtVD30iWkOF7vNPj0edcBiRT5H6MYAaooxza7YOW/fuhC 8A6eiCwYqFL2Zxofp1nW97x+/wzhe+xw02VsEvmrcI2MpzgMyepn1GiettHh7fmUWuFK jxrTD5In+izDBGHxS/xK+twbqeGxrUlCo/d6o/TJg6V4qfWJ+69ABcCHZJm4Nv9Ks+rQ 5ZTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743427323; x=1744032123; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/rYByIuq0b2PjmjfZxltk1e0AePkOWa/aML/nirCPWw=; b=bmfbtYeOgdmIUYRpWUkVRLB+No4us9YOmy9QtHXffNBcr1qNw18fQqEdXQItoJrLJV 9Q4SfX+Qy9Cjksa10x3A7YbGy+6vMNnugiqsHQW4lJprmnXKwsew5nqRE0GAvCNNNxBd nUG3kpZMv1cUcEUwuNqwFYGsyUfpFuRkRcBDZSyTxA8gd0G+rs2Di4jVoZVf0M9sxEhG kTXjSN5IFHVjKaUF+NKhDZUiH+ei8UUIKg7r/fTfmaEwpzXKgYsB5xvhvPnUXzw2NpSZ h+sHJjM2DaWoesPfufI0a2tmrJZy6oo+9J+20RsK/ngqa1CFvLWWWt5yuoi9U0n0A1sI qYww== X-Forwarded-Encrypted: i=1; AJvYcCXimI19TfSpWUBsy7577LevJpffic+vDWO3FbI4TEO74tdTeV/oGYIV4x9pT/U0+k2uKi/AaDNgLB47396m@lists.infradead.org X-Gm-Message-State: AOJu0Yx6IfnlQI3zB8LrFDwNu710ywmI8DqUe43WkxEmnDmZCRZJi+bY 60JEouHZ3KuwLvII+ac+XimV9Zx8v9y+xyfRkiAPbu1a+Qpsd6a1JcZ6Xe9IGus= X-Gm-Gg: ASbGncvSPz75tu2sNV3EKer7bpt96mxy5+XWx9UqZ6u+lO4+mY+TLY3WjExaGO43pmZ mmvkt+TvdSpFFK/vncvesa9by2sC3ZcR7PimlxuVT1lBG02JX1fV3er1PvNtQPLTAZmP5zrlecj cCEOSWp1x5mcWLqx53A6QRGDFwtxyy5ZwbCPJZSiRIcTi2puhcLQELnihNIB8pjbzSmXbr9ZZyP XwTijXKShTMWkCh3LIPOm//1ovWB8Ta/Gi61+UOxg5DJw/JJPk/TP+q1rPUdN7tWhnMQ4ivHnut lseVCKvp52UjDhmKsgRUwIsBg8dZHFeedI/IKDL/VEEbYLp3HxGdyz2isnB3qfDeM+7Shfjo0iF 1cNvg1ANDFcbiqxSY X-Google-Smtp-Source: AGHT+IHUVZ074JKaAb9ncND8Uu7WRhh2YlGnAcHVleffCEEVTpj1+nUfZQDJb2JS+yVkEbfZ4DlSNw== X-Received: by 2002:a05:6000:240a:b0:39c:142c:e889 with SMTP id ffacd0b85a97d-39c142ce891mr6232553f8f.27.1743427322771; Mon, 31 Mar 2025 06:22:02 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:143:2e3d:45f1:fd2? ([2a01:e0a:3d9:2080:143:2e3d:45f1:fd2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c0b7a4346sm11469954f8f.95.2025.03.31.06.22.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Mar 2025 06:22:02 -0700 (PDT) Message-ID: <7c986d1f-315d-4cb0-b160-ee1f564c26c4@linaro.org> Date: Mon, 31 Mar 2025 15:22:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH v2] net: mdio: mux-meson-gxl: set 28th bit in eth_reg2 To: Christian Hewitt , Andrew Lunn , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Da Xue References: <20250331074420.3443748-1-christianshewitt@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250331074420.3443748-1-christianshewitt@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250331_062204_779276_7A1178A3 X-CRM114-Status: GOOD ( 18.20 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 31/03/2025 09:44, Christian Hewitt wrote: > From: Da Xue > > This bit is necessary to enable packets on the interface. Without this > bit set, ethernet behaves as if it is working, but no activity occurs. > > The vendor SDK sets this bit along with the PHY_ID bits. U-boot also > sets this bit, but if u-boot is not compiled with networking support > the interface will not work. > > Fixes: 9a24e1ff4326 ("net: mdio: add amlogic gxl mdio mux support"); > Signed-off-by: Da Xue > Signed-off-by: Christian Hewitt > --- > Resending on behalf of Da Xue who has email sending issues. > Changes since v1 [0]: > - Remove blank line between Fixes and SoB tags > - Submit without mail server mangling the patch > - Minor tweaks to subject line and commit message > - CC to stable@vger.kernel.org > > [0] https://patchwork.kernel.org/project/linux-amlogic/patch/CACqvRUbx-KsrMwCHYQS6eGXBohynD8Q1CQx=8=9VhqZi13BCQQ@mail.gmail.com/ > > drivers/net/mdio/mdio-mux-meson-gxl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mdio/mdio-mux-meson-gxl.c b/drivers/net/mdio/mdio-mux-meson-gxl.c > index 00c66240136b..fc5883387718 100644 > --- a/drivers/net/mdio/mdio-mux-meson-gxl.c > +++ b/drivers/net/mdio/mdio-mux-meson-gxl.c > @@ -17,6 +17,7 @@ > #define REG2_LEDACT GENMASK(23, 22) > #define REG2_LEDLINK GENMASK(25, 24) > #define REG2_DIV4SEL BIT(27) > +#define REG2_RESERVED_28 BIT(28) > #define REG2_ADCBYPASS BIT(30) > #define REG2_CLKINSEL BIT(31) > #define ETH_REG3 0x4 > @@ -65,7 +66,7 @@ static void gxl_enable_internal_mdio(struct gxl_mdio_mux *priv) > * The only constraint is that it must match the one in > * drivers/net/phy/meson-gxl.c to properly match the PHY. > */ > - writel(FIELD_PREP(REG2_PHYID, EPHY_GXL_ID), > + writel(REG2_RESERVED_28 | FIELD_PREP(REG2_PHYID, EPHY_GXL_ID), > priv->regs + ETH_REG2); > > /* Enable the internal phy */ Reviewed-by: Neil Armstrong _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic