From mboxrd@z Thu Jan 1 00:00:00 1970 From: ben.dooks@codethink.co.uk (Ben Dooks) Date: Wed, 15 Feb 2017 12:34:02 +0000 Subject: [PATCH 09/18] mmc: meson-gx: change interrupt name In-Reply-To: References: <420b75a9-b8c2-b3d7-ae60-3ed8a5a18ead@gmail.com> Message-ID: <7ccaed3c-199c-2897-5280-2790ce3676ea@codethink.co.uk> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On 14/02/17 20:06, Heiner Kallweit wrote: > So far the driver name is used for the interrupt. Therefore in > /proc/interrupts we can't tell which interrupt belongs to which > SD_EMMC port. > So let's use the device name instead (what is the OF node name). > > Signed-off-by: Heiner Kallweit > --- > drivers/mmc/host/meson-gx-mmc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c > index a67c811e..1a76c925 100644 > --- a/drivers/mmc/host/meson-gx-mmc.c > +++ b/drivers/mmc/host/meson-gx-mmc.c > @@ -757,9 +757,9 @@ static int meson_mmc_probe(struct platform_device *pdev) > writel(IRQ_EN_MASK, host->regs + SD_EMMC_STATUS); > writel(IRQ_EN_MASK, host->regs + SD_EMMC_IRQ_EN); > > - ret = devm_request_threaded_irq(&pdev->dev, host->irq, > - meson_mmc_irq, meson_mmc_irq_thread, > - IRQF_SHARED, DRIVER_NAME, host); > + ret = devm_request_threaded_irq(&pdev->dev, host->irq, meson_mmc_irq, > + meson_mmc_irq_thread, IRQF_SHARED, > + dev_name(&pdev->dev), host); > if (ret) > goto free_host; > I am surpised that the default is not to use dev_name(dev), I wonder if that should be something that devm_request_threaded_irq() could be updated to do. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius