From: Neil Armstrong <neil.armstrong@linaro.org>
To: iav@iav.lv, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: amlogic: meson-sm1-odroid-hc4: wire the RTC alarm interrupt
Date: Tue, 20 Oct 2026 10:38:41 +0200 [thread overview]
Message-ID: <7ccd519c-9c45-4a3c-a0d4-2a082c4c0306@linaro.org> (raw)
In-Reply-To: <20261019-hc4-rtc-alarm-irq-v1-1-078fc79e596f@iav.lv>
On 10/19/26 23:52, Igor Velkov via B4 Relay wrote:
> From: Igor Velkov <iav@iav.lv>
>
> The PCF8563 on the OLED/RTC add-on board drives its interrupt output
> to GPIOX_5, pin 4 of the P1 header, but the rtc node does not describe
> it. The alarm interrupt is therefore never delivered and cannot wake
> the board.
>
> Describe the line as a level-low interrupt of the GPIO interrupt
> controller.
>
> Tested on ODROID-HC4: the alarm interrupt fires and wakes the board
> from s2idle.
>
> Assisted-by: LLM
> Signed-off-by: Igor Velkov <iav@iav.lv>
> ---
> This needs commit 5831f5fef100 ("rtc: pcf8563: pass the driver data to
> the alarm interrupt handler") in the rtc tree: without it the first
> alarm oopses. Waking from s2idle also needs commit 5b6e2a46b80d
> ("irqchip/meson-gpio: Allow the GPIO interrupts to wake the system")
> in tip irq/drivers.
> ---
> arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> index 5f15c2299509..25a8a60e152c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid-hc4.dts
> @@ -105,6 +105,8 @@ rtc: rtc@51 {
> status = "okay";
> compatible = "nxp,pcf8563";
> reg = <0x51>;
> + interrupt-parent = <&gpio_intc>;
> + interrupts = <IRQID_GPIOX_5 IRQ_TYPE_LEVEL_LOW>;
> wakeup-source;
> };
> };
>
> ---
> base-commit: b44e2be772f866985cafdf90355285069ea68495
> change-id: 20261020-hc4-rtc-alarm-irq-b2b8c68d54f5
>
> Best regards,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2026-10-20 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 21:52 Igor Velkov via B4 Relay
2026-10-20 8:38 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ccd519c-9c45-4a3c-a0d4-2a082c4c0306@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iav@iav.lv \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®