From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEBFBC43613 for ; Thu, 20 Jun 2019 03:36:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7337520675 for ; Thu, 20 Jun 2019 03:36:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="twBFI2uf"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="R24VUbUF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7337520675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=50BEtC3gfiaxu1D2hnhjzpB3X7enSrgmuSCdpoN6LkQ=; b=twBFI2ufMYBKaW jD3aV2YZ2WkHVoIZMMtw0j6GfMWOF33kfLkyIitKlCjAjjZQKVwHTNJfjiES8aayDaa3x9amDMYCt DgfW47uujvfYtdVoE1Jk8YT3EF9mqSf3DalbwY+2MdymRoCrZyCDLST6vMhNxBGCwBJ03KA3lpqvu 6gviJDJZirpmbY3a8g1VWfU8lmNZqIt+guukbHym11B+CayH1+3yAhwisFMiLs7gbeSOYjKnhA+yV jVNSYNOqHPO/BtINV7UtuDiIddUoe4AqAVzlclJ4fJNiqdLJTGu1XsvIi+yTpMgyrzBoTONCKIdSc zaShtg3flMiMxqI0UM6w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdnrd-0003s6-Te; Thu, 20 Jun 2019 03:35:53 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdnrN-0003fO-6z for linux-amlogic@lists.infradead.org; Thu, 20 Jun 2019 03:35:39 +0000 Received: by mail-pf1-x443.google.com with SMTP id j2so829424pfe.6 for ; Wed, 19 Jun 2019 20:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=HOSCj25pO6a386fSVkhPsk9edlxIx4b0dfihdZfuotE=; b=R24VUbUFz5qZKeynsTUrq4c3dB1nc/QoAc5x5U+zHBRKmgP4irX+Qd/uz+TvIn9Dde 8hzyvekv6Gzm2FKO8q3HSyEgq8Vud578ah6rtzQ3QyhfF5il00SiTGRbeo9J2kI61H8l DMJK9uVuztUlxcdwCN4uQbImQDCa4vCH+p4Ik6/xlqe2I/Xw/gE2bLIDTnJTSR+Y4tqu 8gHa8kqfrF68JmH/Ra/8/AFn7cJw4OyG1GD5rh5Ao3DrXQ12KqDFI/Zb0oyBe3+S23fW A9aA+b8dH+CO2S4ymvs047VKJGaK3Gxqu0jofHWcLZ38fOEqvft10X5TfRunYq1TrEN+ lZKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=HOSCj25pO6a386fSVkhPsk9edlxIx4b0dfihdZfuotE=; b=PZ0kVv4kgvbQnNPdottGYJwm9ml3ED2IrlUHw8Ms8gxWYvrqsAZ7PMbQO0CaiBb0ya o+vN4ZhO18Dcnvp08Zg46YMvgj0aMNN8uaU84aCmxWEjMzxV8p3oeOJkL0vH+HHa5tuz 2D0FseYtwhKYOGY1/+tv8RkyU/NchreWRdoD60Nc4FhwQmhQLG8yh0izmpFWxQNBhZ3M 464zgiqKzsI0jLoMGQWzIGhHTPMq120VggnrvDXTAVM4ZO6T6Jjj4rgn8B1XQdCI5uP2 0tav2bKyqhPHQsW7fij0i/lepq6X9juramICwsZeytiTVdxCqnqSih7aDNMj1vtf3uFf OFcA== X-Gm-Message-State: APjAAAWx51k0fr1o1ZXSxofmu6wVI92tyOx+aE6FEDYuDbuHlyGflvY7 d01xpc+FwXYPb/PCQmyDROkajg== X-Google-Smtp-Source: APXvYqymLvsH5Jne+eK0EsJ3Q4/Y0qf5ZzWcO17TxweQkCCIYK/LjuDERiWhe89FjMEwwQO+ynf3Mw== X-Received: by 2002:a63:df46:: with SMTP id h6mr10696443pgj.181.1561001732439; Wed, 19 Jun 2019 20:35:32 -0700 (PDT) Received: from localhost ([2601:602:9200:a1a5:ec6a:e4cb:28b2:e322]) by smtp.googlemail.com with ESMTPSA id 133sm23896859pfa.92.2019.06.19.20.35.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Jun 2019 20:35:31 -0700 (PDT) From: Kevin Hilman To: Martin Blumenstingl , linux-amlogic@lists.infradead.org Subject: Re: [PATCH v3 0/4] Ethernet PHY reset GPIO updates for Amlogic SoCs In-Reply-To: <20190615103832.5126-1-martin.blumenstingl@googlemail.com> References: <20190615103832.5126-1-martin.blumenstingl@googlemail.com> Date: Wed, 19 Jun 2019 20:35:27 -0700 Message-ID: <7hh88lhqtc.fsf@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190619_203537_275885_450DC619 X-CRM114-Status: GOOD ( 17.38 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, narmstrong@baylibre.com, Martin Blumenstingl , netdev@vger.kernel.org, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Martin Blumenstingl writes: > While trying to add the Ethernet PHY interrupt on the X96 Max I found > that the current reset line definition is incorrect. Patch #1 fixes > this. > > Since the fix requires moving from the deprecated "snps,reset-gpio" > property to the generic Ethernet PHY reset bindings I decided to move > all Amlogic boards over to the non-deprecated bindings. That's what > patches #2 and #3 do. > > Finally I found that Odroid-N2 doesn't define the Ethernet PHY's reset > GPIO yet. I don't have that board so I can't test whether it really > works but based on the schematics it should. > > This series is a partial successor to "stmmac: honor the GPIO flags > for the PHY reset GPIO" from [0]. I decided not to take Linus W.'s > Reviewed-by from patch #4 of that series because I had to change the > wording and I want to be sure that he's happy with that now. > > One quick note regarding patches #1 and #4: I decided to violate the > "max 80 characters per line" (by 4 characters) limit because I find > that the result is easier to read then it would be if I split the > line. > > > Changes since v1 at [1]: > - fixed the reset deassert delay for RTL8211F PHYs - spotted by Robin > Murphy (thank you). according to the public RTL8211E datasheet the > correct values seem to be: 10ms assert, 30ms deassert > - fixed the reset assert and deassert delays for IP101GR PHYs. There > are two values given in the public datasheet, use the higher one > (10ms instead of 2.5) > - update the patch descriptions to quote the datasheets (the RTL8211F > quotes are taken from the public RTL8211E datasheet because as far > as I can tell the reset sequence is identical on both PHYs) > > Changes since v2 at [2]: > - add Neil's Reviewed/Acked/Tested-by's (thank you!) > - rebased on top of "arm64: dts: meson-g12a-x96-max: add sound card" > > > [0] https://patchwork.kernel.org/cover/10983801/ > [1] https://patchwork.kernel.org/cover/10985155/ > [2] https://patchwork.kernel.org/cover/10990863/ Queued for v5.3... > Martin Blumenstingl (4): > arm64: dts: meson: g12a: x96-max: fix the Ethernet PHY reset line > ARM: dts: meson: switch to the generic Ethernet PHY reset bindings ...in branch v5.3/dt > arm64: dts: meson: use the generic Ethernet PHY reset GPIO bindings > arm64: dts: meson: g12b: odroid-n2: add the Ethernet PHY reset line The other 3 in v5.3/dt64, Thanks, Kevin _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic