From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: khilman@baylibre.com, jbrunet@baylibre.com,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, tobetter@gmail.com
Subject: Re: [PATCH 3/6] arm64: dts: meson-sm1-odroid-c4: fix hub_5v regulator gpio
Date: Fri, 4 Jun 2021 11:43:42 +0200 [thread overview]
Message-ID: <802340ba-edd1-d148-4c6b-e2eae9c2a096@baylibre.com> (raw)
In-Reply-To: <CAFBinCB+SyCmxrjJLcuy=mLsChPZ9i_1TsaWkL3kuhPO1wGwWw@mail.gmail.com>
Hi,
On 03/06/2021 20:07, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Tue, Jun 1, 2021 at 11:01 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> As described in the Odroid-C4 schematics, the HUB_5V regulator is controlled
>> by GPIOH_8 and in Open Drain since this GPIO doesn't support Push-Pull.
>>
>> Fixes: 326e57518b0d ("arm64: dts: meson-sm1: add support for Hardkernel ODROID-C4")
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> my interpretation of page 32 of the schematics [0] is that GPIOH_8 manages VCC5V
> GPIOH_4 is connected as RST_N to the RESET# pad of the USB hub -> this
> seems to match the original regulator definition
You're right, but GPIOH_4 is already a GPIO HOG, so this regulator doesn't make any sense then,
and the GPIO for the VCC_5V regulator is missing, like in patch 5.
So I'll add:
+&vcc_5v {
+ gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>;
+ enable-active-high;
+};
in odroid.dtsi instead in this patch.
Not sure what to do about the regulator-hub_5v.
Neil
>
>
> [0] https://wiki.odroid.com/_media/odroid-c4/odroid-c4_rev1.0.pdf
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2021-06-04 9:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 9:01 [PATCH 0/6] arm64: dts: meson-sm1-odroid: various fixes for C4/HC4 Neil Armstrong
2021-06-01 9:01 ` [PATCH 1/6] arm64: dts: meson-sm1-odroid: add missing enable gpio and supply for tf_io regulator Neil Armstrong
2021-06-03 18:03 ` Martin Blumenstingl
2021-06-01 9:01 ` [PATCH 2/6] arm64: dts: meson-sm1-odroid: set tf_io regulator gpio as open source Neil Armstrong
2021-06-03 18:03 ` Martin Blumenstingl
2021-06-01 9:01 ` [PATCH 3/6] arm64: dts: meson-sm1-odroid-c4: fix hub_5v regulator gpio Neil Armstrong
2021-06-03 18:07 ` Martin Blumenstingl
2021-06-04 9:43 ` Neil Armstrong [this message]
2021-06-04 10:13 ` Martin Blumenstingl
2021-06-04 10:19 ` Neil Armstrong
2021-06-01 9:01 ` [PATCH 4/6] arm64: dts: meson-sm1-odroid-hc4: disable unused USB PHY0 Neil Armstrong
2021-06-03 18:10 ` Martin Blumenstingl
2021-06-01 9:01 ` [PATCH 5/6] arm64: dts: meson-sm1-odroid-hc4: add regulators controlled by GPIOH_8 Neil Armstrong
2021-06-03 18:08 ` Martin Blumenstingl
2021-06-01 9:01 ` [PATCH 6/6] arm64: dts: meson-sm1-odroid-hc4: add spifc node to ODROID-HC4 Neil Armstrong
2021-06-03 18:10 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=802340ba-edd1-d148-4c6b-e2eae9c2a096@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=tobetter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®