From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8071C369A2 for ; Fri, 11 Apr 2025 08:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:Subject:From: MIME-Version:Date:Message-ID:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F8HixHD4yMUk6LVvNmKPmpyXGWFgeujWbzShIU2xsWY=; b=XP9fsYbNAtYsWT8Ia/rIDLbO2w AiDEVtBDRY8eqVHssC9d+fUdc3fVrr0w0b3/58qO3lUCuU4FIl185TnRaHt3LatmLonEnU0P2eKkA 9gDTQ6AE2nC8avAVBrqQTpfMuy4vzRWMMWXWmPU7/kgc0D7/BfJBqag8VEvdTPou4b2AEbd8rK7OB xSw0FgFiBoG4J3eOLnEMaDJlvjgAhpxS2JMFksIJdEjGZyYc2tH49VRXe3DaLddiu0+cHI5EWsOk1 4LFA90T1gmxxHUkazDJk9Z6Uwp2ZgM29kHhTVS9oXNXCZHrkKu6Fs/VCYQ53/6uF1CoLkT8Yn7AAf lp1DQJcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u39z8-0000000D4CG-1fw7; Fri, 11 Apr 2025 08:43:38 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u39oo-0000000D1ug-18cn for linux-amlogic@lists.infradead.org; Fri, 11 Apr 2025 08:33:00 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-39c2688619bso1031073f8f.1 for ; Fri, 11 Apr 2025 01:32:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744360376; x=1744965176; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=kZSanJ7iQqFkDAT7N/R6RJIht4vmzcKXzsOruL2cJuA=; b=a84/lzHNQZ/NNebPxSzk4X/O1KmijwsKXb8VM49/BfwNtdKTthq+rWIWjCOkRTtWS/ DbVcRTE70Gyv1ISMv9ZCNRNIoIv4Mj1LBcfVT3pf18eH1yp8oyYI8iPgesrkW7r4boEI 3Qj/bqgJUE+U1RcyAfaDnO68L4OxIhaBC/pBCj059soFk9r9e8kfotDCGprsheAYbonB cGRFrV0JtxUaxab+ooGFhmdlWZj2WLCQ9mwLSPFsMoXd8HxgC2DlBRZMsXmmzdmD5X2E UB2dYfRimy7mTU01tnmjzrMLqqwfxkXER/GGToBVz+nmDlvLA53yMAY3x8GT3GFC8oqL Prxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744360376; x=1744965176; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kZSanJ7iQqFkDAT7N/R6RJIht4vmzcKXzsOruL2cJuA=; b=v3WIwosjidNJgyufEmduo/tASfyQX58lvdY0NNLcGL0kiJmWSS0QbecJZhpsRss05m es0szcPf+Z4XJBrKsBqvnkfOWDEMK0KI7I2OYxUs5JWN8z7FYybkpwJ2XV567/tqC+V7 rliG5ETZGkIKfg+09WmNHaIrFPinaxMif8DG88ZkR7FGCiMkc6+ItrAbg1Qe9PD1t1F6 17TfdRDQePLM8rQnXJ+/x+dLzR3WdjIO/EpUt7aqevNYBgrl710JJs9qymXqGLRRNUPL /5ZFEkfFoWwtHQY/rophs4Mf98DOC4UGZd9B//+XMHEyoamBDreyBK0eN+FVk1nKcN+8 wZ1A== X-Forwarded-Encrypted: i=1; AJvYcCWwW6kUVTGCRSMryZyXQT2PdwlhY1TMZTXq4fBIk/jNCUjxFbfJplc0GlP87+vcvVQLRv/Teo7njFRZXQM3@lists.infradead.org X-Gm-Message-State: AOJu0YzZ/eK14aqz4gk9n2cPo6uOn3X99DnJ9SZ9bjyMMAefX94dBfxv gPpjTehaGEil8+w1lgqsY51/ZlLHk54XEntfjZPDv/mm9ARwamo76Gyu2j7ZMb8= X-Gm-Gg: ASbGncvzkWs/osWj2l+bE7z9WCq99Mr/X5dPPF+QAgKRk0ym3fdgdbaYKiWN+SSG8YJ 39GU0xmfaDjuljWaWARPw2vOLyWfuspeqo24MsSlNopU6Gy+66KTdhk14/UiU9iX4HZu22f6sLr OVQMWQLbVd+Kmitnx/pDsxnY9XcH3IZTEFhMfzSCi3vdT13N+pMB7yDCxxJA161JNZtIkR6Ike8 e04LIQxIDYYKphsT4E1yvInDABa0CsZDqpJqjH6SYclkLgC0lUkKtO9xBMk44fq7GBCbJ1hMkOk 1XXQs3/5+9DkeK2GA/R6gj9tOvaGfX4FdPwZ6xMTDA9tfarhFB81Q5Jj+qws4ZwIrvY8kF47dE0 DNZ9RcVas3o4g+n6CKQ== X-Google-Smtp-Source: AGHT+IESUznTZ2n4XVtcjPJCVmr0eQyeDF65o+HShMPgDvAAkIvnxepbxU/WEqcRhEcANAnPMJQR5Q== X-Received: by 2002:a05:6000:2ca:b0:391:48d4:bcf2 with SMTP id ffacd0b85a97d-39ea51eede3mr1406485f8f.12.1744360376608; Fri, 11 Apr 2025 01:32:56 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:f77b:949e:1d61:69a8? ([2a01:e0a:3d9:2080:f77b:949e:1d61:69a8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eae979835sm1328253f8f.57.2025.04.11.01.32.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Apr 2025 01:32:56 -0700 (PDT) Message-ID: <808d2fb4-4511-448e-81e9-52319fdc8673@linaro.org> Date: Fri, 11 Apr 2025 10:32:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH v1 5/6] phy: amlogic: phy-meson-axg-pcie: Simplify error handling with dev_err_probe() To: Anand Moon , Vinod Koul , Kishon Vijay Abraham I , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , "open list:GENERIC PHY FRAMEWORK" , "moderated list:ARM/Amlogic Meson SoC support" , "open list:ARM/Amlogic Meson SoC support" , open list References: <20250410133332.294556-1-linux.amoon@gmail.com> <20250410133332.294556-6-linux.amoon@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250410133332.294556-6-linux.amoon@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250411_013258_326990_CB46F0C5 X-CRM114-Status: GOOD ( 13.24 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 10/04/2025 15:33, Anand Moon wrote: > Use dev_err_probe() for phy resources to indicate the deferral > reason when waiting for the resource to come up. > > Signed-off-by: Anand Moon > --- > drivers/phy/amlogic/phy-meson-axg-pcie.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c > index 60be5cdc600b3..54baf7b8930e1 100644 > --- a/drivers/phy/amlogic/phy-meson-axg-pcie.c > +++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c > @@ -131,19 +131,15 @@ static int phy_axg_pcie_probe(struct platform_device *pdev) > struct phy_axg_pcie_priv *priv; > struct device_node *np = dev->of_node; > void __iomem *base; > - int ret; > > priv = devm_kmalloc(dev, sizeof(*priv), GFP_KERNEL); > if (!priv) > return -ENOMEM; > > priv->phy = devm_phy_create(dev, np, &phy_axg_pcie_ops); > - if (IS_ERR(priv->phy)) { > - ret = PTR_ERR(priv->phy); > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "failed to create PHY\n"); > - return ret; > - } > + if (IS_ERR(priv->phy)) > + return dev_err_probe(dev, PTR_ERR(priv->phy), > + "failed to create PHY\n"); > > base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(base)) Reviewed-by: Neil Armstrong _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic