From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v3 1/3] clk: meson-gxbb: expose clock CLKID_RNG0
Date: Mon, 27 Feb 2017 05:28:49 -0800 [thread overview]
Message-ID: <80bc00c9-dc3b-5aeb-89a0-8b427dca9b34@baylibre.com> (raw)
In-Reply-To: <4e2d12e5-f75b-3ac6-a3f7-18e8a8b7283b@gmail.com>
On 02/21/2017 10:55 PM, Heiner Kallweit wrote:
> Expose clock CLKID_RNG0 which is needed for the HW random number generator.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - added clk and DT maintainers
> - split exposing the clock and using it in DT into two patches
> - comment out clock definition in drivers/clk/meson/gxbb.h
> - silently move CLKID_SPI to the right place
> v3:
> - no changes
> ---
> drivers/clk/meson/gxbb.h | 2 +-
> include/dt-bindings/clock/gxbb-clkc.h | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
Hi Heiner,
This looks all good to me, but you should always send a cover letter for each revisions
of the patchset.
Using "git send-email" along the "--cover-letter" of "get format-patch" feature would
also help send them in a row with a up-to-date cover letter.
For the third patch, it may be good to also add the same to the GXL dtsi, no ?
Anyway :
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Thanks,
Neil
next prev parent reply other threads:[~2017-02-27 13:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 6:55 Heiner Kallweit
2017-02-22 6:59 ` [PATCH v3 2/4] ARM64: dts: meson-gx: add clock to DT binding documentation for hwrng Heiner Kallweit
2017-02-27 22:34 ` Rob Herring
2017-02-22 7:00 ` [PATCH v3 3/4] ARM64: dts: meson-gx: add clock CLKID_RNG0 to hwrng node Heiner Kallweit
2017-02-22 7:02 ` [PATCH v3 4/4] hwrng: meson: add clock handling to driver Heiner Kallweit
2017-02-27 13:28 ` Neil Armstrong [this message]
2017-03-16 10:07 ` [PATCH v3 1/3] clk: meson-gxbb: expose clock CLKID_RNG0 Herbert Xu
2017-03-16 18:24 ` Kevin Hilman
2017-03-17 8:30 ` Herbert Xu
2017-03-17 23:05 ` Kevin Hilman
2017-03-22 15:24 ` Kevin Hilman
2017-03-23 1:43 ` Michael Turquette
2017-03-23 7:56 ` Herbert Xu
2017-03-28 22:07 ` Michael Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80bc00c9-dc3b-5aeb-89a0-8b427dca9b34@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®