Re: regression caused by: "amlogic: mmc: meson-gx: add signal resampling"

[Jerome Brunet <jbrunet@baylibre.com>]

On Wed, 2019-01-16 at 12:14 +0100, Ulf Hansson wrote:
> + Jerome, Kevin
> 
> On Wed, 16 Jan 2019 at 11:13, Andreas Fenkart <afenkart@gmail.com> wrote:
> > failed to initialize builtin emmc device:
> > "mmc1: error -110 whilst initialising MMC card"
> > 
> > amlogic/meson-gxl-s905x-p212.dtb
> > linux-5.0-rc2 / 1c7fc5cbc
> > 
> > I bisected the problem and after reverting the following patch, mmc is
> > found again:
> > 
> > commit 71645e65729f0c5aef8dccf961c97fa766835bd4 (tag: mmc_bad_resable)
> > Author: Jerome Brunet <jbrunet@baylibre.com>
> > Date:   Thu Dec 6 16:18:28 2018 +0100
> > 
> >     mmc: meson-gx: add signal resampling
> > 
> >     With some eMMC devices, there is still issues with the new phase
> >     settings. Enabling signal resampling seems to solve the problem
> >     for these.
> > 
> >     Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> >     Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > 
> > /Andi
> 
> Andi, thanks for reporting and bisecting!
> 
> I have looped in Jerome and Kevin to see if they can have a look.
> Let's give them a few days before we consider the revert.

Hi Andi,

There an actual s905x p212 in kernelci which is not showing any issue, AFAIK.

https://kernelci.org/boot/meson-gxl-s905x-p212/

Have a look a this recent boot of mainline/arm64:
https://storage.kernelci.org/mainline/master/v5.0-rc2-36-gfe76fc6aaf53/arm64/defconfig/lab-baylibre-seattle/boot-meson-gxl-s905x-p212.txt

Has the p212 is ref design of the s905x, we often see the related DT used on
other device.

Is your board actually a p212 ?
If yes, could you tell us about any of the marking on PCB, such as the board
revision ?
If not, could you tell us more about your device ?

We proposing this series, I flagged that this patch and the other one (on
phase settings) needed broader testing. It could possibly cause regression for
tunning and high speed modes ... this typically show with error -5 (tunning
failed)

Here your eMMC timedout during init, so even before an attempt is made to tune
which is odd. Could you try to enable signal resampling only when going forhigh speed modes ? 

> 
> Kind regards
> Uffe



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic