mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/2] ARM64: dts: meson-gxm: Add support for Khadas VIM2
Date: Wed, 20 Sep 2017 10:29:58 +0200	[thread overview]
Message-ID: <84171990-f5f2-d7d2-2bf6-d28390daac4a@baylibre.com> (raw)
In-Reply-To: <CAFBinCD0ev5kY_5BY-fZ=fEZ7ZkKi7PdvO4NGAwzVxLEfOT=Dw@mail.gmail.com>

On 09/19/2017 07:55 PM, Martin Blumenstingl wrote:
> Hi Neil,
> 
> On Tue, Sep 19, 2017 at 4:53 PM, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> The Khadas VIM2 is a Single Board Computer, respin of the origin
>> Khadas VIM board, using an Amlogic S912 SoC and more server oriented.
>>
>> It provides the same external connectors and header pinout, plus a SPI
>> NOR Flash, a reprogrammable STM8S003 MCU, FPC Connector, Cooling FAN header
>> and Pogo Pads Arrays.
>>
>> Cc: Gouwa <gouwa@szwesion.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>>  Documentation/devicetree/bindings/arm/amlogic.txt  |   1 +
>>  arch/arm64/boot/dts/amlogic/Makefile               |   1 +
>>  .../boot/dts/amlogic/meson-gxm-khadas-vim2.dts     | 401 +++++++++++++++++++++
>>  3 files changed, 403 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
>>

[...]

>> +&external_mdio {
>> +       external_phy: ethernet-phy at 1 {
>> +               compatible = "ethernet-phy-id001c.c916", "ethernet-phy-ieee802.3-c22";
> could you please remove the compatible property and replace it with a
> comment as explained in [0]?
> 

Ok

>> +               reg = <0>;
>> +               max-speed = <1000>;
>> +       };
>> +};
>> +

[...]

> 
> with that and Jerome's comments fixed:
> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> 
> 
> Regards,
> Martin
> 
> 
> [0] http://lists.infradead.org/pipermail/linux-amlogic/2017-September/004729.html
> 

Thanks Martin !

I'll send a v2 when eMMC DTS patches goes in 4.14-rc2.

Neil

  reply	other threads:[~2017-09-20  8:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19 14:53 [PATCH 0/2] ARM64: " Neil Armstrong
2017-09-19 14:53 ` [PATCH 1/2] ARM64: dts: meson-gxl: Take eMMC data strobe out of eMMC pins Neil Armstrong
2017-09-19 14:53 ` [PATCH 2/2] ARM64: dts: meson-gxm: Add support for Khadas VIM2 Neil Armstrong
2017-09-19 16:11   ` Jerome Brunet
2017-09-19 17:55   ` Martin Blumenstingl
2017-09-20  8:29     ` Neil Armstrong [this message]
2017-09-21 23:47   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84171990-f5f2-d7d2-2bf6-d28390daac4a@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®