mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 1/2] soc: amlogic: meson-gx-pwrc-vpu: don't print error message on probe deferral
Date: Wed, 17 Jan 2018 09:26:01 +0100	[thread overview]
Message-ID: <854c4057-c108-d0c5-f2e5-84d49fc64018@baylibre.com> (raw)
In-Reply-To: <0ca085b2-0a0a-be51-2873-5f5a5ca2d2da@gmail.com>

On 21/12/2017 20:40, Heiner Kallweit wrote:
> The error message may be misleading in case of probe deferral
> (happens on my Odroid-C2). Therefore don't print it in this case.
> 
> Fixes: 75fcb5ca4b46 "soc: amlogic: add Meson GX VPU Domains driver"
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
> index 2bdeebc48..3adb2f2ec 100644
> --- a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
> +++ b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
> @@ -184,7 +184,8 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev)
>  
>  	rstc = devm_reset_control_array_get(&pdev->dev, false, false);
>  	if (IS_ERR(rstc)) {
> -		dev_err(&pdev->dev, "failed to get reset lines\n");
> +		if (PTR_ERR(rstc) != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "failed to get reset lines\n");
>  		return PTR_ERR(rstc);
>  	}
>  
> 

This will definitely help removing this useless message when booting nominally.

Acked-by: Neil Armstrong <narmstrong@baylibre.com>

  reply	other threads:[~2018-01-17  8:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21 19:37 [PATCH 0/2] soc: amlogic: meson-gx-pwrc-vpu: fix two issues Heiner Kallweit
2017-12-21 19:40 ` [PATCH 1/2] soc: amlogic: meson-gx-pwrc-vpu: don't print error message on probe deferral Heiner Kallweit
2018-01-17  8:26   ` Neil Armstrong [this message]
2017-12-21 19:41 ` [PATCH 2/2] soc: amlogic: meson-gx-pwrc-vpu: fix error on shutdown when domain is powered off Heiner Kallweit
2018-01-17  8:34   ` Neil Armstrong
2018-01-19 18:09 ` [PATCH 0/2] soc: amlogic: meson-gx-pwrc-vpu: fix two issues Kevin Hilman
  -- strict thread matches above, loose matches on Subject: below --
2017-12-20 19:07 [PATCH 1/2] soc: amlogic: meson-gx-pwrc-vpu: don't print error message on probe deferral Heiner Kallweit
2017-12-21 13:33 ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=854c4057-c108-d0c5-f2e5-84d49fc64018@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®