From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BE2DC48BD7 for ; Thu, 27 Jun 2019 05:37:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50E1E2133F for ; Thu, 27 Jun 2019 05:37:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Lvf6sApO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="vIOK3+Wl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50E1E2133F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=renesas.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rKvoETySvycIj+vr6XXKTlUlgcfVvMRcUdVgm+38YCE=; b=Lvf6sApOliAW9R s5jUz3Yfull7llGQsj6Bt7Ez7E3Nm6pmP9PlzUe/vihYhpSg1Hus2Ycz5SwZYNEabGjf22iEyOD4N G53bvDndD+jJYN//NSKV8pP9QGqu62RaC2zn8ArVsnVYJPFy04uuJto61QrgYYjatx3RBezeb1zI3 PvlU/KRxugcWGZSWv9agXc6ww7Qzk4tfc0w8qZCQmOVVuN1ZNBKz9Z9N7ffhoPBLOZQmbq8PooSjf R8zHyrKT4VeCgMcjd9VC93XT9+rw+A69fx6e5tnOr7tRghnTzXh7rZFPU0is2Yrm2zgGr7Nk39Q+S DyoDPi/ZUpvXeLo++eKA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hgN5j-0008F7-VA; Thu, 27 Jun 2019 05:37:04 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hgMsS-00013R-13 for linux-amlogic@bombadil.infradead.org; Thu, 27 Jun 2019 05:23:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=blT/3obAbU3ArjGUJnAShK9iZbefAHR/nyMhxxhKhEs=; b=vIOK3+WlHmbhyA/fHjgN7KbWz EugoZ6nUEb4XTMFh/mUHp1TfS8ZE6LH5DK1WXK/HZDpVoAh6jbfnTCxr8KwOO6adWhAn/ROVL305Q Vl72mCmZtBHntzKSIY68fvU4YJM+TUuO2KVTTT1m0Cavd8wVk2tk+2c3FXS8lz919FB5+HkwGeglU 0aaDXaQSfh9aQQAXy0lYI5ktBDCyoTISVVtFShSFJPe5HDq52ppRPcduU0u2G8mmKCBRMlEUNqxZO bqxKhlMCQoZzJIt+D39he9U20CtMe3K1TDNdwHGwZGlMVHf+BayieFgocfBaiJPhNXt82BML5o1jI lHrQMBDUw==; Received: from relmlor1.renesas.com ([210.160.252.171] helo=relmlie5.idc.renesas.com) by casper.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hgHbL-0000dG-85 for linux-amlogic@lists.infradead.org; Wed, 26 Jun 2019 23:45:21 +0000 Date: 27 Jun 2019 08:44:08 +0900 X-IronPort-AV: E=Sophos;i="5.62,421,1554735600"; d="scan'208";a="19798148" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie5.idc.renesas.com with ESMTP; 27 Jun 2019 08:44:08 +0900 Received: from morimoto-PC.renesas.com (unknown [10.166.18.140]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 2BEA9410CD74; Thu, 27 Jun 2019 08:44:08 +0900 (JST) Message-ID: <877e97kj7s.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Jerome Brunet Subject: Re: [PATCH 2/2] ASoC: soc-core: support dai_link with platforms_num != 1 In-Reply-To: <20190626133617.25959-3-jbrunet@baylibre.com> References: <20190626133617.25959-1-jbrunet@baylibre.com> <20190626133617.25959-3-jbrunet@baylibre.com> User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190627_004519_517328_89D35C49 X-CRM114-Status: GOOD ( 15.91 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Kevin Hilman , Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , linux-amlogic@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Jerome Thank you for your patch. This is nice ! > Add support platforms_num != 1 in dai_link. Initially, the main purpose of > this change was to make the platform optional in the dai_link, instead of > inserting the dummy platform driver. > > This particular case had just been solved by Kuninori Morimoto with > commit 1d7689892878 ("ASoC: soc-core: allow no Platform on dai_link"). > > However, this change may still be useful for those who need multiple > platform components on a single dai_link (it solves one of the FIXME > note in soc-core) > > Cc: Kuninori Morimoto > Signed-off-by: Jerome Brunet > --- (snip) > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > index 002ddbf4e5a3..3053a4a461b3 100644 > --- a/sound/soc/soc-core.c > +++ b/sound/soc/soc-core.c > @@ -887,7 +887,7 @@ static int soc_bind_dai_link(struct snd_soc_card *card, > struct snd_soc_dai_link *dai_link) > { > struct snd_soc_pcm_runtime *rtd; > - struct snd_soc_dai_link_component *codecs; > + struct snd_soc_dai_link_component *dlc; > struct snd_soc_component *component; > int i; This is nitpick, but having both "codecs" and "platforms" is easy to read / understand code. > @@ -1051,22 +1053,22 @@ static int soc_init_dai_link(struct snd_soc_card *card, > struct snd_soc_dai_link *link) > { > int i; > - struct snd_soc_dai_link_component *codec; > + struct snd_soc_dai_link_component *dlc; Same here. For other parts Acked-by: Kuninori Morimoto Thank you for your help !! Best regards --- Kuninori Morimoto _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic