From: Ronald Claveau <linux-kernel-dev@aliel.fr>
To: gowtham <gowtham@ferryfair.com>
Cc: robh@kernel.org, bhelgaas@google.com, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
linux-pci@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, yue.wang@Amlogic.com,
lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org,
neil.armstrong@linaro.org
Subject: Re: [PATCH] PCI: meson: Fix PERST# timing by asserting reset before LTSSM enable
Date: Sat, 20 Jun 2026 10:59:36 +0200 [thread overview]
Message-ID: <88a57a54-ef19-43f0-8164-a1cb21974918@aliel.fr> (raw)
In-Reply-To: <20260618020025.2739cb96@slick.ferryfair.com>
On 6/17/26 10:30 PM, gowtham wrote:
> Hi Ronald,
> I see you submitted the patch. Last couple of days I've been fixing the
> etherenet of my BPiCM4+Waveshare-io-base-b due to which I couldn't test
> your patch any sooner. Now I got my ethernet working but now I couldn't
> reproduce the issue *without* either of our patches!!!
>
> Anyway it's proper to initialize PCIe with RESET Active but I think
> meson_pcie_assert_reset(mp) will give sufficient time to PCIe devices
> to complete the reset cycle.
>
Hi Gowtham,
No worries and no rush to me.
I think it's due to how uboot set the gpio before the linux boot for my
issue, and that does not seem to be relevant for yours.
Thank you for testing the patch.
> ---
> drivers/pci/controller/dwc/pci-meson.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-meson.c
> b/drivers/pci/controller/dwc/pci-meson.c index 0694084f612..c28ab40c9ff
> 100644 --- a/drivers/pci/controller/dwc/pci-meson.c
> +++ b/drivers/pci/controller/dwc/pci-meson.c
> @@ -308,8 +308,8 @@ static int meson_pcie_start_link(struct dw_pcie
> *pci) {
> struct meson_pcie *mp = to_meson_pcie(pci);
>
> - meson_pcie_ltssm_enable(mp);
> meson_pcie_assert_reset(mp);
> + meson_pcie_ltssm_enable(mp);
>
> return 0;
> }
--
Best regards,
Ronald
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-06-20 9:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-14 1:56 Gowtham Kudupudi
2026-06-14 2:31 ` sashiko-bot
2026-06-15 10:34 ` Ronald Claveau
2026-06-16 6:06 ` neil.armstrong
2026-06-16 23:36 ` gowtham
2026-06-17 20:30 ` gowtham
2026-06-20 8:59 ` Ronald Claveau [this message]
2026-06-20 15:11 ` Manivannan Sadhasivam
2026-06-20 16:40 ` Ronald Claveau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88a57a54-ef19-43f0-8164-a1cb21974918@aliel.fr \
--to=linux-kernel-dev@aliel.fr \
--cc=bhelgaas@google.com \
--cc=gowtham@ferryfair.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kwilczynski@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=yue.wang@Amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox