From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86B59CD5BD1 for ; Sun, 31 May 2026 08:41:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9w1/E8WHgQ1N2Y6STlECddCvHB3PphQ5EbFqg/vxaOY=; b=XlkUNtQbn7hs8P hpPIL8m5OzQ49fvBmt0EMti1VULBQWBo+zM7GkvjY9POMiTlzS9hqsqF4UYlQ7sbiP1GMqh8ZouUj A+GxGK/LJ4DB14BlAUW+imcB1CEJw1t2YBDr6smpLdAM6ofrP6Yo8yrzlgNpSJINyhTJwAsgVzblJ HeftbfIL7z1Ea/ksnSdVAVhR/SynOg6Sw6HLUYBG6rNHbiHIFDxoKajLhjjWR8OrDPyCaQ2+ETamL OXBBNDBcHQ8TXK2kNL2LzY7XPgShfXayzBp0M6AU9M1QRuP+f6LmshGeTTVJ6haSnwGGzFRfdHJWr j/AhqeC74Un3zlpF/rzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wTbjx-00000009O1h-3R4x; Sun, 31 May 2026 08:41:49 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wTbju-00000009O0t-1yml for linux-amlogic@lists.infradead.org; Sun, 31 May 2026 08:41:48 +0000 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64V3eMfW1850478 for ; Sun, 31 May 2026 08:41:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LSSHczkNGcyBGltE9n3/Qlzx5H59gm8hjXNQO9LCZb8=; b=cZ4EEOxo0R0xP1cU uqEA0gxK3qJB1dGa68+Nwb6j4ak5fuDQlS+mSQwNHLxzaWQugt7N/jSHX7xGjQHU /Wx7Biv29sb+3uEqCwmeL/3HlvBvd7Ez9cXTqGkIyr7H9GzeA1vrscAzIxVlcQTz QKPhnJiszl/4ncCOB0uKTz2mvSS+s8D1QTjL7TCYZe373Pf2EweWbOmho5rKUzlt iWmuHqsHfVwtdjZmdEqtxeCeGfm1drRIff/3atjIOM84xaQftodrJRA190q8/nup ezmg/o/mi5XtNKReiCHe7kjKMgR/E4o7FGHPRtGaqMmCHaIuIHdyZEd592EaJDY+ 2CMboQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efux52q1g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 31 May 2026 08:41:44 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-516d19f68acso184775901cf.2 for ; Sun, 31 May 2026 01:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780216904; x=1780821704; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LSSHczkNGcyBGltE9n3/Qlzx5H59gm8hjXNQO9LCZb8=; b=CRPqd0ty7tbpn7jMBx9cDMNVAoIvgkcIetyxscXDCsuKMtWwC7CF4qC+DDQ3gH6Pbz iCKp9XkNYZQCenNoIjq/OGxh5NYd2PPEEXR/NyfGxbjmai2ly5JE5UdDmAhvX7LhZEEy uRjPn9Gb708WbsV7RghKmODZNQc5xFhFHQWUzKzluaSuKpUmw2D7mFm01CuIe8dOp4g0 IS5QdmtnmuuVoa6ske/ue03tdpvas1Isya4exUz4j8YZ00KJZJC0wPHWDg1cWNS3eUTZ 1uLSJ0TSYCI6h5gWXNqA9R2vf+FWQfh/jZs9oMBJCJAdrznqbGCZJZ4yEN6jXYw6nQz4 Z9pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780216904; x=1780821704; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LSSHczkNGcyBGltE9n3/Qlzx5H59gm8hjXNQO9LCZb8=; b=IyA0/UrHXN7lDlcJLEjq4NERC3sS2ezkhJn2Ov0fGV/horkijF4hlnoGv31rs0tRSG ftc3LEeLX2+B7EtFvvat+jlwKOSv+M4KOF03tPHYVJRm9rVKobjdpqfurJ+b3qILvLg1 YkTb/9Zq4bjvR8N8PdOu8M5yqtsMjY/36pvp/o8HFDWioQfui0dsw+1WoMhBfN6Uevkn AgJT1w2ID/YwjLXEqBAKGGBVkszZAFSxZc0hZZRKkkb+FgGrFD5wH7VMjjoV9yXrYGCJ Z4Y4Q2Asfl46MP6bmi0bnK/ULeqXwt7Qt4mKoVz9beuZJZ8TnNTtxTmOhrkuZA7gnzf9 bd2Q== X-Forwarded-Encrypted: i=1; AFNElJ9WjvxvHYuIG6ouaQc2rntOz39X47g40y3ufCuhUmXkZ9khQRLP0QCGTx63YR1F8yR238TVqcb+EopZYpLA@lists.infradead.org X-Gm-Message-State: AOJu0YwgHbf9RDaHSYgV/0GZjmXtM5WsO1hOeNxzo6pnGpjoWcxxGGcf fevloiX0nKBT0IOQGMa+mNUV9EwrqFlfZ6kmoLYu/YXQoEpbDjMiHN47PmFvMhy8pH0E80SwQ7Q f44EwlhrOalT3pWaEOmV3RoTYM6RresiaGKTLk6Zq/guMB1YlFBW8Fuh7zBtM8DqAAMmspbyMIg == X-Gm-Gg: Acq92OG31SG0y1htB6rIZkK7zWJF7rlEbuFaKcj2MW6UzNJJ72kxe28tyb+h9XBY8XN MuuNYfZj+YdY3EwZRO4Llpemkf5oRgD0ftTznME+9E58F7JZDdxF5YO8PaNhtWXWiPEd95WhDXj u5TJ987iaiMq+VY568O6VL4A51R/cwwzeKYU+L3IOYzVW+N0Sii+tDKCawxnRxLA0MoTnf811if m6ioKoV3ulPW/4Bch/R+p+rKoQFqrwoXlkgluSPdfs7bj3BFMBwcxP2TT2+8Mya/gFYli/3GvYM 4g2fFrHO30JzC5EOBJvbAVr4wgINPOWvbf5qT5fTNDGwHeHaqoA52wujgsKnCfDsYWuslY5+Jy7 ngg0/D8XtTdkuX9aeSORlvC3LUwJWhJx8gwGeEGCZhBamI1XCXg6NF8ovDZTdquHDltBQkEFohD l1 X-Received: by 2002:a05:622a:4d43:b0:516:e031:9321 with SMTP id d75a77b69052e-5173a6ce03amr101633771cf.11.1780216903602; Sun, 31 May 2026 01:41:43 -0700 (PDT) X-Received: by 2002:a05:622a:4d43:b0:516:e031:9321 with SMTP id d75a77b69052e-5173a6ce03amr101633501cf.11.1780216903167; Sun, 31 May 2026 01:41:43 -0700 (PDT) Received: from [192.168.2.1] (146725694.box.freepro.com. [130.180.211.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4909cabfd6esm166065495e9.15.2026.05.31.01.41.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 May 2026 01:41:42 -0700 (PDT) Message-ID: <8c11a91b-cfbf-4b9c-a46f-907989bf8305@oss.qualcomm.com> Date: Sun, 31 May 2026 10:41:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] firmware: meson: sm: add stub functions when CONFIG_MESON_SM is disabled To: linux-kernel-dev@aliel.fr, Neil Armstrong , Daniel Lezcano , Zhang Rui , "Rafael J. Wysocki" , Lukasz Luba Cc: Guillaume La Roque , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Mark Brown , kernel test robot References: <20260531-fix-missing-meson_sm-symbol-v2-1-1def8c3c169f@aliel.fr> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <20260531-fix-missing-meson_sm-symbol-v2-1-1def8c3c169f@aliel.fr> X-Proofpoint-GUID: u3yM8NJwr5qIqk9-i5p8qfiP_W5oW2mL X-Proofpoint-ORIG-GUID: u3yM8NJwr5qIqk9-i5p8qfiP_W5oW2mL X-Authority-Analysis: v=2.4 cv=BdnoFLt2 c=1 sm=1 tr=0 ts=6a1bf448 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=uw/3876vWhRnNVL35W6mqQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=QjikovrxREX5USwBPxUA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTMxMDA5NSBTYWx0ZWRfX3R95fjnSVQ87 Q4i1S64T9ks04utUbZNk5LPBjpIgTE8d8rwLpcsG/4H735CkFq4QtWeNwvBWYnWJJoZkztJSu9y XRVeG8SRYoIvrVuHdLfUqVgk6OM9DHjMB4h+PMvGFlSeCB6RM61yFiMXFpU+aNMU992P7FqyrKL rnq3btMjcEnBhQv1nfqx0wZQ59pidX8LIbdnYrLRw8/XpDQ4vj7nYIGn+owHwjgb3MIGZ1WD996 DkJYoblOSp34ktgEEuss2tqwsjLTPShDDT9Zx5MMeh8kOCFv1gxUkvP18F06SBNGBUC0GOCOeaD mmWrtQevxUPydeAe0tTVIY+UXh1o7PEEUg6eZA3H7vBUCErQnpAatiYyxO/T2omadfU4D1nd8CE D/kXKBohUQ/wjWnGx9UP7OH8N4twh0FOCWX4H0/5yBaaoEWSU0NU2OYCvaJ5Sjw93148eIGYels /iUg37eQDpACvPNKIlQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-31_03,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 phishscore=0 bulkscore=0 clxscore=1015 malwarescore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605310095 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260531_014146_508981_433B28D0 X-CRM114-Status: GOOD ( 17.34 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 5/31/26 09:51, Ronald Claveau via B4 Relay wrote: > From: Ronald Claveau > > After merging the thermal tree, linux-next build (arm_multi_v7 > defconfig) failed like this: > > arm-linux-gnueabihf-ld: drivers/thermal/amlogic_thermal.o: in function `amlogic_thermal_probe_sm': > /tmp/next/build/drivers/thermal/amlogic_thermal.c:196:(.text+0x2f4): undefined reference to `meson_sm_get' > arm-linux-gnueabihf-ld: /tmp/next/build/drivers/thermal/amlogic_thermal.c:205:(.text+0x320): undefined reference to `meson_sm_get_thermal_calib' > > Add inline stub implementations of meson_sm_get() and > meson_sm_get_thermal_calib() behind an #else guard so that drivers > including this header can be compiled without CONFIG_MESON_SM . > > Fixes: b21d88de6918 ("thermal/drivers/amlogic: Add support for secure monitor calibration readout") > Closes: https://lore.kernel.org/oe-kbuild-all/202605291530.en7aGn7w-lkp@intel.com/ > Reported-by: Mark Brown > Reported-by: kernel test robot > Signed-off-by: Ronald Claveau > --- > Changes in v2: > - Replace #ifdef CONFIG_MESON_SM by #if IS_ENABLED(CONFIG_MESON_SM) > to cover builtin and module in config. > - Add missing trailers for kernel test robot. > - Link to v1: https://lore.kernel.org/r/20260530-fix-missing-meson_sm-symbol-v1-1-3fb672b989d4@aliel.fr > --- > include/linux/firmware/meson/meson_sm.h | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/include/linux/firmware/meson/meson_sm.h b/include/linux/firmware/meson/meson_sm.h > index 3ebc2bd9a9760..baecdaf263f41 100644 > --- a/include/linux/firmware/meson/meson_sm.h > +++ b/include/linux/firmware/meson/meson_sm.h > @@ -27,8 +27,25 @@ int meson_sm_call_write(struct meson_sm_firmware *fw, void *buffer, > int meson_sm_call_read(struct meson_sm_firmware *fw, void *buffer, > unsigned int bsize, unsigned int cmd_index, u32 arg0, > u32 arg1, u32 arg2, u32 arg3, u32 arg4); > + > +#if IS_ENABLED(CONFIG_MESON_SM) > + > struct meson_sm_firmware *meson_sm_get(struct device_node *firmware_node); > int meson_sm_get_thermal_calib(struct meson_sm_firmware *fw, u32 *trim_info, > u32 tsensor_id); Do you really want to compile meson_sm as a module ? _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic