From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92F79C52D6F for ; Mon, 19 Aug 2024 16:08:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dPf3rico80sEOYB/1HZB6qL2x9CvnLYSGgEM1e65e6A=; b=bKVRHZE/MqLtrS54EBxPBWpfnG Ijp0ApfuKPX209SG7PSxikJ96r+XujRkoh1V+HKj/nb73FWiL54LA7GqGOJG8QCR3R1uPyxx6ltU5 1aFbGGNKgwOGeyrY2YE0M3hIH/zOp58Zksu/qsU9nFT2lXjD6tAU/AiO3MlXduUuRJo0KpJWMx6Y9 EB3TpEvbOtwJbsUs7/zJBSfl57ko0y+lIAUWBowpx4oCzJscc4PAI//+es5nIGwbhs3yeIBBBTjB6 ou6yHWvsPkK4poDFTtBNZwoMjzimmSKHzIdWcX+UDd1wazbSMOsAwaWzyFYie6odxfMcwPknRvLHy EbfezpZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg4vy-0000000263O-1UDE; Mon, 19 Aug 2024 16:08:42 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sg4vu-0000000261L-2nOc for linux-amlogic@lists.infradead.org; Mon, 19 Aug 2024 16:08:40 +0000 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-42817f1eb1fso36007895e9.1 for ; Mon, 19 Aug 2024 09:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724083716; x=1724688516; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=zZXB9eWC3jaAHU2DUNdmRkIBaE/QcD6ULIBMGv3bqxc=; b=RTlTJzFxS1oM6Ft2Ktu07KotgQkKJJ9Fhn3nj2eq5Suuw561goOTVM7OgxNZkXXNwn WVyCH+l2E3vS5RC6AUqbYx+d96aXtL/5/oqSe4O88DFeq3k4hdmbFVTS3ZRp4NlqSm8r 5hJvMR84FrogMDW0rdHoucZ0M6Q2UEpDpLIVGex06pNPu9yKN6NDEpdkW8LvkpD/ES/L LDNMoeazVe7DvnP43KU47olH3vN/x6tabksaxHsyyFOjplhq1EqNNrNNgNdKSuUdd0+a Ld4b87r0dLkAxH29/BuGTJLSgxhhU39M6Og9snxznGUb2dySoaX6LxeEuO2WRojVORN/ RZig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724083716; x=1724688516; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zZXB9eWC3jaAHU2DUNdmRkIBaE/QcD6ULIBMGv3bqxc=; b=c02prIHWsEg9eyUgWxIGPPZJRN4zQwLLBRk64PzhegI6n1v4Jf/COO3qEyhouzeJXG NWs5P+o/XojvvSA+bvjL9HTHN8ntrzmVhegzFI0i6lnkJ+rBECzA6CvA8K50IH8Kwid6 Mgys4nntJjclWQVo67jchIO6a8R8nGX3sRpOZL5mq5QxnVNam70J2f0LApypNC8Xo1Rp yatPuK9LahjowjVcZ5R3UQn3aj5Ose+f/QqWDccPPMyfDd2wtzd/YuuCWxIr6GMI8r9D 0RPGf0A0CNkUsCO6BhWo8aA/Ek02zLFsrEmzLr55gOmYImux3joJMSqW6vYn1BIOrlJX Ytag== X-Forwarded-Encrypted: i=1; AJvYcCWcdbiC6O9qh3BAVWn18coy1QxyxpzTuv/iAIvXcHUh6UpaJW6UPj43+9n+nJpi6WLr7SFXI6qxTiOXnt91bXVaZlbCgSRvDywCsUBkYsJdvRw= X-Gm-Message-State: AOJu0YzVZ9CXMOYlIW+bZX0yrcIfWbhcCPSIiF7SKSbRxQuxeYbu/8PV xxMREnL8hzomXCjvi6JwiOg/MKGtXSpPbNEDQmPMEkVm2g9j06soBQvbKktEGt8= X-Google-Smtp-Source: AGHT+IEctf6m+H+GvqS9ocINagd6WHDY07QHzWWDGizaBipSBKg2CM+6kL3bWVQiaT3seaoGIZrXQA== X-Received: by 2002:a05:600c:4445:b0:426:60e4:c691 with SMTP id 5b1f17b1804b1-429ed7891demr73947145e9.11.1724083716047; Mon, 19 Aug 2024 09:08:36 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:f54e:4b0a:5175:5727? ([2a01:e0a:982:cbb0:f54e:4b0a:5175:5727]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ed785708sm114205685e9.37.2024.08.19.09.08.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 09:08:35 -0700 (PDT) Message-ID: <8d49f427-a0f8-44f4-bd46-86fbf385deab@linaro.org> Date: Mon, 19 Aug 2024 18:08:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Subject: Re: [PATCH 5/9] drm/meson: dw-hdmi: split resets out of hw init. To: Jerome Brunet , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter Cc: Kevin Hilman , Martin Blumenstingl , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240730125023.710237-1-jbrunet@baylibre.com> <20240730125023.710237-6-jbrunet@baylibre.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20240730125023.710237-6-jbrunet@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240819_090838_747560_AB0555E1 X-CRM114-Status: GOOD ( 17.51 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 30/07/2024 14:50, Jerome Brunet wrote: > This prepares the migration to regmap usage. > > To properly setup regmap, the APB needs to be in working order. > This is easier handled if the resets are not mixed with hw init. > > More checks are required to determine if the resets are needed > on resume or not. Add a note for this. > > Signed-off-by: Jerome Brunet > --- > drivers/gpu/drm/meson/meson_dw_hdmi.c | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c > index 5cd3264ab874..47aa3e184e98 100644 > --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c > @@ -581,11 +581,6 @@ static void meson_dw_hdmi_init(struct meson_dw_hdmi *meson_dw_hdmi) > /* Bring HDMITX MEM output of power down */ > regmap_update_bits(priv->hhi, HHI_MEM_PD_REG0, 0xff << 8, 0); > > - /* Reset HDMITX APB & TX & PHY */ > - reset_control_reset(meson_dw_hdmi->hdmitx_apb); > - reset_control_reset(meson_dw_hdmi->hdmitx_ctrl); > - reset_control_reset(meson_dw_hdmi->hdmitx_phy); > - > /* Enable APB3 fail on error */ > if (!meson_vpu_is_compatible(priv, VPU_COMPATIBLE_G12A)) { > writel_bits_relaxed(BIT(15), BIT(15), > @@ -675,6 +670,10 @@ static int meson_dw_hdmi_bind(struct device *dev, struct device *master, > return PTR_ERR(meson_dw_hdmi->hdmitx_phy); > } > > + reset_control_reset(meson_dw_hdmi->hdmitx_apb); > + reset_control_reset(meson_dw_hdmi->hdmitx_ctrl); > + reset_control_reset(meson_dw_hdmi->hdmitx_phy); > + > meson_dw_hdmi->hdmitx = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(meson_dw_hdmi->hdmitx)) > return PTR_ERR(meson_dw_hdmi->hdmitx); > @@ -765,6 +764,11 @@ static int __maybe_unused meson_dw_hdmi_pm_resume(struct device *dev) > if (!meson_dw_hdmi) > return 0; > > + /* TODO: Is this really necessary/desirable on resume ? */ Yes to reset the HDMI controller to it's default state, not sure if the note is important here. > + reset_control_reset(meson_dw_hdmi->hdmitx_apb); > + reset_control_reset(meson_dw_hdmi->hdmitx_ctrl); > + reset_control_reset(meson_dw_hdmi->hdmitx_phy); > + > meson_dw_hdmi_init(meson_dw_hdmi); > > dw_hdmi_resume(meson_dw_hdmi->hdmi); _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic