From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDDD9C44515 for ; Mon, 20 Jul 2026 10:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XqRTSJUunGls5xz+wk13uF7TkC4HCw2wIZznODbCRyY=; b=j+EfKZ69A1wcJL 97GaKgiBPJ70rlP1A/dKfwa+5rcpmt55roJI60ua3wQ6VwiUVhiDCGxFqs5ah5bLrfMdbt0mDYscU sR1NsueyOF8aVFWdmc8AUvm0LVsiCOEaihh1s1nyNP0LykNHT88CPteiIdRSQ+UO4HyH77YG9iTgF tc3n3tnDbxEGOg3bJQ2I/ZZH+DT/+k2NnXJfHvL3QUFs2/tahHFXKwZlFupB9sO5glenWdPJEA/09 Q7NWU7DJUYgK61mcI//84zQb+ciM9gLLMaUm4umUDbqHVxWPhhRwOunpH55CP+2YA4AVwwcfd8go+ Rl1jy9vbKIGPQ4ObBgxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wllKH-00000006Ui3-0lAV; Mon, 20 Jul 2026 10:34:21 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wllKE-00000006Uh1-2FaM for linux-amlogic@lists.infradead.org; Mon, 20 Jul 2026 10:34:19 +0000 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66K9vrSE2189023 for ; Mon, 20 Jul 2026 10:34:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dHewdeqeVNcntSNtq50xsoiwCnZXmMXQMckL5dStHcY=; b=hwhQA1MsitD5btdd JqsR13zTYhd8UuvDpj3UXwKAUPj0TaA5iOiiU4fX3Dl0h9mYVWFrxWQnM99+iJ4g ANjDaLE4FRRQuJu80TqDoXekVCzaxkVLwtmfcI6PJATKmGrTqGCbOwiZ6OYuFEI8 jOh4DmrE1VTsI8P1lcjSb7gPcsmo/WiWwBtB1y7hkqOgW7fehnlM2UbgKLWXfV/O 0zqdnt3bPWdecuslW7LhPv33ZFqcWXsEp5FqPXPeNcHWCq9XKRAlNqK/qi2+P7In a+NLjlbpaVpOdDkCchhe5vLBtRiXesNklo53o2kwUF+jj/a2DAXWu6+yKeS9pNvl II1jsg== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fgd04vrs9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 10:34:16 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92ef13b61bcso1679205885a.1 for ; Mon, 20 Jul 2026 03:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784543656; x=1785148456; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=dHewdeqeVNcntSNtq50xsoiwCnZXmMXQMckL5dStHcY=; b=fEdAbZoZC9RX3k6k8ueg4WjF+5Kcpt9KyYbtZieAix/H6SYFMQd5IJsrzGjG0FJ6oV b6KczyKcUHnmHzrzS8acHc6QGs3m22jRpzjzLGhkDqnyHY/avB+dCDMOu4Y1/zD/UviA Jxx9Yq0ujAP0XtMyJ9CDY0oNHN+cONpaxYGnKrL40dmn82tI30bjoFFcF6nsQFpzcQWJ dO2nMNmbrFquZgLo0J1VjacQQFDlsmuB+VewJl7GSCiGKJcZf8SyBVE4nvkVa9PuUziD +ty1xxWyxXazV0VEasCaQgdjqK8sRwhb3cj7ARVSXfEUlIX2ylumgXxiQtd+cswP50dW nkdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784543656; x=1785148456; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:subject:from:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dHewdeqeVNcntSNtq50xsoiwCnZXmMXQMckL5dStHcY=; b=QNwekZC6aMUfz+J1Nc+n5xBlQej5bQSNWhtUweSWG2FmBFzTSvCz/EzMYodLVjzx+A NOojicZlCgcZ65liHXUOy1kEXK8fvTw33/SLymx6/y4GZZv6sw+QcBPXWWo33kzmzZZP +7bnPAtcLddM40IdLKwU/8c1IWItJPwwvhRiRtGFZfHQRSBtCH0MORtBQyBhlnB2ljPt YnawssLUgVULcq/Fz9Idutq2qiKOweH/UnaXiJuwJyUEsTIVYlvdLbHqcQWOIO2Y6hYo vtmxI14IHeBDJJ1erM7w5hPzxPR0xeYNkmWqCFOldGYYSIlWXzCS1ncqjxyZwD3Fd8kW ei4A== X-Forwarded-Encrypted: i=1; AHgh+RomQr7uj7RoRa0G+6SpfvsWgXovUf5NGtQFbJWjX6rc0K1tOo4mgTKcJbvUU8HVhBA6U3Put6gExycdf7L2@lists.infradead.org X-Gm-Message-State: AOJu0Yw0lH21zac2vrKPYlQXOdog7uT7bYAmia0gQOfwv30AMEFJANGV 7TT6g3frL+N9zLESBPq0CvP3Ty4PhvUkL4iiNqnDob06y0SoBaqP50VJAzNTv07eOiCVmfpe13M xm4LMgsWwyXFByPJPrLd8TZhaWm+/0T9i4EOjezz0sZVBywGeZZjScHpZPL3g7hfpH58QB9+ENA == X-Gm-Gg: AfdE7cmjZ2rUYqXV110gVADhi1Lao0INXCCtEFerLsQU0lCNgGnrPw3VQImX5oG9AcT k9R7OGWR54+4L9NrxcX5t+2Wmgbin0otvByG0x2Olkxh+9i/+UEsAgqN7SwTsnT6JnBno4D3JNY HdJJo79/Kxa4vYP5X8HcdkeUQzr1MY7UAcZVN0MIkT16zLTDWqElf7YfkUFclNuZ2kYEHxCNVFx 0Mf5W85WfB+LnQcX+h4xhHT3zSXw+GiskN0+ir++C1bmBAlb629qWlQSTE0SelE0xtHSdD+FnFZ tAXVybJmF4nfijnbngi9gaQClKckpP4FyWsbVYmVP1BFZnSJ5RncAd0Sj3uEawlv0FcRX00x3Gc MnE7H5F6Q7CF34oeWMaVcoOupLJIotmK0vNQdoQ+SPN17pO3ex33EGNNc4Lki/QsiJx5400ezK8 3ArB9lyejmM91p21L1GGeDR2/+Tg5Wyha1297jeEND5HaxsH8ZfB4f5psjBfco/Yvpsh8= X-Received: by 2002:ac8:5d88:0:b0:519:55c0:a1e5 with SMTP id d75a77b69052e-5213c8e3aa1mr118701351cf.8.1784543655259; Mon, 20 Jul 2026 03:34:15 -0700 (PDT) X-Received: by 2002:ac8:5d88:0:b0:519:55c0:a1e5 with SMTP id d75a77b69052e-5213c8e3aa1mr118700261cf.8.1784543654369; Mon, 20 Jul 2026 03:34:14 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c17009adff3sm439489566b.2.2026.07.20.03.34.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 03:34:13 -0700 (PDT) Message-ID: <8d86ca46-d329-4e65-a7bf-2b79fccddf05@oss.qualcomm.com> Date: Mon, 20 Jul 2026 12:34:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: johannes.goede@oss.qualcomm.com Subject: Re: [PATCH 8/8] media: ov2740: remove NULL reg_write callback To: Sakari Ailus , Link Mauve Cc: Srinivas Kandagatla , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Tianshu Qiu , Bingbu Cao , Mauro Carvalho Chehab , Aaro Koskinen , Andreas Kemnade , Roger Quadros , Tony Lindgren , Lee Jones , Arnd Bergmann , Greg Kroah-Hartman , Bartosz Golaszewski , "Vaibhaav Ram T.L" , Kumaravel Thiagarajan , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vladimir Zapolskiy , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Praveen Teja Kundanala , Kalyani Akula , Michal Simek , Alexandre Belloni , Joshua Kinard , Antoniu Miclaus , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Daniel Almeida , Tamir Duberstein , Alexandre Courbot , =?UTF-8?Q?Onur_=C3=96zkan?= , Daniel Lezcano , Johan Hovold , Ronald Claveau , Salah Triki , Yury Norov , David Carlier , Achim Gratz , Alexander Sverdlin , Patrick Wicki , Markus Heidelberg , Markus Perkins , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , Bjorn Helgaas , Abd-Alrhman Masalkhi , Chen Ni , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, mfd@lists.linux.dev, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, imx@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-rtc@vger.kernel.org, linux-sunxi@lists.linux.dev, rust-for-linux@vger.kernel.org References: <20260715175229.24672-1-linkmauve@linkmauve.fr> <20260715175229.24672-9-linkmauve@linkmauve.fr> Content-Language: en-US, nl In-Reply-To: X-Authority-Analysis: v=2.4 cv=POs/P/qC c=1 sm=1 tr=0 ts=6a5df9a8 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=2y0c4oOAfBMx015UTLoA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDExNyBTYWx0ZWRfX3dv5VfyIOnLB Ff8cQw0hl8NLKwUDYXgC3wFuiAsCsl4rhE34zWSKaxfC8OeoCsiHjNm/x2T2bmnv3AOvNB7FU4S M4VX7X1XgXsX3ajKF4rcyDfmaXVu6gtMjqG1DvcVexO+XWIOx3XUM/ku1RSYpIZliojf0pVCDUf MCm0u00FvBTamWjey/YzckR2ruckEcW8MQjy5CdNmsF5ZMHxS8dtyVkUVZIaWMjGgTKBA8PPSx4 TKlnbjRIU4y0LjQcekgZagxU8ki32L5FNhQkvWnU+KOp80fYHzhtVFvDrl5eoxYkys+6DzIkK6H abdAB3FvvoIioemNtDs61BuFfRFxaPBE7meeeejJNh2FSHUs4CV1/gY9sZSU/dT8MutQCk7YFOF tr4OvO1tMEuRikzIkYoSBBrQQfBkZ9emNGEDfkE5aLASxz7eoDeYFYG2OKbOwhO4skePvIHtEO0 TFrm8CG1nMb5MhKIV0w== X-Proofpoint-ORIG-GUID: DpTPllXUeEziuGIcYoFi5QUT_nSaqQiu X-Proofpoint-GUID: DpTPllXUeEziuGIcYoFi5QUT_nSaqQiu X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDExNyBTYWx0ZWRfX+LdFSzkosUyF 14CAZPn/O7JMAX+Att5DSu829Mq5lkvR9NJevtQPn5D6+GB0AEsYctX/N7469kVNiEa59bymYIF d5YK3nKbRhgLxaKzu7Rx3PjVlNUUguM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_02,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1011 suspectscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200117 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260720_033418_692959_71B23E84 X-CRM114-Status: GOOD ( 20.24 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Sakari, On 20-Jul-26 11:39, Sakari Ailus wrote: > Hi, > > On Wed, Jul 15, 2026 at 07:52:24PM +0200, Link Mauve wrote: >> This field is already initialized to NULL, so there is no reason to >> write it again. >> >> This prevents it from appearing while grepping for reg_write in the >> future. >> >> Signed-off-by: Link Mauve > > I believe we need a real name here. We don't need a real name / official name here, just a "known identity", IOW not "anonoymous1234" since Link has clearly is using Link Mauve as their internet identity (given they went through the trouble of registering it as a domain) I believe the S-o-b here is fine as is. See: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d4563201f33a022fc0353033d9dfeb1606a88330 where the "real name" policy was weakened to "known identity". Regards, Hans > >> --- >> drivers/media/i2c/ov2740.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c >> index fb590dfadda1..799eca4023da 100644 >> --- a/drivers/media/i2c/ov2740.c >> +++ b/drivers/media/i2c/ov2740.c >> @@ -1271,7 +1271,6 @@ static int ov2740_register_nvmem(struct i2c_client *client, >> nvmem_config.compat = true; >> nvmem_config.base_dev = dev; >> nvmem_config.reg_read = ov2740_nvmem_read; >> - nvmem_config.reg_write = NULL; >> nvmem_config.priv = nvm; >> nvmem_config.stride = 1; >> nvmem_config.word_size = 1; > > I think it'd be nicer to do the initialisation in variable declaration -- > all the information is available already there. > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic