From: Xianwei Zhao <xianwei.zhao@amlogic.com>
To: neil.armstrong@linaro.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [PATCH V2 1/6] soc: amlogic: modify some power domains property
Date: Thu, 24 Aug 2023 16:32:37 +0800 [thread overview]
Message-ID: <8dff604b-116f-4f61-956c-4ca2ab43babd@amlogic.com> (raw)
In-Reply-To: <cdab27cb-fea4-4f09-8a66-ce1aa1090186@linaro.org>
Hi Neil,
Thanks for your replay.
On 2023/8/24 16:24, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
>
> Hi,
>
> On 24/08/2023 07:59, Xianwei Zhao wrote:
>> From: "xianwei.zhao" <xianwei.zhao@amlogic.com>
>>
>> Some power domains for C3 can be using runtime PM,
>> remove ALWAYS_ON property. And add some power domains
>> description when ALWAYS_ON property.
>
> The subject should now be:
> genpd: amlogic: ....
>
> same for patches 2 & 5.
Will do.
>
>>
>> Signed-off-by: xianwei.zhao <xianwei.zhao@amlogic.com>
>> ---
>> V1 -> V2: None
>> ---
>> drivers/genpd/amlogic/meson-secure-pwrc.c | 25 ++++++++++++-----------
>> 1 file changed, 13 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/genpd/amlogic/meson-secure-pwrc.c
>> b/drivers/genpd/amlogic/meson-secure-pwrc.c
>> index 89c881c56cd7..5ac2437ab8ad 100644
>> --- a/drivers/genpd/amlogic/meson-secure-pwrc.c
>> +++ b/drivers/genpd/amlogic/meson-secure-pwrc.c
>> @@ -122,18 +122,19 @@ static struct meson_secure_pwrc_domain_desc
>> a1_pwrc_domains[] = {
>> };
>>
>> static struct meson_secure_pwrc_domain_desc c3_pwrc_domains[] = {
>> - SEC_PD(C3_NNA, 0),
>> - SEC_PD(C3_AUDIO, GENPD_FLAG_ALWAYS_ON),
>> - SEC_PD(C3_SDIOA, GENPD_FLAG_ALWAYS_ON),
>> - SEC_PD(C3_EMMC, GENPD_FLAG_ALWAYS_ON),
>> - SEC_PD(C3_USB_COMB, GENPD_FLAG_ALWAYS_ON),
>> - SEC_PD(C3_SDCARD, GENPD_FLAG_ALWAYS_ON),
>> - SEC_PD(C3_ETH, GENPD_FLAG_ALWAYS_ON),
>> - SEC_PD(C3_GE2D, GENPD_FLAG_ALWAYS_ON),
>> - SEC_PD(C3_CVE, GENPD_FLAG_ALWAYS_ON),
>> - SEC_PD(C3_GDC_WRAP, GENPD_FLAG_ALWAYS_ON),
>> - SEC_PD(C3_ISP_TOP, GENPD_FLAG_ALWAYS_ON),
>> - SEC_PD(C3_MIPI_ISP_WRAP, GENPD_FLAG_ALWAYS_ON),
>> + SEC_PD(C3_NNA, 0),
>> + SEC_PD(C3_AUDIO, 0),
>> + SEC_PD(C3_SDIOA, 0),
>> + SEC_PD(C3_EMMC, 0),
>> + SEC_PD(C3_USB_COMB, 0),
>> + SEC_PD(C3_SDCARD, 0),
>> + /* ETH is for ethernet online wakeup, and should be always on */
>> + SEC_PD(C3_ETH, GENPD_FLAG_ALWAYS_ON),
>> + SEC_PD(C3_GE2D, 0),
>> + SEC_PD(C3_CVE, 0),
>> + SEC_PD(C3_GDC_WRAP, 0),
>> + SEC_PD(C3_ISP_TOP, 0),
>> + SEC_PD(C3_MIPI_ISP_WRAP, 0),
>> SEC_PD(C3_VCODEC, 0),
>> };
>>
>>
>> base-commit: 413f5c02929bb33042bbc4ee233166550a5fca70
>
> With changed subject:
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-08-24 8:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 5:59 [PATCH V2 0/6] Power: T7: add power domain driver Xianwei Zhao
2023-08-24 5:59 ` [PATCH V2 1/6] soc: amlogic: modify some power domains property Xianwei Zhao
2023-08-24 8:24 ` Neil Armstrong
2023-08-24 8:32 ` Xianwei Zhao [this message]
2023-08-24 5:59 ` [PATCH V2 2/6] soc: amlogic: add driver to support power parent node Xianwei Zhao
2023-08-24 8:27 ` Neil Armstrong
2023-08-24 8:42 ` Xianwei Zhao
2023-08-24 5:59 ` [PATCH V2 3/6] soc: amlogic: init power domain state Xianwei Zhao
2023-08-24 8:30 ` Neil Armstrong
2023-08-24 8:46 ` Xianwei Zhao
2023-08-24 5:59 ` [PATCH V2 4/6] dt-bindings: power: add Amlogic T7 power domains Xianwei Zhao
2023-08-24 15:07 ` Conor Dooley
2023-08-26 18:00 ` Lucas Tanure
2023-08-24 5:59 ` [PATCH V2 5/6] soc: amlogic: Add support for T7 power domains controller Xianwei Zhao
2023-08-24 8:30 ` Neil Armstrong
2023-08-24 8:49 ` Xianwei Zhao
2023-08-24 5:59 ` [PATCH V2 6/6] arm64: dts: add support for T7 power domain controller Xianwei Zhao
2023-08-24 8:32 ` Neil Armstrong
2023-08-24 8:51 ` Xianwei Zhao
2023-08-26 17:59 ` Lucas Tanure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dff604b-116f-4f61-956c-4ca2ab43babd@amlogic.com \
--to=xianwei.zhao@amlogic.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®