From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B87E6C04EBF for ; Wed, 5 Dec 2018 09:50:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6AE50213A2 for ; Wed, 5 Dec 2018 09:50:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LJMMizum"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="2BNmtNQK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6AE50213A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j8V2s3d6J2CPvxmRoUxCp8ZdvC7kyBB2q/7+RsmZcEM=; b=LJMMizumw1F0+V bDU9LIWAPmC0Ths8BAu81EDqnGNNYX1k0MWI2YlB596K4Hok7GK0jlLATvjj29AdyCZxmQ92+jwUW iCx+fJ9u5WlUNdgrP+a0SaMtfIuQ7b4bzhzyys77FEg2Gqar/Fw1WkdERCS1rwEN8Q16UGDAd7ug2 3uxcprQTmc6SRzhu8kBkfXoq6jcTQCRzCjigkyXAyRLbGbDQJKqIeQHkACIlxckhIPOPm0/m6YOr5 U2iETjg5phxb55mUNDBt4yu8w7H+uaLpLcWuEwafwPUERDU5aPe5TY+bRL5ImQQ3YJ8xCotxTLZNj xijcItDmMixF/XAXWT5g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUTp8-00066z-Ak; Wed, 05 Dec 2018 09:50:30 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUTp1-00064p-4r for linux-amlogic@lists.infradead.org; Wed, 05 Dec 2018 09:50:28 +0000 Received: by mail-wm1-x341.google.com with SMTP id f81so9715608wmd.4 for ; Wed, 05 Dec 2018 01:50:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:openpgp:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=gqoBHPXRX0wL423klMkp/s1NeEjCE7o35Zc0WMCTKo8=; b=2BNmtNQKoMDaaCmgcMocM2duV+fXNwIg1FlcHFcLiSWhz5fl8VOmeojeutZI2cIpSz RovxFsIZ/RqgU8Gz00oF28O0b/WDX7fGZk5sT8A+ESH27OkofpUD0ox8wmgWWslr/4Xq 10fOHgalKnT65QtO8wlVH6NOrta/sUPDGJ14tWUSFGHgmW7Be1WG/SSGrC5gWW3SDO4p TM4QTngcGttOsTvm9jjZmPjOdNppCgNv28e55KXjCTKCcMJJGeIAoPQWwPxikLX3bX1l aN/RySHmfElAroH7MspXIZrI7CEaC8nEYIHPdiZesMhmoAW7tScRs09PL5wxVD5iRG8M XkDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=gqoBHPXRX0wL423klMkp/s1NeEjCE7o35Zc0WMCTKo8=; b=OlYHygXktcF9UTTYUilY0uIgigGxrn1xocRQz6hlkfzB4JGH/1KhU4vbUTuKD072Cf cAKL5/0omjikWM3iaSXn03B/fRpCOKQ4PHP+zt/+64Fd1vsirQlUtnqPrlO+4uY2tuw8 B5/L1CcBYa2cYuFQYsIz6awzsln/SbamPgMET8YqEGC95jCD7DnUokAATEu19VhLUlUv jdHFEfDqgXso2thh7SINw9edqNPWyjxzU+ewOYKwxtPv1dg2eMUN0MT/60nSDrNPtsg/ +DoWfDg8AEkse1V3DalBjJglPa5irwW2+wJLsDGfieyL1hmAMOCZ2uzfjYbGPic6JviD Bpxw== X-Gm-Message-State: AA+aEWY1H9Pv1HNUkhNzdbYPzFPjjHPZDF48qxRt8SliJEUB6UlO76QC iKBi0fx0b6znXVTCR7QdFhpa5w== X-Google-Smtp-Source: AFSGD/V6OC/G6E6U4PeuKD+pktM2BMjIg+gtWzEgHsGXxQnBH1KrW7MzLAt6cuA2jHIH0Wlf4M7g7Q== X-Received: by 2002:a1c:2e43:: with SMTP id u64mr15863419wmu.52.1544003411300; Wed, 05 Dec 2018 01:50:11 -0800 (PST) Received: from ?IPv6:2a01:cb1d:4ce:ea00:819f:4d34:9af9:e67? ([2a01:cb1d:4ce:ea00:819f:4d34:9af9:e67]) by smtp.gmail.com with ESMTPSA id v6sm19433623wro.57.2018.12.05.01.50.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 01:50:10 -0800 (PST) Subject: Re: [PATCH 0/5] clk: meson: axg: add 32k clock generation To: Jerome Brunet , Kevin Hilman , Carlo Caione References: <20181204165310.20806-1-jbrunet@baylibre.com> From: Neil Armstrong Openpgp: preference=signencrypt Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT7CwHsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIXOwE0ETVkGzwEIALyKDN/O GURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYpQTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXM coJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hi SvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY4yG6xI99NIPEVE9lNBXBKIlewIyVlkOa YvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoMMtsyw18YoX9BqMFInxqYQQ3j/HpVgTSv mo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUXoUk33HEAEQEAAcLAXwQYAQIACQUCTVkG zwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfnM7IbRuiSZS1unlySUVYu3SD6YBYnNi3G 5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa33eDIHu/zr1HMKErm+2SD6PO9umRef8V8 2o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCSKmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+ RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJ C3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTTQbM0WUIBIcGmq38+OgUsMYu4NzLu7uZF Acmp6h8g Organization: Baylibre Message-ID: <8e7ae6ab-a38b-d2ef-ecfc-58d198821b9c@baylibre.com> Date: Wed, 5 Dec 2018 10:50:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181204165310.20806-1-jbrunet@baylibre.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181205_015026_603099_DBCA2349 X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 04/12/2018 17:53, Jerome Brunet wrote: > The goal of this patchset is to add the internal generation of the > 32768Hz clock within the axg AO clock controller. > > This was initially added has the CEC clock on gxbb. To properly > integrate it on the axg, a simpler 'dual divider' driver is added. > Then gxbb AO clock controller is reworked to use it. Finally the 32k > clock tree is added to the AXG. > > This patchset requires depends on this CCF change [0] > > [0]: https://lkml.kernel.org/r/20181204163257.32085-1-jbrunet@baylibre.com > > Jerome Brunet (5): > dt-bindings: clk: meson: add ao slow clock path ids > clk: meson: clean-up clock registration > clk: meson: add dual divider clock driver > clk: meson: gxbb-ao: replace cec-32k with the dual divider > clk: meson: axg-ao: add 32k generation subtree > > drivers/clk/meson/Makefile | 3 +- > drivers/clk/meson/axg-aoclk.c | 175 +++++++++++++++-- > drivers/clk/meson/axg-aoclk.h | 13 +- > drivers/clk/meson/clk-dualdiv.c | 130 +++++++++++++ > drivers/clk/meson/clkc.h | 19 ++ > drivers/clk/meson/gxbb-aoclk-32k.c | 193 ------------------- > drivers/clk/meson/gxbb-aoclk.c | 238 +++++++++++++++++++----- > drivers/clk/meson/gxbb-aoclk.h | 20 +- > drivers/clk/meson/meson-aoclk.c | 15 +- > include/dt-bindings/clock/axg-aoclkc.h | 7 +- > include/dt-bindings/clock/gxbb-aoclkc.h | 7 + > 11 files changed, 527 insertions(+), 293 deletions(-) > create mode 100644 drivers/clk/meson/clk-dualdiv.c > delete mode 100644 drivers/clk/meson/gxbb-aoclk-32k.c > Good move, it's good to have a common driver to enable USB device support for GX and AXg families since they depends on the slow_clk path. Tested-by: Neil Armstrong and Acked-by: Neil Armstrong And applied on next/drivers Neil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic