From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BAACC2BA19 for ; Wed, 15 Apr 2020 08:51:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00BEA206F9 for ; Wed, 15 Apr 2020 08:51:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Fu+P0q6/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="EAPLwH0N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00BEA206F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7aF6/+n73lPbExuDZqQPStrvKm5HIQA6gCfSDFW5qWo=; b=Fu+P0q6/1a9hLK gPbRvKsEEoCdopPp8yl9Ifzlsgmh0VeeXfEcGItVejUYjnZjyAmSd0T5HT2/un4Nft0Iy9JUFPBL2 Ip81Ovv8khbhbbeoaYKS3zwvbdk0C20zIEW5SzBWPSfvDvaNgk/MstGr84CMbxT/pd4S7acA5uuFq bbDoXDIXINZ7lBp8scNJ6/KZiBfnKm5g+xA49dW53WePDrJ4bbYrU9AouRtdqeg6lC32EAjruvQOK xP+h+VkodwAViEX/M6Ykc9b6SDYQaI0ddZbHLyQSCSdqDtVqzsUhdg/QSUkvu2KwQ1KjZ4E3XBmkb bVP/rFedNJcMkFwNwj4w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOdlX-0007bT-Al; Wed, 15 Apr 2020 08:51:27 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOdlK-0007O7-OL for linux-amlogic@lists.infradead.org; Wed, 15 Apr 2020 08:51:17 +0000 Received: by mail-wm1-x343.google.com with SMTP id x4so16428082wmj.1 for ; Wed, 15 Apr 2020 01:51:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:autocrypt:organization:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=v0vxNepfmbCVO2pjiPVGMZ1nlG/9vSikCXlDStur+y8=; b=EAPLwH0NhIMDwtJJ2bWprHprO73wldrdAUl3IDOWpyt5N7xZRpSq4v7ZRrtkKWGhQs afP7RRQWt4rSqLdbjO/X/pNyNgSLzE5LnmVxvlRWh709Z0Z3FtjQOExo6/N5cA30UT9w Dts29jC0BvLi0Wz0EhvYpur3H3BIYQYFQ0vgi2oLsSZwh9lm3I39JYwOsDaE58fnl2Mi IXU/gm17YSXEXCtT9cthm0BPliM2ezFOrdMXmCMB9SuqQOXgaIL6j7nnQ7qFqAObPdLg uwPAA2IielMHS/3xI8VKgdYnl40Qhvp6oIBOtP/025MI+jakSnpo19XZ+su5qWxjzO/s 1Hjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=v0vxNepfmbCVO2pjiPVGMZ1nlG/9vSikCXlDStur+y8=; b=OV/zlRZaZ70qraTNnEj50xeQaqKaIpIUzLqy9BbM3QhZzq8/i+4zuyeZrAZRNuOGOD LueTTjnMaueR9taTyTDU/TImByG06FtTxpYqiPeB9UOGAk1E3mCfhMoh9cvCNoQF/J43 AyV76DWyiMhX9EbtigoV5cFda3L6KsQ2lXJKjjd1p8IyVczl4i4oxDZO4SFC4s2zN3vu JrEVNUBOFWD8cJKdtTesYSH5JULmfOpgzyBh3ur9tCBUzHlPPIo00H/KJuoB9ERyV8/9 MZyUQtik9ULUQzGkgFyTxU8XFApiRsnCyyMJ08zDitmzU4onwKUlMwxC+peEdsXIB6ns oHNg== X-Gm-Message-State: AGi0PuY7O2fT/EGIiGVygbm7MmpZgoy1EqxqCuZaCkiW9BPNr3Szi1ih BlyCZSBZxDsQk90EVYujJ2nKkg== X-Google-Smtp-Source: APiQypLF5toBswWpyDxDYMtR9h6DMT/RcYmPvwszy/EWIgrvbtujo1PdN/K4Bn4pMuQJfjiFF4TaCA== X-Received: by 2002:a1c:c302:: with SMTP id t2mr4181612wmf.85.1586940672963; Wed, 15 Apr 2020 01:51:12 -0700 (PDT) Received: from ?IPv6:2a01:e35:2ec0:82b0:39cc:a07:8b48:cc56? ([2a01:e35:2ec0:82b0:39cc:a07:8b48:cc56]) by smtp.gmail.com with ESMTPSA id v16sm21906787wml.30.2020.04.15.01.51.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2020 01:51:12 -0700 (PDT) Subject: Re: [PATCH RFC v1 2/4] dt-bindings: power: meson-ee-pwrc: add support for the Meson GX SoCs To: Martin Blumenstingl , robh+dt@kernel.org, khilman@baylibre.com, linux-amlogic@lists.infradead.org References: <20200414201457.229131-1-martin.blumenstingl@googlemail.com> <20200414201457.229131-3-martin.blumenstingl@googlemail.com> From: Neil Armstrong Autocrypt: addr=narmstrong@baylibre.com; prefer-encrypt=mutual; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKE5laWwgQXJtc3Ryb25nIDxuYXJtc3Ryb25nQGJheWxpYnJlLmNvbT7CwHsEEwEKACUC GyMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheABQJXDO2CAhkBAAoJEBaat7Gkz/iubGIH/iyk RqvgB62oKOFlgOTYCMkYpm2aAOZZLf6VKHKc7DoVwuUkjHfIRXdslbrxi4pk5VKU6ZP9AKsN NtMZntB8WrBTtkAZfZbTF7850uwd3eU5cN/7N1Q6g0JQihE7w4GlIkEpQ8vwSg5W7hkx3yQ6 2YzrUZh/b7QThXbNZ7xOeSEms014QXazx8+txR7jrGF3dYxBsCkotO/8DNtZ1R+aUvRfpKg5 ZgABTC0LmAQnuUUf2PHcKFAHZo5KrdO+tyfL+LgTUXIXkK+tenkLsAJ0cagz1EZ5gntuheLD YJuzS4zN+1Asmb9kVKxhjSQOcIh6g2tw7vaYJgL/OzJtZi6JlIXOwU0EVid/pAEQAND7AFhr 5faf/EhDP9FSgYd/zgmb7JOpFPje3uw7jz9wFb28Cf0Y3CcncdElYoBNbRlesKvjQRL8mozV 9RN+IUMHdUx1akR/A4BPXNdL7StfzKWOCxZHVS+rIQ/fE3Qz/jRmT6t2ZkpplLxVBpdu95qJ YwSZjuwFXdC+A7MHtQXYi3UfCgKiflj4+/ITcKC6EF32KrmIRqamQwiRsDcUUKlAUjkCLcHL CQvNsDdm2cxdHxC32AVm3Je8VCsH7/qEPMQ+cEZk47HOR3+Ihfn1LEG5LfwsyWE8/JxsU2a1 q44LQM2lcK/0AKAL20XDd7ERH/FCBKkNVzi+svYJpyvCZCnWT0TRb72mT+XxLWNwfHTeGALE +1As4jIS72IglvbtONxc2OIid3tR5rX3k2V0iud0P7Hnz/JTdfvSpVj55ZurOl2XAXUpGbq5 XRk5CESFuLQV8oqCxgWAEgFyEapI4GwJsvfl/2Er8kLoucYO1Id4mz6N33+omPhaoXfHyLSy dxD+CzNJqN2GdavGtobdvv/2V0wukqj86iKF8toLG2/Fia3DxMaGUxqI7GMOuiGZjXPt/et/ qeOySghdQ7Sdpu6fWc8CJXV2mOV6DrSzc6ZVB4SmvdoruBHWWOR6YnMz01ShFE49pPucyU1h Av4jC62El3pdCrDOnWNFMYbbon3vABEBAAHCwn4EGAECAAkFAlYnf6QCGwICKQkQFpq3saTP +K7BXSAEGQECAAYFAlYnf6QACgkQd9zb2sjISdGToxAAkOjSfGxp0ulgHboUAtmxaU3viucV e2Hl1BVDtKSKmbIVZmEUvx9D06IijFaEzqtKD34LXD6fjl4HIyDZvwfeaZCbJbO10j3k7FJE QrBtpdVqkJxme/nYlGOVzcOiKIepNkwvnHVnuVDVPcXyj2wqtsU7VZDDX41z3X4xTQwY3SO1 9nRO+f+i4RmtJcITgregMa2PcB0LvrjJlWroI+KAKCzoTHzSTpCXMJ1U/dEqyc87bFBdc+DI k8mWkPxsccdbs4t+hH0NoE3Kal9xtAl56RCtO/KgBLAQ5M8oToJVatxAjO1SnRYVN1EaAwrR xkHdd97qw6nbg9BMcAoa2NMc0/9MeiaQfbgW6b0reIz/haHhXZ6oYSCl15Knkr4t1o3I2Bqr Mw623gdiTzotgtId8VfLB2Vsatj35OqIn5lVbi2ua6I0gkI6S7xJhqeyrfhDNgzTHdQVHB9/ 7jnM0ERXNy1Ket6aDWZWCvM59dTyu37g3VvYzGis8XzrX1oLBU/tTXqo1IFqqIAmvh7lI0Se gCrXz7UanxCwUbQBFjzGn6pooEHJYRLuVGLdBuoApl/I4dLqCZij2AGa4CFzrn9W0cwm3HCO lR43gFyz0dSkMwNUd195FrvfAz7Bjmmi19DnORKnQmlvGe/9xEEfr5zjey1N9+mt3//geDP6 clwKBkq0JggA+RTEAELzkgPYKJ3NutoStUAKZGiLOFMpHY6KpItbbHjF2ZKIU1whaRYkHpB2 uLQXOzZ0d7x60PUdhqG3VmFnzXSztA4vsnDKk7x2xw0pMSTKhMafpxaPQJf494/jGnwBHyi3 h3QGG1RjfhQ/OMTX/HKtAUB2ct3Q8/jBfF0hS5GzT6dYtj0Ci7+8LUsB2VoayhNXMnaBfh+Q pAhaFfRZWTjUFIV4MpDdFDame7PB50s73gF/pfQbjw5Wxtes/0FnqydfId95s+eej+17ldGp lMv1ok7K0H/WJSdr7UwDAHEYU++p4RRTJP6DHWXcByVlpNQ4SSAiivmWiwOt490+Ac7ATQRN WQbPAQgAvIoM384ZRFocFXPCOBir5m2J+96R2tI2XxMgMfyDXGJwFilBNs+fpttJlt2995A8 0JwPj8SFdm6FBcxygmxBBCc7i/BVQuY8aC0Z/w9Vzt3Eo561r6pSHr5JGHe8hwBQUcNPd/9l 2ynP57YTSE9XaGJK8gIuTXWo7pzIkTXfN40Wh5jeCCspj4jNsWiYhljjIbrEj300g8RUT2U0 FcEoiV7AjJWWQ5pi8lZJX6nmB0lc69Jw03V6mblgeZ/1oTZmOepkagwy2zLDXxihf0GowUif GphBDeP8elWBNK+ajl5rmpAMNRoKxpN/xR4NzBg62AjyIvigdywa1RehSTfccQARAQABwsBf BBgBAgAJBQJNWQbPAhsMAAoJEBaat7Gkz/iuteIH+wZuRDqK0ysAh+czshtG6JJlLW6eXJJR Vi7dIPpgFic2LcbkSlvB8E25Pcfz/+tW+04Urg4PxxFiTFdFCZO+prfd4Mge7/OvUcwoSub7 ZIPo8726ZF5/xXzajahoIu9/hZ4iywWPAHRvprXaim5E/vKjcTeBMJIqZtS4u/UK3EpAX59R XVxVpM8zJPbk535ELUr6I5HQXnihQm8l6rt9TNuf8p2WEDxc8bPAZHLjNyw9a/CdeB97m2Tr zR8QplXA5kogS4kLe/7/JmlDMO8Zgm9vKLHSUeesLOrjdZ59EcjldNNBszRZQgEhwaarfz46 BSwxi7g3Mu7u5kUByanqHyA= Organization: Baylibre Message-ID: <907211b1-c8d5-39cd-5d2b-dd41efbdc7a7@baylibre.com> Date: Wed, 15 Apr 2020 10:51:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200414201457.229131-3-martin.blumenstingl@googlemail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200415_015114_788684_2BD41FFB X-CRM114-Status: GOOD ( 17.21 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 14/04/2020 22:14, Martin Blumenstingl wrote: > The power domains on the GX SoCs are very similar to G12A. The only > known differences so far are: > - The GX SoCs do not have the HHI_VPU_MEM_PD_REG2 register (for the > VPU power-domain) > - The GX SoCs have an additional reset line called "dvin" > > Add a new compatible string and adjust the reset line expectations for > these SoCs. > > Signed-off-by: Martin Blumenstingl > --- > .../bindings/power/amlogic,meson-ee-pwrc.yaml | 27 +++++++++++++++++++ > include/dt-bindings/power/meson-gxbb-power.h | 13 +++++++++ > 2 files changed, 40 insertions(+) > create mode 100644 include/dt-bindings/power/meson-gxbb-power.h > > diff --git a/Documentation/devicetree/bindings/power/amlogic,meson-ee-pwrc.yaml b/Documentation/devicetree/bindings/power/amlogic,meson-ee-pwrc.yaml > index a0e4cf143b9c..15a29ed19327 100644 > --- a/Documentation/devicetree/bindings/power/amlogic,meson-ee-pwrc.yaml > +++ b/Documentation/devicetree/bindings/power/amlogic,meson-ee-pwrc.yaml > @@ -26,6 +26,7 @@ properties: > - amlogic,meson8-pwrc > - amlogic,meson8b-pwrc > - amlogic,meson8m2-pwrc > + - amlogic,meson-gxbb-pwrc > - amlogic,meson-g12a-pwrc > - amlogic,meson-sm1-pwrc > > @@ -42,6 +43,7 @@ properties: > > resets: > minItems: 11 > + maxItems: 12 > > "#power-domain-cells": > const: 1 > @@ -77,6 +79,31 @@ allOf: > - resets > - reset-names > > + - if: > + properties: > + compatible: > + enum: > + - amlogic,meson-gxbb-pwrc > + then: > + properties: > + reset-names: > + items: > + - const: viu > + - const: venc > + - const: vcbus > + - const: bt656 > + - const: dvin > + - const: rdma > + - const: venci > + - const: vencp > + - const: vdac > + - const: vdi6 > + - const: vencl > + - const: vid_lock > + required: > + - resets > + - reset-names > + > - if: > properties: > compatible: > diff --git a/include/dt-bindings/power/meson-gxbb-power.h b/include/dt-bindings/power/meson-gxbb-power.h > new file mode 100644 > index 000000000000..57ab38dcb6bb > --- /dev/null > +++ b/include/dt-bindings/power/meson-gxbb-power.h > @@ -0,0 +1,13 @@ > +/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */ > +/* > + * Copyright (c) 2019 BayLibre, SAS > + * Author: Neil Armstrong > + */ > + > +#ifndef _DT_BINDINGS_MESON_GXBB_POWER_H > +#define _DT_BINDINGS_MESON_GXBB_POWER_H > + > +#define PWRC_GXBB_VPU_ID 0 > +#define PWRC_GXBB_ETH_ID 1 Should be PWRC_GXBB_ETHERNET_MEM_ID like meson8 bindings. > + > +#endif > Apart that, itlooks ok. Neil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic