From: neil.armstrong@linaro.org
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linusw@kernel.org, linux-amlogic@lists.infradead.org,
linux-gpio@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: meson: meson8: fix I2S pin group names
Date: Mon, 16 Nov 2026 10:54:33 +0100 [thread overview]
Message-ID: <93587a88-7b6d-4fd7-95d0-f958fc3ce1e8@linaro.org> (raw)
In-Reply-To: <20261115224136.818305-1-martin.blumenstingl@googlemail.com>
On 11/15/26 23:41, Martin Blumenstingl wrote:
> The I2S pin groups are registered without the _pins suffix, but the
> i2s_groups array still references them with the _pins suffix.
> Update the group names so that the I2S pin groups can be referenced.
>
> Fixes: 64f6d07ba74c ("pinctrl: meson: meson8: add support for the I2S and SPDIF pins")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/pinctrl/meson/pinctrl-meson8.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson8.c b/drivers/pinctrl/meson/pinctrl-meson8.c
> index 3da7f3799c3f..1f58752637a3 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson8.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson8.c
> @@ -923,9 +923,9 @@ static const char * const i2c_b_groups[] = {
> };
>
> static const char * const i2s_groups[] = {
> - "i2s_out_ch45", "i2s_out_ch23_pins", "i2s_out_ch01_pins",
> - "i2s_in_ch01_pins", "i2s_lr_clk_in_pins", "i2s_ao_clk_in_pins",
> - "i2s_am_clk_pins", "i2s_out_ch78_pins"
> + "i2s_out_ch45", "i2s_out_ch23", "i2s_out_ch01",
> + "i2s_in_ch01", "i2s_lr_clk_in", "i2s_ao_clk_in",
> + "i2s_am_clk", "i2s_out_ch78"
> };
>
> static const char * const sd_c_groups[] = {
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2026-11-16 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 22:41 Martin Blumenstingl
2026-11-16 9:54 ` neil.armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93587a88-7b6d-4fd7-95d0-f958fc3ce1e8@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=linusw@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®