From: Xianwei Zhao <xianwei.zhao@amlogic.com>
To: Colin Ian King <colin.i.king@gmail.com>,
Liang Yang <liang.yang@amlogic.com>,
Feng Chen <feng.chen@amlogic.com>,
Mark Brown <broonie@kernel.org>,
linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: amlogic: Fix error checking on regmap_write call
Date: Mon, 15 Sep 2025 10:29:35 +0800 [thread overview]
Message-ID: <93a8e900-cca3-43d9-8f5b-c8431e20cec6@amlogic.com> (raw)
In-Reply-To: <20250913201558.1338180-1-colin.i.king@gmail.com>
Reviewed-by:Xianwei Zhao <xianwei.zhao@amlogic.com>
On 2025/9/14 04:15, Colin Ian King wrote:
> [You don't often get email from colin.i.king@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> [ EXTERNAL EMAIL ]
>
> Currently a call to regmap_write is not being error checked because the
> return checke is being performed on the variable ret and this variable
> is not assigned the return value from the regmap_write call. Fix this
> by adding in the missing assignment.
>
> Fixes: 4670db6f32e9 ("spi: amlogic: add driver for Amlogic SPI Flash Controller")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/spi/spi-amlogic-spifc-a4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-amlogic-spifc-a4.c b/drivers/spi/spi-amlogic-spifc-a4.c
> index 4ca8e82fdc67..4338d00e56a6 100644
> --- a/drivers/spi/spi-amlogic-spifc-a4.c
> +++ b/drivers/spi/spi-amlogic-spifc-a4.c
> @@ -420,7 +420,7 @@ static int aml_sfc_dma_buffer_setup(struct aml_sfc *sfc, void *databuf,
> goto out_map_data;
>
> cmd = CMD_DATA_ADDRH(sfc->daddr);
> - regmap_write(sfc->regmap_base, SFC_CMD, cmd);
> + ret = regmap_write(sfc->regmap_base, SFC_CMD, cmd);
> if (ret)
> goto out_map_data;
>
> --
> 2.51.0
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2025-09-15 2:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-13 20:15 Colin Ian King
2025-09-15 2:29 ` Xianwei Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93a8e900-cca3-43d9-8f5b-c8431e20cec6@amlogic.com \
--to=xianwei.zhao@amlogic.com \
--cc=broonie@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=feng.chen@amlogic.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®