From: Neil Armstrong <narmstrong@baylibre.com>
To: Mohammad Rasim <mohammad.rasim96@gmail.com>,
linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Marcel Holtmann <marcel@holtmann.org>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [RFC PATCH 2/4] dt-bindings: net: Add compatible for BCM4335A0 bluetooth module
Date: Mon, 18 Nov 2019 11:03:23 +0100 [thread overview]
Message-ID: <94c5d608-304f-68b8-9595-4d011b60c7e8@baylibre.com> (raw)
In-Reply-To: <20191117175606.5050-3-mohammad.rasim96@gmail.com>
Hi,
On 17/11/2019 18:56, Mohammad Rasim wrote:
>
> Available in the Ampak AP6335 WiFi/Bluetooth combo
>
> Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
> ---
> Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> index 4fa00e2eafcf..0717399191a2 100644
> --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt
> @@ -14,6 +14,7 @@ Required properties:
> * "brcm,bcm4330-bt"
> * "brcm,bcm43438-bt"
> * "brcm,bcm4345c5"
> + * "brcm,bcm4335a0"
Is there a specific reason to add a new compatible here ? it the BT interface of the BCM4335A0 different for the actual compatible modules ?
If not, simply use a common "brcm,bcm43438-bt" compatible string.
Neil
>
> Optional properties:
>
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-11-18 10:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 17:56 [RFC v2 PATCH 0/4] add support for videostrong KII Pro Mohammad Rasim
2019-11-17 17:56 ` [RFC PATCH 1/4] dt-bindings: Add vendor prefix for Videostrong Technology Co., Ltd Mohammad Rasim
2019-11-18 10:03 ` Neil Armstrong
2019-11-17 17:56 ` [RFC PATCH 2/4] dt-bindings: net: Add compatible for BCM4335A0 bluetooth module Mohammad Rasim
2019-11-18 10:03 ` Neil Armstrong [this message]
2019-11-18 17:53 ` Mohammad Rasim
2019-11-17 17:56 ` [RFC PATCH 3/4] arm64: dts: meson-gxbb: add support for Videostrong KII Pro Mohammad Rasim
2019-11-18 10:26 ` Neil Armstrong
2019-11-18 19:21 ` Mohammad Rasim
2019-11-17 17:56 ` [RFC PATCH 4/4] Bluetooth: btbcm: Add entry for BCM4335A0 UART bluetooth Mohammad Rasim
2019-11-18 10:04 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94c5d608-304f-68b8-9595-4d011b60c7e8@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=marcel@holtmann.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mohammad.rasim96@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®