From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] clocksource: add missing line break to error messages
Date: Tue, 14 Mar 2017 09:40:07 +0000 [thread overview]
Message-ID: <959bfbfb-177f-3e92-0a2c-1e283966b961@codethink.co.uk> (raw)
In-Reply-To: <20170309094710.31003-1-zajec5@gmail.com>
On 09/03/17 09:47, Rafa? Mi?ecki wrote:
> From: Rafa? Mi?ecki <rafal@milecki.pl>
>
> Printing with pr_* functions requires adding line break manually.
>
> Signed-off-by: Rafa? Mi?ecki <rafal@milecki.pl>
I've had a quick look over and there are no obvious errors.
I wonder if the of_iomap() and related calls should print an
error if they fail as all the examples here are of the form
of:
ptr = of_iomap(reource)
if (!ptr) {
pr_err("cannot remap resource\n");
...
return ERR;
}
Maybe we should look into this post this patch series.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
prev parent reply other threads:[~2017-03-14 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-09 9:47 Rafał Miłecki
2017-03-13 17:51 ` Thierry Reding
2017-03-14 9:40 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=959bfbfb-177f-3e92-0a2c-1e283966b961@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®