mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 3/5] ARM64: dts: meson-axg: add I2C DT info for Meson-AXG SoC
Date: Fri, 17 Nov 2017 14:05:50 +0100	[thread overview]
Message-ID: <96dc68e3-c394-70c4-eabe-f59d4c36150e@baylibre.com> (raw)
In-Reply-To: <20171117080236.32504-4-yixun.lan@amlogic.com>

Hi Yixun, Jian,

On 17/11/2017 09:02, Yixun Lan wrote:
> From: Jian Hu <jian.hu@amlogic.com>
> 
> There are four I2C masters in EE domain, and one I2C Master in
> AO domain, the DT info here should describe them all.
> 
> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 59 ++++++++++++++++++++++++++++++
>  1 file changed, 59 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 57faaa9d8013..99e967aff439 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -129,6 +129,54 @@
>  				#reset-cells = <1>;
>  			};
>  
> +			i2c_m0: i2c at 1f000 {

Can you use a more simple "i2c0" phandle naming instead ? or get back to the "i2c_A/B/C/D" naming like in meson_gx to keep consistency ?

[...]

> +			};
> +
> +			i2c_m1: i2c at 1e000 {

[...]

> +			};
> +
> +			i2c_m2: i2c at 1d000 {

[...]

> +			};
> +
> +			i2c_m3: i2c at 1c000 {

[...]

> +			};
> +
>  			uart_A: serial at 24000 {
>  				compatible = "amlogic,meson-gx-uart", "amlogic,meson-uart";
>  				reg = <0x0 0x24000 0x0 0x14>;
> @@ -312,6 +360,17 @@
>  				};
>  			};
>  
> +			i2c_ao: i2c at 5000 {

Can you keep the same "i2c_AO" as in meson-gx ?


[...]

> +			};
> +
>  			uart_AO: serial at 3000 {
>  				compatible = "amlogic,meson-gx-uart", "amlogic,meson-ao-uart";
>  				reg = <0x0 0x3000 0x0 0x18>;
> 

Neil

  reply	other threads:[~2017-11-17 13:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17  8:02 [PATCH 0/5] i2c: meson-axg: add I2C controller driver Yixun Lan
2017-11-17  8:02 ` [PATCH 1/5] dt-bindings: i2c: update documentation for the Meson-AXG Yixun Lan
2017-11-17 13:02   ` Neil Armstrong
2017-11-17 13:47     ` Yixun Lan
2017-11-17  8:02 ` [PATCH 2/5] i2c: meson: add configurable divider factors Yixun Lan
2017-11-17 13:02   ` Neil Armstrong
2017-11-17 20:32   ` Martin Blumenstingl
2017-11-17  8:02 ` [PATCH 3/5] ARM64: dts: meson-axg: add I2C DT info for Meson-AXG SoC Yixun Lan
2017-11-17 13:05   ` Neil Armstrong [this message]
2017-11-17 14:02     ` Yixun Lan
2017-11-17  8:02 ` [PATCH 4/5] ARM64: dts: meson-axg: describe pin DT info for I2C controller Yixun Lan
2017-11-17 13:06   ` Neil Armstrong
2017-11-17  8:02 ` [PATCH 5/5] ARM64: dts: meson-axg: enable I2C Master-1 for the audio speaker Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=96dc68e3-c394-70c4-eabe-f59d4c36150e@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®