mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: afaerber@suse.de (Andreas Färber)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH net-next v3 4/4] ARM64: dts: meson: odroidc2: disable advertisement EEE for GbE.
Date: Mon, 28 Nov 2016 13:31:46 +0100	[thread overview]
Message-ID: <9709dd57-e536-9281-6b56-5ff5f9e8035c@suse.de> (raw)
In-Reply-To: <1480326409-25419-5-git-send-email-jbrunet@baylibre.com>

Am 28.11.2016 um 10:46 schrieb Jerome Brunet:
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> index e6e3491d48a5..5624714d2b16 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> @@ -46,6 +46,7 @@
>  
>  #include "meson-gxbb.dtsi"
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/net/mdio.h>
>  
>  / {
>  	compatible = "hardkernel,odroid-c2", "amlogic,meson-gxbb";
> @@ -98,3 +99,18 @@
>  	pinctrl-0 = <&i2c_a_pins>;
>  	pinctrl-names = "default";
>  };
> +
> +&ethmac {
> +	phy-handle = <&eth_phy0>;
> +
> +	mdio {
> +		compatible = "snps,dwmac-mdio";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		eth_phy0: ethernet-phy at 0 {
> +			reg = <0>;
> +			eee-broken-modes = <MDIO_EEE_1000T>;
> +		};
> +	};
> +};

I've tested this hand-applied because it applies to neither amlogic
v4.10/integ nor linux-next.git and will conflict if applied through the
net-next tree.

Note that there already is an &ethmac node that you should be extending
rather than duplicating:

&ethmac {
	status = "okay";
	pinctrl-0 = <&eth_rgmii_pins>;
	pinctrl-names = "default";
};

If you or your colleagues could please fix the sort order of the nodes
to be alphabetical again (ethmac after i2c_A here; between uart_A and ir
in-tree) this wouldn't happen so easily again.

I therefore suggest to not apply this patch 4/4 through net-next but
through the amlogic tree instead.

Thanks,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)

  reply	other threads:[~2016-11-28 12:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28  9:46 [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Jerome Brunet
2016-11-28  9:46 ` [PATCH net-next v3 1/4] net: phy: add an option to disable EEE advertisement Jerome Brunet
2016-11-28 10:28   ` Yegor Yefremov
2016-11-28 12:20   ` Andreas Färber
2016-11-28  9:46 ` [PATCH net-next v3 2/4] dt-bindings: net: add EEE capability constants Jerome Brunet
2016-11-28 10:28   ` Yegor Yefremov
2016-11-28 12:21   ` Andreas Färber
2016-11-28  9:46 ` [PATCH net-next v3 3/4] dt: bindings: add ethernet phy eee-broken-modes option documentation Jerome Brunet
2016-11-28 12:22   ` Andreas Färber
2016-11-28  9:46 ` [PATCH net-next v3 4/4] ARM64: dts: meson: odroidc2: disable advertisement EEE for GbE Jerome Brunet
2016-11-28 12:31   ` Andreas Färber [this message]
2016-11-28 12:40     ` Jerome Brunet
2016-11-28 13:42 ` [PATCH net-next v3 0/4] Fix OdroidC2 Gigabit Tx link issue Neil Armstrong
2016-11-30  0:38 ` David Miller
2016-11-30  0:43   ` Florian Fainelli
2016-11-30  1:13     ` David Miller
2016-11-30  1:15       ` Florian Fainelli
2016-12-18 13:37         ` Martin Blumenstingl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9709dd57-e536-9281-6b56-5ff5f9e8035c@suse.de \
    --to=afaerber@suse.de \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®