From: Neil Armstrong <narmstrong@baylibre.com>
To: Christian Hewitt <christianshewitt@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kevin Hilman <khilman@baylibre.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: meson: remove CPU opps below 1GHz for G12B/SM1
Date: Thu, 10 Feb 2022 10:34:24 +0100 [thread overview]
Message-ID: <98acfb7c-59bc-e437-899f-4f1eda0fea0b@baylibre.com> (raw)
In-Reply-To: <20220209135535.29547-1-christianshewitt@gmail.com>
On 09/02/2022 14:55, Christian Hewitt wrote:
> Amlogic G12B and SM1 devices experience CPU stalls and random board
> wedges when the system idles and CPU cores clock down to lower opp
> points. Recent vendor kernels include a change to remove 100-250MHz
> (with no explanation) [0] but other downstream sources also remove
> the 500/667MHz points (also with no explanation). Unless 100-667Mhz
> opps are removed or the CPU governor forced to performance, stalls
> are observed, so let's remove them an improve stability/uptime.
>
> [0] https://github.com/khadas/linux/commit/20e237a4fe9f0302370e24950cb1416e038eee03
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
> Numerous people have experienced this issue and I have tested with
> only the low opp-points removed and numerous voltage tweaks: but it
> makes no difference. With the opp points present an Odroid N2 or
> Khadas VIM3 reliably drop off my network after being left idling
> overnight with UART showing a CPU stall splat. With the opp points
> removed I see weeks of uninterupted uptime. It's beyond my skills
> to research what the cause of the stalls might be, but if anyone
> ever figures it out we can always restore things. NB: This issue
> is not too widely reported in forums, but that's largely because
> most of the Amlogic supporting distros have been including this
> change picked from my kernel patchset for some time.
>
> .../boot/dts/amlogic/meson-g12b-a311d.dtsi | 40 -------------------
> .../boot/dts/amlogic/meson-g12b-s922x.dtsi | 40 -------------------
> arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 20 ----------
> 3 files changed, 100 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi
> index d61f43052a34..8e9ad1e51d66 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-a311d.dtsi
> @@ -11,26 +11,6 @@
> compatible = "operating-points-v2";
> opp-shared;
>
> - opp-100000000 {
> - opp-hz = /bits/ 64 <100000000>;
> - opp-microvolt = <731000>;
> - };
> -
> - opp-250000000 {
> - opp-hz = /bits/ 64 <250000000>;
> - opp-microvolt = <731000>;
> - };
> -
> - opp-500000000 {
> - opp-hz = /bits/ 64 <500000000>;
> - opp-microvolt = <731000>;
> - };
> -
> - opp-667000000 {
> - opp-hz = /bits/ 64 <667000000>;
> - opp-microvolt = <731000>;
> - };
> -
> opp-1000000000 {
> opp-hz = /bits/ 64 <1000000000>;
> opp-microvolt = <761000>;
> @@ -71,26 +51,6 @@
> compatible = "operating-points-v2";
> opp-shared;
>
> - opp-100000000 {
> - opp-hz = /bits/ 64 <100000000>;
> - opp-microvolt = <731000>;
> - };
> -
> - opp-250000000 {
> - opp-hz = /bits/ 64 <250000000>;
> - opp-microvolt = <731000>;
> - };
> -
> - opp-500000000 {
> - opp-hz = /bits/ 64 <500000000>;
> - opp-microvolt = <731000>;
> - };
> -
> - opp-667000000 {
> - opp-hz = /bits/ 64 <667000000>;
> - opp-microvolt = <731000>;
> - };
> -
> opp-1000000000 {
> opp-hz = /bits/ 64 <1000000000>;
> opp-microvolt = <731000>;
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> index 1e5d0ee5d541..44c23c984034 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-s922x.dtsi
> @@ -11,26 +11,6 @@
> compatible = "operating-points-v2";
> opp-shared;
>
> - opp-100000000 {
> - opp-hz = /bits/ 64 <100000000>;
> - opp-microvolt = <731000>;
> - };
> -
> - opp-250000000 {
> - opp-hz = /bits/ 64 <250000000>;
> - opp-microvolt = <731000>;
> - };
> -
> - opp-500000000 {
> - opp-hz = /bits/ 64 <500000000>;
> - opp-microvolt = <731000>;
> - };
> -
> - opp-667000000 {
> - opp-hz = /bits/ 64 <667000000>;
> - opp-microvolt = <731000>;
> - };
> -
> opp-1000000000 {
> opp-hz = /bits/ 64 <1000000000>;
> opp-microvolt = <731000>;
> @@ -76,26 +56,6 @@
> compatible = "operating-points-v2";
> opp-shared;
>
> - opp-100000000 {
> - opp-hz = /bits/ 64 <100000000>;
> - opp-microvolt = <751000>;
> - };
> -
> - opp-250000000 {
> - opp-hz = /bits/ 64 <250000000>;
> - opp-microvolt = <751000>;
> - };
> -
> - opp-500000000 {
> - opp-hz = /bits/ 64 <500000000>;
> - opp-microvolt = <751000>;
> - };
> -
> - opp-667000000 {
> - opp-hz = /bits/ 64 <667000000>;
> - opp-microvolt = <751000>;
> - };
> -
> opp-1000000000 {
> opp-hz = /bits/ 64 <1000000000>;
> opp-microvolt = <771000>;
> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
> index 3c07a89bfd27..80737731af3f 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
> @@ -95,26 +95,6 @@
> compatible = "operating-points-v2";
> opp-shared;
>
> - opp-100000000 {
> - opp-hz = /bits/ 64 <100000000>;
> - opp-microvolt = <730000>;
> - };
> -
> - opp-250000000 {
> - opp-hz = /bits/ 64 <250000000>;
> - opp-microvolt = <730000>;
> - };
> -
> - opp-500000000 {
> - opp-hz = /bits/ 64 <500000000>;
> - opp-microvolt = <730000>;
> - };
> -
> - opp-667000000 {
> - opp-hz = /bits/ 64 <666666666>;
> - opp-microvolt = <750000>;
> - };
> -
> opp-1000000000 {
> opp-hz = /bits/ 64 <1000000000>;
> opp-microvolt = <770000>;
Can you find if an acceptable set of Fixes tag can be added to permit backporting to the current LTS kernels ?
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2022-02-10 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 13:55 Christian Hewitt
2022-02-09 20:46 ` Kevin Hilman
2022-02-10 1:31 ` Kevin Hilman
2022-02-10 1:46 ` Christian Hewitt
2022-02-11 20:54 ` Kevin Hilman
2022-02-10 9:34 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98acfb7c-59bc-e437-899f-4f1eda0fea0b@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®