From: Neil Armstrong <neil.armstrong@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>, soc@kernel.org, arm@kernel.org
Cc: linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [GIT PULL] amlogic Drivers updates for v6.2
Date: Wed, 23 Nov 2022 11:51:21 +0100 [thread overview]
Message-ID: <9ae1bae2-67ac-12da-7d4b-16dd73e13d5f@linaro.org> (raw)
In-Reply-To: <4a6b34ef-f5d2-4e56-a7f6-6a7c9cdda416@app.fastmail.com>
On 22/11/2022 22:48, Arnd Bergmann wrote:
> On Tue, Nov 22, 2022, at 16:24, Neil Armstrong wrote:
>>
>> for you to fetch changes up to 7dc69c7d073e6004a281db8f7f15cf6ebf702ea0:
>>
>> firmware: meson_sm: Fix memcpy vs iomem type warnings (2022-10-17
>> 17:19:04 +0200)
>>
>> ----------------------------------------------------------------
>> Amlogic Drivers changes for v6.2:
>> - Fix memcpy vs iomem type warnings in meson_sm driver
>>
>
> It looks like a trivial fix, but I think it's actually wrong:
> The real problem appears to be the use of the ioremap_cache()
> function in meson_sm_map_shmem(), which returns an __iomem
> token that is mapped cacheable on architectures that support
> this function, but behaves like normal ioremap on others.
>
> This is probably not what you want here, instead this should
> be converted to memremap(), with the __iomem annotation dropped.
> In the long run, we should try to kill off ioremap_cache
> entirely, and not introduce new ones.
OK will have a look into that,
Thanks,
Neil
>
> Arnd
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2022-11-23 10:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 15:24 Neil Armstrong
2022-11-22 21:48 ` Arnd Bergmann
2022-11-23 10:51 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ae1bae2-67ac-12da-7d4b-16dd73e13d5f@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®