From: Kelvin Zhang <kelvin.zhang@amlogic.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Junyi Zhao" <junyi.zhao@amlogic.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Kelvin Zhang via B4 Relay
<devnull+kelvin.zhang.amlogic.com@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v8 1/2] pwm: meson: Add support for Amlogic S4 PWM
Date: Tue, 25 Jun 2024 17:33:22 +0800 [thread overview]
Message-ID: <9b457c30-6093-437b-b9af-44c3a768020f@amlogic.com> (raw)
In-Reply-To: <6bzysc3jwugo3epcxsef7uupk536prsc3phlf3m64n3jjwpxus@2uigg44uotuh>
On 2024/6/17 22:11, Uwe Kleine-König wrote:
> Hello,
>
> On Mon, Jun 17, 2024 at 04:44:13PM +0800, Junyi Zhao wrote:
>>>> So yes, please use dev_err_probe() also to handle
>>>> devm_add_action_or_reset().
>>> My point here is also that devm_add_action_or_reset() can only fail on
>>> memory allocation, like (devm_)kzalloc. Looking around the kernel, we
>>> tend to not add messages for that and just return the error code,
>>> presumably because those same 'out of memory' messages would proliferate
>>> everywhere.
>> Hi Uwe, I didnt get the clear point.
>> So, if we need "return ret" directly? or keep "dev_err_probe()" to print?
> Please keep the dev_err_probe(). There is a problem with that approach
> (as Jerome pointed out), but that is about to be addressed in driver
> core code.
>
Hi Uwe,
For this patchset, is there anything that needs improvement?
Thanks!
> Best regards
> Uwe
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2024-06-25 9:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 11:46 [PATCH v8 0/2] " Kelvin Zhang via B4 Relay
2024-06-13 11:46 ` [PATCH v8 1/2] pwm: meson: " Kelvin Zhang via B4 Relay
2024-06-13 15:03 ` [DMARC error][DKIM error] " George Stark
2024-06-13 15:54 ` Jerome Brunet
2024-06-13 20:46 ` Uwe Kleine-König
2024-06-14 7:24 ` Jerome Brunet
2024-06-14 9:02 ` Uwe Kleine-König
2024-06-17 8:44 ` Junyi Zhao
2024-06-17 14:11 ` Uwe Kleine-König
2024-06-25 9:33 ` Kelvin Zhang [this message]
2024-06-25 14:50 ` Uwe Kleine-König
2024-06-27 8:16 ` Uwe Kleine-König
2024-06-13 11:46 ` [PATCH v8 2/2] arm64: dts: amlogic: Add " Kelvin Zhang via B4 Relay
2024-06-27 5:50 ` Uwe Kleine-König
2024-06-27 6:38 ` Kelvin Zhang
2024-06-27 7:52 ` Neil Armstrong
2024-06-27 7:56 ` (subset) [PATCH v8 0/2] Add support for " Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b457c30-6093-437b-b9af-44c3a768020f@amlogic.com \
--to=kelvin.zhang@amlogic.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=devnull+kelvin.zhang.amlogic.com@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=junyi.zhao@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®