From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH] drm/meson: venc: dmt mode must use encp
Date: Tue, 13 Nov 2018 09:35:04 +0100 [thread overview]
Message-ID: <9f20e9d1-2e15-c087-db52-674300d7581d@baylibre.com> (raw)
In-Reply-To: <1542048069-22603-1-git-send-email-jramirez@baylibre.com>
On 12/11/2018 19:41, Jorge Ramirez-Ortiz wrote:
> From: Jorge Ramirez-Ortiz <jorge.ramirez.ortiz@gmail.com>
>
> The video mode for DMT is only populated to support encp.
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez.ortiz@gmail.com>
> ---
> drivers/gpu/drm/meson/meson_venc.c | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> index 514245e..acbbad3 100644
> --- a/drivers/gpu/drm/meson/meson_venc.c
> +++ b/drivers/gpu/drm/meson/meson_venc.c
> @@ -854,6 +854,13 @@ void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic,
> unsigned int sof_lines;
> unsigned int vsync_lines;
>
> + /* Use VENCI for 480i and 576i and double HDMI pixels */
> + if (mode->flags & DRM_MODE_FLAG_DBLCLK) {
> + hdmi_repeat = true;
> + use_enci = true;
> + venc_hdmi_latency = 1;
> + }
> +
> if (meson_venc_hdmi_supported_vic(vic)) {
> vmode = meson_venc_hdmi_get_vic_vmode(vic);
> if (!vmode) {
> @@ -865,13 +872,7 @@ void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic,
> } else {
> meson_venc_hdmi_get_dmt_vmode(mode, &vmode_dmt);
> vmode = &vmode_dmt;
> - }
> -
> - /* Use VENCI for 480i and 576i and double HDMI pixels */
> - if (mode->flags & DRM_MODE_FLAG_DBLCLK) {
> - hdmi_repeat = true;
> - use_enci = true;
> - venc_hdmi_latency = 1;
> + use_enci = false;
> }
>
> /* Repeat VENC pixels for 480/576i/p, 720p50/60 and 1080p50/60 */
>
Thanks !
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
I'll apply to drm-misc-fixes !
Neil
next prev parent reply other threads:[~2018-11-13 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 18:41 Jorge Ramirez-Ortiz
2018-11-13 8:35 ` Neil Armstrong [this message]
2018-11-13 13:32 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f20e9d1-2e15-c087-db52-674300d7581d@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®