From mboxrd@z Thu Jan 1 00:00:00 1970 From: martin.blumenstingl@googlemail.com (Martin Blumenstingl) Date: Fri, 13 Oct 2017 20:58:59 +0200 Subject: [PATCH 1/2] mmc: meson-mx-sdio: return correct error code In-Reply-To: <20171013111943.zyp5myiwb3pp56vh@mwanda> References: <20171013111943.zyp5myiwb3pp56vh@mwanda> Message-ID: To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Fri, Oct 13, 2017 at 1:19 PM, Dan Carpenter wrote: > This has a copy and paste bug so we use "host->fixed_factor_clk" which > is a valid pointer instead of "host->cfg_div_clk" which holds the error > code. > > Fixes: 0aa0fb9cd239 ("mmc: meson-mx-sdio: Add a driver for the Amlogic Meson8 and Meson8b SoCs") > Signed-off-by: Dan Carpenter Acked-by: Martin Blumenstingl thank you for spotting and fixing this! > > diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c > index 19b499bbe691..dc30ed5e964b 100644 > --- a/drivers/mmc/host/meson-mx-sdio.c > +++ b/drivers/mmc/host/meson-mx-sdio.c > @@ -621,7 +621,7 @@ static int meson_mx_mmc_register_clks(struct meson_mx_mmc_host *host) > host->cfg_div_clk = devm_clk_register(host->controller_dev, > &host->cfg_div.hw); > if (WARN_ON(PTR_ERR_OR_ZERO(host->cfg_div_clk))) > - return PTR_ERR(host->fixed_factor_clk); > + return PTR_ERR(host->cfg_div_clk); > > return 0; > } > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-amlogic