From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Karl Chan <exkcmailist@inbox.lv>
Cc: linux-amlogic@lists.infradead.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, neil.armstrong@linaro.org,
khilman@baylibre.com, jbrunet@baylibre.com,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Karl Chan <exxxxkc@getgoogleoff.me>
Subject: Re: [PATCH v3 2/2] arm64: dts: meson-gxl: add support for Xiaomi Mibox 3
Date: Tue, 11 Apr 2023 21:30:18 +0200 [thread overview]
Message-ID: <CAFBinCCXYnChN8MfOxGEDSTm4HftpzuwwHwtqm7b1dPH6EdUsQ@mail.gmail.com> (raw)
In-Reply-To: <20230410193048.31084-3-exkcmailist@inbox.lv>
Hello Karl,
On Mon, Apr 10, 2023 at 9:31 PM Karl Chan <exkcmailist@inbox.lv> wrote:
>
> From: "Karl Chan" <exkcmailist@inbox.lv>
>
> The Xiaomi Mibox 3 is a TV box based on the Amlogic S905X chipset.
I found various websites referring to this device as "Mi Box 3" (so
space between Mi and Box).
Do you know the official name that Xiaomi used?
> There are two variants:
> - 2 GiB/8GIB
> - 1 GiB/4GIB
>
> Both variants come with:
> - 802.11a/b/g/n/ac wifi (BCM4345)
> - HDMI , AV (CVBS) and S/PDIF optical output
nit-pick: no space before the comma
> - 1x USB (utilizing both USB ports provided by the SoC)
Can you please explain this in a bit more detail?
My understanding is that this board has one USB 2.0 type A port. What
do you mean by "utilizing both USB ports"?
Also I'm curious: does the board come with eMMC or (raw/parallel) NAND
flash? P212 typically means eMMC.
[...]
> +/* This UART is brought out to the uart pad on the pcb*/
nit-pick: missing space after "pcb"
Are the UART pads obvious on the board (for example since they are
labelled)? If not: maybe add a hint where to find it
[...]
> +&usb {
> + status = "okay";
> + dr_mode = "host";
> +};
This is already inherited from meson-gxl-s905x-p212.dtsi so removing
it should result in the same .dtb
Best regards,
Martin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2023-04-11 19:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 19:30 [PATCH v3 0/2] " Karl Chan
2023-04-10 19:30 ` [PATCH v3 1/2] dt-bindings: arm: amlogic: add Xiaomi Mibox 3 binding Karl Chan
2023-04-11 5:49 ` Krzysztof Kozlowski
2023-04-10 19:30 ` [PATCH v3 2/2] arm64: dts: meson-gxl: add support for Xiaomi Mibox 3 Karl Chan
2023-04-11 19:30 ` Martin Blumenstingl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCCXYnChN8MfOxGEDSTm4HftpzuwwHwtqm7b1dPH6EdUsQ@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=exkcmailist@inbox.lv \
--cc=exxxxkc@getgoogleoff.me \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®