mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Anand Moon <linux.amoon@gmail.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	 Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	 Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	 "moderated list:ARM/Amlogic Meson SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	 "open list:ARM/Amlogic Meson SoC support"
	<linux-amlogic@lists.infradead.org>,
	 open list <linux-kernel@vger.kernel.org>
Cc: Wayne Schroeder <raz@chewies.net>
Subject: Re: [PATCH v2] arm64: dts: amlogic: Update USB hub power and reset properties
Date: Wed, 21 May 2025 17:12:54 +0530	[thread overview]
Message-ID: <CANAwSgTk3R6SMqsNcT7c2AVzQRAdk8Z2Rs0bK3VCsgivR6nLmA@mail.gmail.com> (raw)
In-Reply-To: <20250521074535.16488-1-linux.amoon@gmail.com>

Hi Neil,

On Wed, 21 May 2025 at 13:15, Anand Moon <linux.amoon@gmail.com> wrote:
>
> Add missing reset-gpios property to the USB 2.0 hub node to
> ensure proper reset handling. Also update the vdd-supply for
> both USB 2.0 and 3.0 hubs to use the shared hub_5v regulator
> for consistent power management. Remove usb2_phy1 phy-supply
> since now it's managed by the hub reset control.
>
> Fixes: ccff36934137 ("arm64: dts: amlogic: Used onboard usb hub reset on odroid n2")
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> v2: remove usb2_phy1 phy-supply since now it's managed by
> the hub reset control.
> ---
>  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> index 3bca8023638d..d46b6aaef8fa 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dtsi
> @@ -42,7 +42,8 @@ hub_2_0: hub@1 {
>                         compatible = "usb5e3,610";
>                         reg = <1>;
>                         peer-hub = <&hub_3_0>;
> -                       vdd-supply = <&usb_pwr_en>;
> +                       reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
> +                       vdd-supply = <&hub_5v>;
>                 };
>
>                 /* 3.0 hub on port 4 */
> @@ -51,7 +52,7 @@ hub_3_0: hub@2 {
>                         reg = <2>;
>                         peer-hub = <&hub_2_0>;
>                         reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
> -                       vdd-supply = <&vcc_5v>;
> +                       vdd-supply = <&hub_5v>;
>                 };
>         };
>
> @@ -311,8 +312,3 @@ &toacodec {
>  &usb {
>         vbus-supply = <&usb_pwr_en>;
>  };
> -
> -&usb2_phy1 {
> -       /* Enable the hub which is connected to this port */
> -       phy-supply = <&hub_5v>;
> -};

This is breaking the bring-up of dwc2 in u-boot
so could you consider V1 of the patch?

Thanks
-Anand
>
> base-commit: 4a95bc121ccdaee04c4d72f84dbfa6b880a514b6
> --
> 2.49.0
>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

      reply	other threads:[~2025-05-21 11:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-21  7:45 Anand Moon
2025-05-21 11:42 ` Anand Moon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANAwSgTk3R6SMqsNcT7c2AVzQRAdk8Z2Rs0bK3VCsgivR6nLmA@mail.gmail.com \
    --to=linux.amoon@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=raz@chewies.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®