From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FD9ACFD313 for ; Mon, 24 Nov 2025 16:03:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:To:Cc:Subject: From:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9zLq6dQbV1L+Ltm1nXI6JpO8IB5GTf/ZqNjILRpKm/w=; b=kCXDsxOGhgQN5c +Ht5IKtVpS4tnuSQOFIP8lgeRA2t8OmPWiHTczlpVHgBCyiMo/P7ltDUHi0KPnrUATBXODVq//nRm +0AnsIdVN4Nvc200UbdiDhzboaPrwmRZo16L3T9PpJX8QHRJTW246pWoqgyqbjf+MSN8YDb4wOpxd JpilGZRN6z0BqPQ6WpS2DGr0yP3ItpAZXsD+cxu1Hb7A48ziUlM2zoVNhrzZJbMGwhoMuTAXcf6El gHHQsaFOaB7uKW5Qf463BDxuCcw0uQa03Pe3PMxGnACzM/Kwc5QO95QEiEI3vUS2M9tuIEdftKu6K dNpH5xtoYwEfhF/ck+vQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNZ2A-0000000BxqQ-34no; Mon, 24 Nov 2025 16:03:23 +0000 Received: from smtpout-02.galae.net ([185.246.84.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vNZ26-0000000BxpC-25qs for linux-amlogic@lists.infradead.org; Mon, 24 Nov 2025 16:03:20 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 635361A1D26; Mon, 24 Nov 2025 16:03:15 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 2CA36606FC; Mon, 24 Nov 2025 16:03:15 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B4CDF10371A40; Mon, 24 Nov 2025 17:03:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1764000193; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=p+QBWKtawqpPzZu9LPDyPm5gsgmOzV7hJRZ5Ebshggc=; b=cc20tvebhyskRFsehgbMDtN58mFWJzw3+meTYMQYXrWdpw5VV3uKvGIpPD9HS8R83EmRZH qALe8e5UUI6C7MJXNERyWBLmNk5WfzKKvn8Wss/BPa1OVvmct7arm5zW27QDKgInGVcz6k oi6j2QLmL3GbqobdqI1pyE5V0TLsDjFvq2MBjZC1AlbLsk1PMdr+v727PXLGHuuUayjymh vV+Lgfi2eIyHigvvg8KiU75iRe8JFjVl6qwYhTFrQuO5g/Z240s/dFBsN/mdGefIWxxz3z LHntkwUmsv/8hiteqTu/SKAu006LhE9TFbOO34cMGYjkq2/kVuVeteyUjoVDQw== Mime-Version: 1.0 Date: Mon, 24 Nov 2025 17:03:00 +0100 Message-Id: From: "Luca Ceresoli" Subject: Re: [PATCH 01/26] drm/bridge: add drm_of_find_bridge() Cc: "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Jonathan Corbet" , "Alexey Brodkin" , "Phong LE" , "Liu Ying" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Adrien Grassein" , "Laurent Pinchart" , "Tomi Valkeinen" , "Kieran Bingham" , "Geert Uytterhoeven" , "Magnus Damm" , "Kevin Hilman" , "Jerome Brunet" , "Martin Blumenstingl" , "Chun-Kuang Hu" , "Philipp Zabel" , "Matthias Brugger" , "AngeloGioacchino Del Regno" , "Anitha Chrisanthus" , "Edmund Dea" , "Inki Dae" , "Seung-Woo Kim" , "Kyungmin Park" , "Krzysztof Kozlowski" , "Alim Akhtar" , "Hui Pu" , "Thomas Petazzoni" , , , , , , , , , To: "Maxime Ripard" X-Mailer: aerc 0.20.1 References: <20251119-drm-bridge-alloc-getput-drm_of_find_bridge-v1-0-0db98a7fe474@bootlin.com> <20251119-drm-bridge-alloc-getput-drm_of_find_bridge-v1-1-0db98a7fe474@bootlin.com> In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251124_080318_671142_BAB5B173 X-CRM114-Status: GOOD ( 13.25 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hello Maxime, On Mon Nov 24, 2025 at 11:15 AM CET, Maxime Ripard wrote: > Hi, > > On Wed, Nov 19, 2025 at 02:05:32PM +0100, Luca Ceresoli wrote: >> #ifdef CONFIG_OF >> +/** >> + * drm_of_find_bridge - find the bridge corresponding to the device node in >> + * the global bridge list >> + * @np: device node >> + * >> + * The refcount of the returned bridge is incremented. Use drm_bridge_put() >> + * when done with it. >> + * >> + * RETURNS: >> + * drm_bridge control struct on success, NULL on failure >> + */ >> +struct drm_bridge *drm_of_find_bridge(struct device_node *np) > > So the convention we've mostly had was that the first argument would > define the prefix, ie. if we pass a drm_* pointer, the prefix is drm, if > we pass a device_node pointer, then the prefix is of. > > Considering that convention, of_drm_find_bridge would be the ideal > candidate, but we can't use that obviously. What about > of_drm_find_and_get_bridge, or of_drm_get_bridge? Ah, it sounded the other way around during the old discussion [0]. :-) But no problem in using a different name of course. of_drm_get_bridge() looks like the best to me, so I'll rename that way in v2. [0] https://lore.kernel.org/dri-devel/20250319-stylish-lime-mongoose-0a18ad@houat/ Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic