From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: <sashiko-reviews@lists.linux.dev>,
"Ethan Tidmore" <ethantidmore06@gmail.com>
Cc: <neil.armstrong@linaro.org>, <linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH] ASoC: meson: aiu: Fix resource leak
Date: Mon, 06 Jul 2026 20:41:38 -0500 [thread overview]
Message-ID: <DJRYGM1TBAY8.39KCXCXTQC5Z7@gmail.com> (raw)
In-Reply-To: <20260707013437.27DA61F000E9@smtp.kernel.org>
On Mon Jul 6, 2026 at 8:34 PM CDT, sashiko-bot wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The patch modifies the error path to purportedly free the `aiu-formatter` resource by jumping to the `err` label, referencing commit 83b83024cdbfd. However, the `aiu-formatter` allocation and cleanup code (specifically `gx_formatter_create` and `gx_formatter_free`) does not exist in the codebase at this revision. The patch is a "ghost fix" attempting to resolve a resource leak for a feature that is missing in this tree.
> --
This bug exists in linux-next. The AI is using the mainline.
--
Thanks,
ET
https://github.com/sponsors/ethantidmore
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-07-07 1:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 1:24 Ethan Tidmore
2026-07-07 1:34 ` sashiko-bot
2026-07-07 1:41 ` Ethan Tidmore [this message]
2026-07-07 20:33 ` Valerio Setti
2026-07-10 11:27 ` Markus Elfring
2026-07-10 12:47 ` Valerio Setti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJRYGM1TBAY8.39KCXCXTQC5Z7@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox