From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B456BC433EF for ; Wed, 20 Apr 2022 09:13:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8+0DD3R+42fqzr/u/p3asoWZLSZKWMOd2UYTAOmcY6M=; b=bsg+JInGm/5GmE LE9oCSFFyanni3HhtKaOvmg12nvaR6/usnlLz2T3nKPpO3duEF10YmVaTVeN4VTQ39u6FMwD11Tk+ Gu0gqFygcqhT63mSFqLSvgS7wyBoNgcT6m+cY8Jnp4c383NzEo76BWR/sa02f8jGeQI3XoMHE0vHD Jjtp3nMYcxy0kRkaj8TcjvEFtIaDk3fape8xh2Elmu4ZcZx1xeubKx5pHWnRmY0sj8fgSqb9E8Cua Y5E20sm+OzGXy8Znbn9WMtTcRt1agyPPUqeg2WbxWpEjIxmPgzPyQhnoSVizchAdNDl9U+84tVL6o rC9Gub2at00tH+rwZ02A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh6Of-008FuJ-1s; Wed, 20 Apr 2022 09:13:13 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh6Oc-008FsT-4X; Wed, 20 Apr 2022 09:13:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 758BBB81D01; Wed, 20 Apr 2022 09:13:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3F5DC385A0; Wed, 20 Apr 2022 09:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650445987; bh=KDKHfjJ60ROxsjebYEm1b6mZhzJhCIIDKLlG34vY1xA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XMm+ng/+JZbmFE/tHjl+BF1lzEkmc54zPNeeuf8f3QeZ0oWBqMWDoUbkx+Ojc+eJE syt3gfzs455M44by3WwxZZZTpTOvzF8LhcuyHHJ3/szsD7mbTh5v0K3vaa7ksjWlD3 fZ88cDkQPr77WcpduzlqrYDJs4aYGYzD8Cagi6yVGQd09EvtRe/WY1kvHXPVlkkW7I 0WimFs1uVoz5Cn7+rlY8tBa0hvSozc4Oja6ryaWOQAIBki/wSEn7iB7qZaMF/u0IWA 1kLm8j0Q1qIYigy04oG6rie8rmkzi30V6mOAMYwwnM+q3gNSq9t1bZnXr6xNE6+qcY GBmFR4Txhtnkg== Date: Wed, 20 Apr 2022 14:43:03 +0530 From: Vinod Koul To: Heiner Kallweit Cc: Kishon Vijay Abraham I , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, "open list:ARM/Amlogic Meson..." Subject: Re: [PATCH] phy: amlogic: fix error path in phy_g12a_usb3_pcie_probe() Message-ID: References: <8e416f95-1084-ee28-860e-7884f7fa2e32@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8e416f95-1084-ee28-860e-7884f7fa2e32@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_021310_357422_16B5FAE2 X-CRM114-Status: UNSURE ( 8.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 15-04-22, 16:03, Heiner Kallweit wrote: > If clk_prepare_enable() fails we call clk_disable_unprepare() > in the error path what results in a warning that the clock > is disabled and unprepared already. > And if we fail later in phy_g12a_usb3_pcie_probe() then we > bail out w/o calling clk_disable_unprepare(). > This patch fixes both errors. Applied, thanks -- ~Vinod _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic