From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F1BEC43334 for ; Tue, 26 Jul 2022 07:52:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pY3LXPHFHYqV2URgy1NbF91/NcI7FS9yuAbZUAWfLD4=; b=u/zylDXghtKo3t 4vSTWyVcplL6oPryNKwNo0vX5vIvFIfgtNftELY51B/6X7y0fZT3uXC6VyhhEltTQRamArj9uC0qY /8zgvw7X+VMh6/qu3hPPNr7sOE91ketrjIMUcBVsSYoIELoj3XDt5pwjsm7njQVYEENwnnvLJwG2T FKG4Btzdwj1CoejvUQ9EqC4NiWV1wGg8n+E3K+gKgAhxfxTCfDoh0dA0CFE6TlxRfb987VCIqfvDS mD45fr61SYxW8BLO/tWLadKT5FjRVIYdoyCT55wxmHA1Z8UVyXH9qwu0SG6UnAeC5hagWPEJYFf4U Hv6CuTqwbaNtCG3ZnZpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGFMq-009fqK-Hx; Tue, 26 Jul 2022 07:52:36 +0000 Received: from gofer.mess.org ([2a02:8011:d000:212::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oGFDU-009ZIu-VI for linux-amlogic@lists.infradead.org; Tue, 26 Jul 2022 07:42:58 +0000 Received: by gofer.mess.org (Postfix, from userid 1000) id E6AB9100063; Tue, 26 Jul 2022 08:42:48 +0100 (BST) Date: Tue, 26 Jul 2022 08:42:48 +0100 From: Sean Young To: Zhang Ning Cc: martin.blumenstingl@googlemail.com, narmstrong@baylibre.com, linux-amlogic@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [v5 2/4] media: rc: add keymap for MagicBox M16S remote Message-ID: References: <20220724231704.132472-1-zhangn1985@qq.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220726_004257_224960_25F15318 X-CRM114-Status: GOOD ( 20.86 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon, Jul 25, 2022 at 07:17:02AM +0800, Zhang Ning wrote: > MagicBox M16S Tv box shipped with a simple NEC remote. > it has a key labeled "M", used as Magic key in vendor OS. > This has mapped to KEY_MUTE. Please put this commit in the source code next to the key definition. This doesn't belong in the commit message. Thanks Sean > > Signed-off-by: Zhang Ning > --- > drivers/media/rc/keymaps/Makefile | 1 + > drivers/media/rc/keymaps/rc-magicbox.c | 53 ++++++++++++++++++++++++++ > include/media/rc-map.h | 1 + > 3 files changed, 55 insertions(+) > create mode 100644 drivers/media/rc/keymaps/rc-magicbox.c > > diff --git a/drivers/media/rc/keymaps/Makefile b/drivers/media/rc/keymaps/Makefile > index f513ff5caf4e..02c1c2150f03 100644 > --- a/drivers/media/rc/keymaps/Makefile > +++ b/drivers/media/rc/keymaps/Makefile > @@ -71,6 +71,7 @@ obj-$(CONFIG_RC_MAP) += \ > rc-kworld-plus-tv-analog.o \ > rc-leadtek-y04g0051.o \ > rc-lme2510.o \ > + rc-magicbox.o \ > rc-manli.o \ > rc-mecool-kiii-pro.o \ > rc-mecool-kii-pro.o \ > diff --git a/drivers/media/rc/keymaps/rc-magicbox.c b/drivers/media/rc/keymaps/rc-magicbox.c > new file mode 100644 > index 000000000000..b4fc1856a9e7 > --- /dev/null > +++ b/drivers/media/rc/keymaps/rc-magicbox.c > @@ -0,0 +1,53 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +// > +// Copyright (C) 2022 Zhang Ning > + > +/* > + * Keytable for the MagicBox M16S remote control > + */ > + > +#include > +#include > + > +static struct rc_map_table magicbox[] = { > + { 0x9f57, KEY_POWER }, > + { 0x9f8a, KEY_MUTE }, // M > + > + { 0x9f43, KEY_UP }, > + { 0x9f0a, KEY_DOWN }, > + { 0x9f06, KEY_LEFT }, > + { 0x9f0e, KEY_RIGHT }, > + { 0x9f02, KEY_OK }, > + > + { 0x9f47, KEY_HOME }, > + { 0x9f4f, KEY_BACK }, > + { 0x9f16, KEY_MENU }, > + > + { 0x9fff, KEY_VOLUMEDOWN }, > + { 0x9f5d, KEY_VOLUMEUP }, > +}; > + > +static struct rc_map_list magicbox_map = { > + .map = { > + .scan = magicbox, > + .size = ARRAY_SIZE(magicbox), > + .rc_proto = RC_PROTO_NEC, > + .name = RC_MAP_MAGICBOX, > + } > +}; > + > +static int __init init_rc_map_magicbox(void) > +{ > + return rc_map_register(&magicbox_map); > +} > + > +static void __exit exit_rc_map_magicbox(void) > +{ > + rc_map_unregister(&magicbox_map); > +} > + > +module_init(init_rc_map_magicbox) > +module_exit(exit_rc_map_magicbox) > + > +MODULE_LICENSE("GPL"); > +MODULE_AUTHOR("Zhang Ning "); > diff --git a/include/media/rc-map.h b/include/media/rc-map.h > index 793b54342dff..656217b8e91b 100644 > --- a/include/media/rc-map.h > +++ b/include/media/rc-map.h > @@ -277,6 +277,7 @@ struct rc_map *rc_map_get(const char *name); > #define RC_MAP_KWORLD_PLUS_TV_ANALOG "rc-kworld-plus-tv-analog" > #define RC_MAP_LEADTEK_Y04G0051 "rc-leadtek-y04g0051" > #define RC_MAP_LME2510 "rc-lme2510" > +#define RC_MAP_MAGICBOX "rc-magicbox" > #define RC_MAP_MANLI "rc-manli" > #define RC_MAP_MECOOL_KII_PRO "rc-mecool-kii-pro" > #define RC_MAP_MECOOL_KIII_PRO "rc-mecool-kiii-pro" > -- > 2.35.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic