From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D2DFEB64D9 for ; Mon, 10 Jul 2023 11:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W27ve2KdAqS2paNQlE6PQ0NXSnPUJX/micNwYFB1x7Q=; b=HSyzV/i+QzNhrX 5+GPOYsehpVvJ+srfjCrdMsJoo7o5ddrnYmQsWaKxFbEKJLjK42YXe0f5i7RhKnccIQzoRVtq2iyS xW+7MfDnEn5FgAmvtdCqPS5+w1TQiInH/SSD5UoIbtpcj4iANe4Q6JIvk5JuttO9fwfsjY0mx9r0z sjpfaof0FZn4rrIGDy9k68UnQVSbuGnBrrRUPT3ZMb4b5X1/FRBEvOSyTrIhT+l++0UO05o9uLoQX Yue8IyrkP17iWJ3+y6SJiRS+vNMEewX7+VtbcErslbpSJjvxHommNhpRQQWt+v9DEHXDu71hMU/Jf Xk6ow/9FmFqXxk6YT70w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIonP-00BRhK-04; Mon, 10 Jul 2023 11:11:11 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qIonM-00BRg4-1x; Mon, 10 Jul 2023 11:11:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688987468; x=1720523468; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=anBTsvynQ8qUvIELsfh79T1xhkkDcClo5RxqNLeYaSA=; b=OpHtfqppgoBAGWxc1LvBp1vDV64JBJwK2C0LvK9yhmgniySBNx3/r0DO JhnBPHpMZ7itNXxsfR1njNQM3kb5FoZWcsUaKBVSb4kT9g/QSdJQ4qyrv RNmWyAJKjW2CHjixcHYJbDJjNQkMrhL6h8c4nWySXVwLvEJVDcg6Y0sJh vYV1F/YcmT8BHUyd3ZzahJ4foA6XlGoT4AQWSRD/GtK//FPMgFRHspb32 X//OaoxyarSvsCHhwGTUAjo5XHG6W5wrMzmJKTbXBsS0EHaAFy6wL2OIj 5EVy5ED82E7pHhVbJW/s1HBSg3PikSwsGmAWMwNF2twt6bNkFq/BAa+Fv Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="343908961" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="343908961" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2023 04:11:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="720664309" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="720664309" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 10 Jul 2023 04:10:56 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qIon7-001XKM-1M; Mon, 10 Jul 2023 14:10:53 +0300 Date: Mon, 10 Jul 2023 14:10:53 +0300 From: Andy Shevchenko To: Mark Brown Cc: Yang Yingliang , Amit Kumar Mahapatra via Alsa-devel , Kris Bahnsen , Neil Armstrong , Tharun Kumar P , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, Radu Pirea , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Tudor Ambarus , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Max Filippov , Richard Cochran Subject: Re: [PATCH v1 4/8] spi: Get rid of old SPI_MASTER_NO_.X and SPI_MASTER_MUST_.X Message-ID: References: <20230710102751.83314-1-andriy.shevchenko@linux.intel.com> <20230710102751.83314-5-andriy.shevchenko@linux.intel.com> <1ffd5603-4140-4bf6-bfed-af70a6759bda@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_041108_663643_D794C303 X-CRM114-Status: GOOD ( 14.80 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Mon, Jul 10, 2023 at 02:08:00PM +0300, Andy Shevchenko wrote: > On Mon, Jul 10, 2023 at 12:04:35PM +0100, Mark Brown wrote: > > On Mon, Jul 10, 2023 at 01:27:47PM +0300, Andy Shevchenko wrote: > > > > > Convert the users to SPI_CONTROLLER_NO_?X and SPI_CONTROLLER_MUST_.X > > > and kill the not used anymore definitions. > > > > The above is not what this change does: > > How to improve it? I was sure that the form of "converting to something and > something" is clear... A wild guess, maybe you meant to split to two changes, one per each macro group? > > > - controller->flags = SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX; > > > + controller->flags = SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX; -- With Best Regards, Andy Shevchenko _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic