mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Alexey Romanov <avromanov@salutedevices.com>
Cc: neil.armstrong@linaro.org, clabbe@baylibre.com,
	davem@davemloft.net, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	khilman@baylibre.com, jbrunet@baylibre.com,
	martin.blumenstingl@googlemail.com, vadim.fedorenko@linux.dev,
	linux-crypto@vger.kernel.org, linux-amlogic@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, kernel@salutedevices.com
Subject: Re: [PATCH v6 10/23] drivers: crypto: meson: avoid kzalloc in engine thread
Date: Fri, 5 Apr 2024 14:55:48 +0800	[thread overview]
Message-ID: <Zg+gdDZQG1GeKwGn@gondor.apana.org.au> (raw)
In-Reply-To: <20240326153219.2915080-11-avromanov@salutedevices.com>

On Tue, Mar 26, 2024 at 06:32:06PM +0300, Alexey Romanov wrote:
>
>  /*
>   * struct meson_cipher_tfm_ctx - context for a skcipher TFM
> - * @key:		pointer to key data
> + * @keyiv:		key data
>   * @keylen:		len of the key
>   * @keymode:		The keymode(type and size of key) associated with this TFM
>   * @mc:			pointer to the private data of driver handling this TFM
>   * @fallback_tfm:	pointer to the fallback TFM
>   */
>  struct meson_cipher_tfm_ctx {
> -	u32 *key;
> -	u32 keylen;
> +	u8 keyiv[AES_MAX_KEY_SIZE + AES_BLOCK_SIZE] ____cacheline_aligned;
> +	u32 keylen ____cacheline_aligned;

This doesn't do anything to guarantee that tfm_ctx is aligned.

You either need to align this by hand, or you could use the
crypto_skcipher_ctx_dma helper if DMA alignment is what you're
actually looking for.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2024-04-05  6:56 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 15:31 [PATCH v6 00/23] Support more Amlogic SoC families in crypto driver Alexey Romanov
2024-03-26 15:31 ` [PATCH v6 01/23] drivers: crypto: meson: don't hardcode IRQ count Alexey Romanov
2024-03-26 15:31 ` [PATCH v6 02/23] drviers: crypto: meson: add platform data Alexey Romanov
2024-03-26 15:31 ` [PATCH v6 03/23] drivers: crypto: meson: remove clock input Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 04/23] drivers: crypto: meson: add MMIO helpers Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 05/23] drivers: crypto: meson: move get_engine_number() Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 06/23] drivers: crypto: meson: drop status field from meson_flow Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 07/23] drivers: crypto: meson: move algs definition and cipher API to cipher.c Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 08/23] drivers: crypto: meson: cleanup defines Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 09/23] drivers: crypto: meson: process more than MAXDESCS descriptors Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 10/23] drivers: crypto: meson: avoid kzalloc in engine thread Alexey Romanov
2024-04-05  6:55   ` Herbert Xu [this message]
2024-03-26 15:32 ` [PATCH v6 11/23] drivers: crypto: meson: introduce hasher Alexey Romanov
2024-04-05  6:56   ` Herbert Xu
2024-04-10 10:39     ` Alexey Romanov
2024-04-11  7:39       ` Herbert Xu
2024-03-26 15:32 ` [PATCH v6 12/23] drivers: crypto: meson: add support for AES-CTR Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 13/23] drivers: crypto: meson: use fallback for 192-bit keys Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 14/23] drivers: crypto: meson: add support for G12-series Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 15/23] drivers: crypto: meson: add support for AXG-series Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 16/23] drivers: crypto: meson: add support for A1-series Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 17/23] dt-bindings: crypto: meson: remove clk and second interrupt line for GXL Alexey Romanov
2024-03-26 18:09   ` Conor Dooley
2024-03-29 11:14     ` Alexey Romanov
2024-03-29 11:55       ` Conor Dooley
2024-03-26 15:32 ` [PATCH v6 18/23] arch: arm64: dts: meson: gxl: correct crypto node definition Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 19/23] dt-bindings: crypto: meson: support new SoC's Alexey Romanov
2024-03-26 18:04   ` Conor Dooley
2024-03-29 11:16     ` Alexey Romanov
2024-03-29 11:58       ` Conor Dooley
2024-03-26 15:32 ` [PATCH v6 20/23] arch: arm64: dts: meson: a1: add crypto node Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 21/23] arch: arm64: dts: meson: s4: " Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 22/23] arch: arm64: dts: meson: g12: " Alexey Romanov
2024-03-26 15:32 ` [PATCH v6 23/23] arch: arm64: dts: meson: axg: " Alexey Romanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zg+gdDZQG1GeKwGn@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=avromanov@salutedevices.com \
    --cc=clabbe@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet@baylibre.com \
    --cc=kernel@salutedevices.com \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®