From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B396ECF34A3 for ; Thu, 3 Oct 2024 12:39:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/DNjK0YMWOIFGBPpVLOt4pGUWrD0+pKTcw/0FZ82boo=; b=LOaSxFgWKMXsrS ZWA7Bjv0TNPKEQFM1Rl3WXdGfnymVvFpcq/yElkby5/lSFOXsVVhmq+WeM4BgoV2W1wcnyadXHYRf eg+MJc+4SperlgXW5+0sx6b5fCRKExNJ5r+MGNb5RySFLszXWa/x8MgBpmvq0sl4WkBRrOPGOgEeI PAkY6JqNViua+V100R6NTt7UFFrKFiNxPOefTEUYveN11ljJ95KBqjdaBgRhQLCYj7ZZpyyTWlEXi z+vydcjz8bqXZdMr317FAk/eWeQhcwmDnp/aFciPSlq01UFGEe3aDcG9wWN0HSxkTiws1XjKrNkPW kDTbzv5XqnOz0wJ0YOgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1swL79-000000092Hr-2MaM; Thu, 03 Oct 2024 12:39:27 +0000 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1swL6S-000000092Dj-1Z3k; Thu, 03 Oct 2024 12:38:46 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 1429220003; Thu, 3 Oct 2024 12:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1727959119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G1WWqv8PxjeMLKflSPYmbUe7DeomMcAnSm/A8iMPhzI=; b=jaIPWC0Xu79mrXEmZMnQsiXzA9Wr3uoH8MULWQT5IUuNp55G4sX5QevmhszIPLVwNB8KAr O3AkPLtQl5yloTMbuyNDdO+X5TRPKMqYEvSTrAQoGgw5IuBAjgFtNYLiG0d10jUZ4bA3FH m1e4s8kFAAe17/+QzeW38cun4KUy2aCMbNTrAFDwf/82DfLhx3fqZMuDYE4KWwrNFUQiLe EpyU5sN7nS1+Zc1hdPjgaFvbZTVp4v512I9O9Hvnt/yMn7PWEyyffcB8w/4zGq889GcVPI rtotQp17FYcj62LrbVAqrFIRzZevDuIvYg4y31zSeUiM6gR48lVIIrxWlvKtpw== Date: Thu, 3 Oct 2024 14:38:35 +0200 From: Louis Chauvet To: Ville Syrjala Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Liviu Dudau , Russell King , Inki Dae , Patrik Jakobsson , Alain Volmat , Sandy Huang , Jyri Sarha , Alexey Brodkin , Hans de Goede , =?iso-8859-1?Q?Ma=EDra?= Canal , Zack Rusin , amd-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/2] drm: Move crtc->{x, y, mode, enabled} to legacy sub-structure Message-ID: Mail-Followup-To: Ville Syrjala , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, Liviu Dudau , Russell King , Inki Dae , Patrik Jakobsson , Alain Volmat , Sandy Huang , Jyri Sarha , Alexey Brodkin , Hans de Goede , =?iso-8859-1?Q?Ma=EDra?= Canal , Zack Rusin , amd-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux.dev, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, xen-devel@lists.xenproject.org References: <20241002182200.15363-1-ville.syrjala@linux.intel.com> <20241002182200.15363-3-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20241002182200.15363-3-ville.syrjala@linux.intel.com> X-GND-Sasl: louis.chauvet@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241003_053844_741391_30D8A3D5 X-CRM114-Status: GOOD ( 20.35 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Le 02/10/24 - 21:22, Ville Syrjala a =E9crit : > From: Ville Syrj=E4l=E4 > = > Atomic drivers shouldn't be using the legacy state stored > directly under drm_crtc. Move that junk into a 'legacy' sub > structure to highlight the offenders, of which there are > quite a few unfortunately. Hi, Do we need to do something particular in an atomic driver except using state content? I proposed some modifications for VKMS bellow. If you think this is good, I can send a patch to avoid being an offender :-) I just tested it, and it seems to work. > I'm hoping we could get all these fixed and then declare > the legacy state off limits for atomic drivers (which is > what did long ago for plane->fb/etc). And maybe eventually > turn crtc->legacy into a pointer and only allocate it on > legacy drivers. > = > TODO: hwmode should probably go there too but it probably > needs a closer look, maybe other stuff too... [...] > diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/= vkms_composer.c > index 57a5769fc994..a7f8b1da6e85 100644 > --- a/drivers/gpu/drm/vkms/vkms_composer.c > +++ b/drivers/gpu/drm/vkms/vkms_composer.c > @@ -187,7 +187,7 @@ static void blend(struct vkms_writeback_job *wb, > = > const struct pixel_argb_u16 background_color =3D { .a =3D 0xffff }; > = > - size_t crtc_y_limit =3D crtc_state->base.crtc->mode.vdisplay; > + size_t crtc_y_limit =3D crtc_state->base.crtc->legacy.mode.vdisplay; size_t crtc_y_limit =3D crtc_state->base.mode.vdisplay; > /* > * The planes are composed line-by-line to avoid heavy memory usage. It= is a necessary > @@ -270,7 +270,7 @@ static int compose_active_planes(struct vkms_writebac= k_job *active_wb, > if (WARN_ON(check_format_funcs(crtc_state, active_wb))) > return -EINVAL; > = > - line_width =3D crtc_state->base.crtc->mode.hdisplay; > + line_width =3D crtc_state->base.crtc->legacy.mode.hdisplay; line_width =3D crtc_state->base.mode.hdisplay; > stage_buffer.n_pixels =3D line_width; > output_buffer.n_pixels =3D line_width; > = > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms= _crtc.c > index a40295c18b48..780681ea77e4 100644 > --- a/drivers/gpu/drm/vkms/vkms_crtc.c > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c > @@ -64,7 +64,7 @@ static int vkms_enable_vblank(struct drm_crtc *crtc) > struct drm_vblank_crtc *vblank =3D drm_crtc_vblank_crtc(crtc); > struct vkms_output *out =3D drm_crtc_to_vkms_output(crtc); > = > - drm_calc_timestamping_constants(crtc, &crtc->mode); > + drm_calc_timestamping_constants(crtc, &crtc->legacy.mode); drm_calc_timestamping_constants(crtc, &crtc->state->mode); > hrtimer_init(&out->vblank_hrtimer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); > out->vblank_hrtimer.function =3D &vkms_vblank_simulate; > diff --git a/drivers/gpu/drm/vkms/vkms_writeback.c b/drivers/gpu/drm/vkms= /vkms_writeback.c > index bc724cbd5e3a..27164cddb94d 100644 > --- a/drivers/gpu/drm/vkms/vkms_writeback.c > +++ b/drivers/gpu/drm/vkms/vkms_writeback.c > @@ -131,8 +131,8 @@ static void vkms_wb_atomic_commit(struct drm_connecto= r *conn, > struct drm_connector_state *conn_state =3D wb_conn->base.state; > struct vkms_crtc_state *crtc_state =3D output->composer_state; > struct drm_framebuffer *fb =3D connector_state->writeback_job->fb; > - u16 crtc_height =3D crtc_state->base.crtc->mode.vdisplay; > - u16 crtc_width =3D crtc_state->base.crtc->mode.hdisplay; > + u16 crtc_height =3D crtc_state->base.crtc->legacy.mode.vdisplay; > + u16 crtc_width =3D crtc_state->base.crtc->legacy.mode.hdisplay; u16 crtc_height =3D crtc_state->base.mode.vdisplay; u16 crtc_width =3D crtc_state->base.mode.hdisplay; > struct vkms_writeback_job *active_wb; > struct vkms_frame_info *wb_frame_info; > u32 wb_format =3D fb->format->format; [...] -- = Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic