From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57CA7C47DA9 for ; Sat, 27 Jan 2024 20:50:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oxMgzG6Kq3wownVZmDarE1p34zJwMwGVpS41wcs6egI=; b=Kk/BJeG9Ol8aC6 19mOp0eAlx6+McrZ7x43EhftU2iKxoF9tAKqfxWdAn0cWCpJdQ23GmNGENOB2XcLgAo/yDa6K6dzD OfGbmec9Ej9xx6oekcjXYTkZxOHB5F3fVl+rRK9YAb7IaR+0F6XvXJLlnZ2NDoksZBe+mL4yg+Zoz LoRb6RWDxTgB/8r8kONuc++KMjDlEOXOfG7xWfuVptEBI8XYkY2ZfzKdOBt2x+Rcy0lksLHc6qeWU 6OMda4g8tLpi27x9urq7H7UhTYCzcZZu/c6cbpS7I8HOtlpNxHJ5T+mPwgwmwbHlC198LounIHfkm lbsURCJLJ7xsaB4KGb0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTpdM-00000008BTF-2Xf8; Sat, 27 Jan 2024 20:50:36 +0000 Received: from [50.53.50.0] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTpdE-00000008BSP-2pEF; Sat, 27 Jan 2024 20:50:28 +0000 Message-ID: Date: Sat, 27 Jan 2024 12:50:27 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/17] media: media-entity.h: Fix kerneldoc Content-Language: en-US To: Sakari Ailus Cc: Ricardo Ribalda , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Mauro Carvalho Chehab , Matthias Brugger , AngeloGioacchino Del Regno , Laurent Pinchart , Hans Verkuil , Hans Verkuil , Kieran Bingham , Bin Liu , Ezequiel Garcia , Philipp Zabel , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Sylwester Nawrocki , Krzysztof Kozlowski , Alim Akhtar , Marek Szyprowski , Andrzej Hajda , Bingbu Cao , Tianshu Qiu , Greg Kroah-Hartman , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-staging@lists.linux.dev, linux-amlogic@lists.infradead.org References: <20240126-gix-mtk-warnings-v1-0-eed7865fce18@chromium.org> <20240126-gix-mtk-warnings-v1-3-eed7865fce18@chromium.org> From: Randy Dunlap In-Reply-To: X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 1/27/24 10:40, Sakari Ailus wrote: > Hi Randy, > > On Fri, Jan 26, 2024 at 05:51:06PM -0800, Randy Dunlap wrote: >> >> >> On 1/26/24 15:16, Ricardo Ribalda wrote: >>> The fields seems to be documented twice. >>> >>> Signed-off-by: Ricardo Ribalda >>> --- >>> include/media/media-entity.h | 4 ---- >>> 1 file changed, 4 deletions(-) >>> >>> diff --git a/include/media/media-entity.h b/include/media/media-entity.h >>> index 2b6cd343ee9e..c79176ed6299 100644 >>> --- a/include/media/media-entity.h >>> +++ b/include/media/media-entity.h >>> @@ -337,10 +337,6 @@ enum media_entity_type { >>> * @info.dev: Contains device major and minor info. >>> * @info.dev.major: device node major, if the device is a devnode. >>> * @info.dev.minor: device node minor, if the device is a devnode. >>> - * @major: Devnode major number (zero if not applicable). Kept just >>> - * for backward compatibility. >>> - * @minor: Devnode minor number (zero if not applicable). Kept just >>> - * for backward compatibility. >>> * >>> * .. note:: >>> * >>> >> >> I'd say that this is correct based on >> https://patchwork.kernel.org/project/linux-media/patch/20231223050707.14091-1-rdunlap@infradead.org/ >> Ah, I see. Thank you. >> >> Hans, can you please explain this message from you, on 2024-Jan-22, that >> I cannot find in the media patchwork: > > It's in linuxtv.org Patchwork here > > and also in the media stage tree (as indicated by the state) but not yet in > master AFAIU. > >> >> >> Subject: [git:media_stage/master] media: media-entity.h: fix Excess kernel-doc description warnings >> >> >> >> This is an automatic generated email to let you know that the following patch were queued: >> >> Subject: media: media-entity.h: fix Excess kernel-doc description warnings >> Author: Randy Dunlap >> Date: Fri Dec 22 21:07:07 2023 -0800 >> >> Remove the @major: and @minor: lines to prevent the kernel-doc warnings: >> >> include/media/media-entity.h:376: warning: Excess struct member 'major' description in 'media_entity' >> include/media/media-entity.h:376: warning: Excess struct member 'minor' description in 'media_entity' >> >> Signed-off-by: Randy Dunlap >> Reviewed-by: Laurent Pinchart >> Signed-off-by: Sakari Ailus >> Signed-off-by: Hans Verkuil >> >> include/media/media-entity.h | 4 ---- >> 1 file changed, 4 deletions(-) >> >> --- >> >> diff --git a/include/media/media-entity.h b/include/media/media-entity.h >> index 2b6cd343ee9e..c79176ed6299 100644 >> --- a/include/media/media-entity.h >> +++ b/include/media/media-entity.h >> @@ -337,10 +337,6 @@ enum media_entity_type { >> * @info.dev: Contains device major and minor info. >> * @info.dev.major: device node major, if the device is a devnode. >> * @info.dev.minor: device node minor, if the device is a devnode. >> - * @major: Devnode major number (zero if not applicable). Kept just >> - * for backward compatibility. >> - * @minor: Devnode minor number (zero if not applicable). Kept just >> - * for backward compatibility. >> * >> * .. note:: >> * >> >> >> >> Thanks. > -- #Randy _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic