Re: [PATCH] ARM: dts: Kill off skeleton{64}.dtsi

From: Vladimir Zapolskiy <vz@mleia.com>
To: Rob Herring <robh@kernel.org>, arm@kernel.org
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"Maxime Ripard" <maxime.ripard@bootlin.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Baruch Siach" <baruch@tkos.co.il>,
	"David Brown" <david.brown@linaro.org>,
	"Jamie Iles" <jamie@jamieiles.com>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>,
	linux-stm32@st-md-mailman.stormreply.com,
	"Alexandre Torgue" <alexandre.torgue@st.com>,
	"Jesper Nilsson" <jesper.nilsson@axis.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Gregory Clement" <gregory.clement@bootlin.com>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	linux-arm-kernel@axis.com, "Jon Mason" <jonmason@broadcom.com>,
	"Ludovic Desroches" <ludovic.desroches@microchip.com>,
	bcm-kernel-feedback-list@broadcom.com,
	"Hauke Mehrtens" <hauke@hauke-m.de>,
	"Andy Gross" <andy.gross@linaro.org>,
	"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	"Jason Cooper" <jason@lakedaemon.net>,
	"Antoine Tenart" <antoine.tenart@bootlin.com>,
	"Ray Jui" <rjui@broadcom.com>,
	"Sylvain Lemieux" <slemieux.tyco@gmail.com>,
	"Haojian Zhuang" <haojian.zhuang@gmail.com>,
	linux-mediatek@lists.infradead.org,
	"Lars Persson" <lars.persson@axis.com>,
	"Gregory Fong" <gregory.0xf0@gmail.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	linux-amlogic@lists.infradead.org, linux-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Barry Song" <baohua@kernel.org>,
	linux-oxnas@groups.io, "Eric Miao" <eric.y.miao@gmail.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Shiraz Hashim" <shiraz.linux.kernel@gmail.com>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Li Yang" <leoyang.li@nxp.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Viresh Kumar" <vireshk@kernel.org>,
	"Carlo Caione" <carlo@caione.org>, "Jun Nie" <jun.nie@linaro.org>,
	"Brian Norris" <computersforpeace@gmail.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Tsahee Zidenberg" <tsahee@annapurnalabs.com>,
	"Daniel Mack" <daniel@zonque.org>
Subject: Re: [PATCH] ARM: dts: Kill off skeleton{64}.dtsi
Date: Tue, 4 Dec 2018 00:27:36 +0200	[thread overview]
Message-ID: <a10f92c0-50f9-1e10-4b17-c694353e4580@mleia.com> (raw)
In-Reply-To: <20181130170634.9467-1-robh@kernel.org>

On 11/30/2018 07:06 PM, Rob Herring wrote:
> Remove the usage of skeleton.dtsi in the remaining dts files. It was
> deprecated since commit 9c0da3cc61f1 ("ARM: dts: explicitly mark
> skeleton.dtsi as deprecated"). This will make adding a unit-address to
> memory nodes easier.
> 
> The main tricky part to removing skeleton.dtsi is we could end up with
> no /memory node at all when a bootloader depends on one being present. I
> hacked up dtc to check for this condition.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

[snip]

> diff --git a/arch/arm/boot/dts/lpc32xx.dtsi b/arch/arm/boot/dts/lpc32xx.dtsi
> index b7303a4e4236..44b468e4c37a 100644
> --- a/arch/arm/boot/dts/lpc32xx.dtsi
> +++ b/arch/arm/boot/dts/lpc32xx.dtsi
> @@ -11,12 +11,12 @@
>   * http://www.gnu.org/copyleft/gpl.html
>   */
>  
> -#include "skeleton.dtsi"
> -
>  #include <dt-bindings/clock/lpc32xx-clock.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
>  
>  / {
> +	#address-cells = <1>;
> +	#size-cells = <1>;
>  	compatible = "nxp,lpc3220";
>  	interrupt-parent = <&mic>;
>  

For lpc32xx:

Acked-by: Vladimir Zapolskiy <vz@mleia.com>

--
Best wishes,
Vladimir

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic