From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3273C43603 for ; Wed, 11 Dec 2019 13:15:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 970FA214D8 for ; Wed, 11 Dec 2019 13:15:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RWWQY3uU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 970FA214D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amlogic.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bg2dz9gyvzttKunzVWgyw/54UzTwgYypbjb8slyIJmQ=; b=RWWQY3uUqpOb96cmN3yMcYhGn HEU7Fruf9B3kWfDXzJgicGxuRWfnD3KYPldi+fXdV/RkbFg/1WokvqPCxM4vM2KziJ4903Oe6N1KW N+39qdbZY6qeSifsUGK0iYFZQkoucn1c75CG2oc17xbFqZyL6jjcHy3tfOPOoCbA1p9otG+sBkGrQ qdU0gNf5UL7vhI8qn1l7lSdlDUwEnp8kDahblfQnWN/VPpxhyhrLNoBHexiswREvoInjbxTy9lCwr A4c//es/nA70DY33fdXUUf8b70uvKBrkYvxWv2f38F+10xKdvhb2ochncpz8Gxe3pFMctNMC5HygL 3ND0bOHHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1if1qI-0002GT-8P; Wed, 11 Dec 2019 13:15:50 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1if1qA-00028I-Iw; Wed, 11 Dec 2019 13:15:43 +0000 Received: from [10.28.39.99] (10.28.39.99) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Wed, 11 Dec 2019 21:16:13 +0800 Subject: Re: [PATCH] arm64: dts: meson: add A1 periphs and PLL clock nodes To: Jerome Brunet , Neil Armstrong References: <20191211070835.83489-1-jian.hu@amlogic.com> <1jimmnkxj5.fsf@starbuckisacylon.baylibre.com> From: Jian Hu Message-ID: Date: Wed, 11 Dec 2019 21:16:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <1jimmnkxj5.fsf@starbuckisacylon.baylibre.com> Content-Language: en-US X-Originating-IP: [10.28.39.99] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191211_051542_627555_4863FB1F X-CRM114-Status: GOOD ( 16.35 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Victor Wan , Jianxin Pan , devicetree@vger.kernel.org, Martin Blumenstingl , Kevin Hilman , Michael Turquette , linux-kernel@vger.kernel.org, Stephen Boyd , Qiufang Dai , Chandle Zou , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 2019/12/11 17:43, Jerome Brunet wrote: > > On Wed 11 Dec 2019 at 08:08, Jian Hu wrote: > >> Add A1 periphs and PLL clock controller nodes, Some clocks >> in periphs controller are the parents of PLL clocks, Meanwhile >> some clocks in PLL controller are those of periphs clocks. >> They rely on each other. > >> Compared with the previous series, >> the register region is only for the clock. So syscon is not >> used in A1. > > Again, while this is valuable information for the maintainer to keep up, > it is not something that should appear in the commit description. > > The evolution of your commit should be described after the '---' > OK, I will put the compared message after the '---' > Also, this obviously depends on another series. It should be mentioned > accordingly OK, I will add the dependent clock patchset. > >> >> Signed-off-by: Jian Hu >> --- >> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 26 +++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi >> index 7210ad049d1d..de43a010fa6e 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi >> @@ -5,6 +5,8 @@ >> >> #include >> #include >> +#include >> +#include > > When possible, please order the includes alpha-numerically > OK, I will reorder it. >> >> / { >> compatible = "amlogic,a1"; >> @@ -74,6 +76,30 @@ >> #size-cells = <2>; >> ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x1000000>; >> >> + clkc_periphs: periphs-clock-controller@800 { > ^ >>>From DT spec: "The name of a node should be somewhat generic, reflecting > the function of the device and not its precise programming model." > > Here, an appropriate node name would be "clock-controller", not > "periphs-clock-controller" OK, I will change the node name. > >> + compatible = "amlogic,a1-periphs-clkc"; >> + #clock-cells = <1>; >> + reg = <0 0x800 0 0x104>; >> + clocks = <&clkc_pll CLKID_FCLK_DIV2>, >> + <&clkc_pll CLKID_FCLK_DIV3>, >> + <&clkc_pll CLKID_FCLK_DIV5>, >> + <&clkc_pll CLKID_FCLK_DIV7>, >> + <&clkc_pll CLKID_HIFI_PLL>, >> + <&xtal>; >> + clock-names = "fclk_div2", "fclk_div3", >> + "fclk_div5", "fclk_div7", >> + "hifi_pll", "xtal"; >> + }; >> + >> + clkc_pll: pll-clock-controller@7c80 { > > Please order nodes by address when they have one. > This clock controller should appear after the uarts OK, I will reorder it. > >> + compatible = "amlogic,a1-pll-clkc"; >> + #clock-cells = <1>; >> + reg = <0 0x7c80 0 0x21c>; >> + clocks = <&clkc_periphs CLKID_XTAL_FIXPLL>, >> + <&clkc_periphs CLKID_XTAL_HIFIPLL>; >> + clock-names = "xtal_fixpll", "xtal_hifipll"; >> + }; >> + >> uart_AO: serial@1c00 { >> compatible = "amlogic,meson-gx-uart", >> "amlogic,meson-ao-uart"; > > . > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic