From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 256F1606A333 for ; Thu, 22 Oct 2026 17:49:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=je20lzK0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=Qx/JDMU0bqDjWuCCNo7tqoKuZDMrW0LG3/V3TuPL1sg=; b=je20lzK0HfVhktz3Qv6pjSpzOp X3vm0RIKfdm3J8+7gClEYurx5ZBP8d044Sr16ehHdGa7E6yBOydgYWr8AsvPN8jJ9pkirCMBbPgaY oAZTAhd21vfG0hka3/ndEsJEQ8k+Y8x77pqFcM2Td0CemJBOeamWjeNjqYYzPJon2pyNFa4FdapDd A2aOgANic2avD3wityV3Olra/cAHlxEtlFKNKy333vQ8MPHfFpVWIZdYQhKRRGkNu5GVirjpDkVgK a4JpX4WMB/07g+5j/WKdkkAjbGvUySlHOc2WSq7RY5OzMewHeNuedU5/teSWaDeyjg0+dYSlBvYC7 mrPbyDlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xJwv4-0000000Edfj-2yEy; Thu, 22 Oct 2026 17:49:38 +0000 Received: from mail-wm1-f51.google.com ([209.85.128.51]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xJwv2-0000000Eddx-03XE for linux-amlogic@lists.infradead.org; Thu, 22 Oct 2026 17:49:37 +0000 Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4a209a7fd1bso476375e9.1 for ; Thu, 22 Oct 2026 10:49:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792691374; x=1793296174; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HmShLIi0Try9xlFwdP7Bt6IdYlCRVmbmMWtY33HkzA4=; b=bduZjFxMnyxA/nvGutzuzvC/H37Bnx4XSzZhLTBSK2TzlJya21wAldylwv1oZqjov2 VqF6ZdPKa/so+1CEK5SM32AqgCYroAjoxQ6RCN2jN7MAqtgwwre2g8g5aRsjomR6CzP1 mbIHE8zZH1XLLa0krDNFU4FNxkgBbT4wX5ZICodVMEYduOSpU/91iseehJa/oDoX+w0D 8oVXE/SlsrSdfxeMZC3si7k8g3hi91H6Fe84xnvj8MJEIhZYhoSU/0hlJWdMN+7Wxtoz hV7K/fOzY6LSgT0ZOVbmhv1Dexe8O8sv+VpwAff2SIXUxXxVPP11M8wcr74R0KiI9t0c a+pw== X-Forwarded-Encrypted: i=1; AKwUvBxMIEqIXq7a7H72Z/39qSKzF4KG+/f7bvohQsjw5xXzej4MJB96FSTM/6nPvxKSlsjANMFKVCzczbvdc16V@lists.infradead.org X-Gm-Message-State: AFq9FYK0ef6QTyHuQPmbMowGw9cO9GYzGbipuu5PnRm33UdgN6tj8uRT P+wtlrB0wmkNbzInBObHMREjgfWsk5/C/SKXSHt12xvqWAbdQkOomcTA X-Gm-Gg: AYBFou2YXGbLZjhiuw8BdDEUivAQYE9BQGE1JtasZHPQFKBSlg2IGsimqy3y0LITBUI g27S0ltWcpdAKldqrK+9oBtQLN82VyAUSjhmWSLMHKMegS44beovVlKruFsbRGD1jZ6uZJXOOow CX/JOXdaXV4lDJ54UgNmry2DQePaGb1Gm2E6d7N2zTpf4gh1k7lJxQYQ2zAOwD1NuI8ZXm/tOSl fuMgGKdqxU6FRqQCsRa71IeIIRtZtRGFYBn3R416TwB4a5W6qgvjk1LMswtk/SDuL2LPgftETj1 tTZsb2lA9HRrzB57Jy5iO2KI2vmgtPkOPzILlNiUk82I60Hgee6QIIlUdVs2dPOleH9x4wDmHLG YfOndx045Wh7xMRYbmMsh39B9hfDQOSBqxBawxVCJPoFpG5aGlTD9dHKTbbwXufe/JKA924+BAn SvSoyNgfFf4fysy1U/7TcyRThVRqYByK5aGG18+h8bfoVuLVpK6cJ24JWYS5nh8sMbQy4AKBK9e JrVlJeAuRs/JSCYAoUK67KqlJyknladEQFukfiv/MJg79w8FN8Jo2UW63dRPRpF2S7d5vRaEuS5 IUnTpRKPuw== X-Received: by 2002:a05:600c:4684:b0:4a1:d36f:1ba0 with SMTP id 5b1f17b1804b1-4a1fdd74b6cmr122177475e9.35.1792691373949; Thu, 22 Oct 2026 10:49:33 -0700 (PDT) Received: from [192.168.1.135] ([81.79.62.202]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a21047b2absm13451355e9.13.2026.10.22.10.49.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Oct 2026 10:49:33 -0700 (PDT) Message-ID: Date: Thu, 22 Oct 2026 18:49:32 +0100 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 8/8] dt-bindings: net: ethernet-controller: tabulate who adds the RGMII delays To: Conor Dooley Cc: xianwei.zhao@amlogic.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20261010105900.247342-1-tanure@linux.com> <20261010105900.247342-9-tanure@linux.com> <20261012-suds-karaoke-efc4acf056af@spud> Content-Language: en-US From: Lucas Tanure In-Reply-To: <20261012-suds-karaoke-efc4acf056af@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261022_104936_075206_1317DB9C X-CRM114-Status: GOOD ( 14.53 ) X-Spam-Score: -0.7 (/) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 12/10/2026 20:18, Conor Dooley wrote: > On Sat, Oct 10, 2026 at 11:59:00AM +0100, Lucas Tanure wrote: >> The informative section explains in prose how phy-mode, the delay >> properties in the MAC node and the mode handed to the PHY fit together, >> and says itself that developers often get this wrong. A reader has to >> work through several paragraphs before answering the one question they >> usually have: for this phy-mode and these properties, which part adds >> which delay. >> >> Add a table that answers it at a glance, with one row for every >> combination the properties allow. >> >> Assisted-by: LLM >> Signed-off-by: Lucas Tanure > > If the net guys think this is valuable, > Acked-by: Conor Dooley > Thanks, but I will drop this patch as is wrong.> (although for something like this, us acking probably ain't needed, > ehh?) > >> --- >> .../bindings/net/ethernet-controller.yaml | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml >> index 1bafd687dcb1..bba27a9feb61 100644 >> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml >> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml >> @@ -339,6 +339,24 @@ additionalProperties: true >> # has added. Failure to remove the delay will result in a >> # non-functioning link. >> # >> +# Put together, with the two properties in the MAC node, this is who >> +# adds each delay: >> +# >> +# phy-mode tx-internal-delay-ps rx-internal-delay-ps TX delay RX delay >> +# rgmii - - PCB trace PCB trace >> +# rgmii-id - - PHY PHY >> +# rgmii-id present - MAC PHY >> +# rgmii-id - present PHY MAC >> +# rgmii-id present present MAC MAC >> +# rgmii-txid - - PHY PCB trace >> +# rgmii-txid present - MAC PCB trace >> +# rgmii-rxid - - PCB trace PHY >> +# rgmii-rxid - present PCB trace MAC >> +# >> +# A property for a clock the PCB already delays is not in this table. >> +# It is either the fine tuning described next, or a mistake the MAC >> +# should report as a fatal error. >> +# >> # Sometimes there is a need to fine tune the delays. Often the MAC or >> # PHY can perform this fine tuning. In the MAC node, the Device Tree >> # properties 'rx-internal-delay-ps' and 'tx-internal-delay-ps' should >> -- >> 2.56.0 >> _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic