From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE524D116EA for ; Fri, 28 Nov 2025 21:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0TSGXDgu1c/Az++IpMfUlTICKb+XPJ+5HVeNR1i43HU=; b=ouuZW3F72ubjVj u44fbKb6nyjHpuMLZpNb3Wl+/66OabK5nI33dKsRqeswNhTVT/+pidY+HnXmHLvLmNrVgm53skjLW eV6f4VGsVqg1GnghvIKc/8EDQe18o9aLUJ1/88Nk0nis4T/PNX4TLEv+pvaEnuSItFB2v5/BDq4xL 4jrVxeDh1K2SCPxJEAjJ4Mx3W3ikwd/lgFS4wtIliQbVSCXWZR7Xhr5VRF5XFuMVwlwttZDvVHWZw 9uc49Pa91fasAAKNcgS8Zx7o49471N/3BQ1SXuUnQxQSGeGYGCa6N7AMTfE52HW03F080BNPTnSvz B3ByoPCdJ54BWy59AA+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vP6ME-00000000zPq-3qWT; Fri, 28 Nov 2025 21:50:26 +0000 Received: from [50.53.43.113] (helo=[192.168.254.34]) by bombadil.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1vP6M8-00000000zPG-37J4; Fri, 28 Nov 2025 21:50:20 +0000 Message-ID: Date: Fri, 28 Nov 2025 13:50:19 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/26] drm/bridge: make of_drm_find_bridge() a wrapper of of_drm_get_bridge() To: Luca Ceresoli , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alexey Brodkin , Phong LE , Liu Ying , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Adrien Grassein , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Anitha Chrisanthus , Inki Dae , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar Cc: Hui Pu , Thomas Petazzoni , Louis Chauvet , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20251128-drm-bridge-alloc-getput-drm_of_find_bridge-v2-0-88f8a107eca2@bootlin.com> <20251128-drm-bridge-alloc-getput-drm_of_find_bridge-v2-4-88f8a107eca2@bootlin.com> Content-Language: en-US From: Randy Dunlap In-Reply-To: <20251128-drm-bridge-alloc-getput-drm_of_find_bridge-v2-4-88f8a107eca2@bootlin.com> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On 11/28/25 8:50 AM, Luca Ceresoli wrote: > of_drm_find_bridge() is identical to of_drm_get_bridge() except it does > not increment the refcount. Rewrite it as a wrapper and put the bridge > being returned so the behaviour is still the same. > > Signed-off-by: Luca Ceresoli > > --- > > Changed in v2: > - Added comment to document why we put the reference > --- > drivers/gpu/drm/drm_bridge.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c > index 21a84715d221..9b7e3f859973 100644 > --- a/drivers/gpu/drm/drm_bridge.c > +++ b/drivers/gpu/drm/drm_bridge.c > @@ -1467,19 +1467,17 @@ EXPORT_SYMBOL(of_drm_get_bridge); > */ > struct drm_bridge *of_drm_find_bridge(struct device_node *np) > { > - struct drm_bridge *bridge; > - > - mutex_lock(&bridge_lock); > + struct drm_bridge *bridge = of_drm_get_bridge(np); > > - list_for_each_entry(bridge, &bridge_list, list) { > - if (bridge->of_node == np) { > - mutex_unlock(&bridge_lock); > - return bridge; > - } > - } > + /** This isn't a kernel-doc comment, so please don't use "/**" here. Just use "/*". > + * We need to emulate the original semantics of > + * of_drm_find_bridge(), which was not getting any bridge > + * reference. Being now based on of_drm_get_bridge() which gets a > + * reference, put it before returning. > + */ > + drm_bridge_put(bridge); > > - mutex_unlock(&bridge_lock); > - return NULL; > + return bridge; > } > EXPORT_SYMBOL(of_drm_find_bridge); > #endif > -- ~Randy _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic