From: qianggui.song <Qianggui.Song@amlogic.com>
To: Jerome Brunet <jbrunet@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
<linux-gpio@vger.kernel.org>
Cc: kernel test robot <lkp@intel.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: meson: fix unused variable warning
Date: Tue, 29 Mar 2022 16:54:33 +0800 [thread overview]
Message-ID: <a5708e46-7169-c2e3-369f-e31b8a5d1b14@amlogic.com> (raw)
In-Reply-To: <1j8rstjhec.fsf@starbuckisacylon.baylibre.com>
On 3/29/22 16:21, Jerome Brunet wrote:
>
> On Tue 29 Mar 2022 at 14:08, Qianggui Song <qianggui.song@amlogic.com> wrote:
>
>> The kernel test robot reported a warning as below:
>>>> drivers/pinctrl/meson/pinctrl-meson-s4.c:178:27: warning: unused variable 'tdm_sclk1_c_pins' [-Wunused-const-variable]
>> static const unsigned int tdm_sclk1_c_pins[] = { GPIOC_3 };
>>
>> Fix it by adding missing description about this pins
>>
>> Fixes: 775214d389c2 ("pinctrl: meson: add pinctrl driver support for Meson-S4 Soc")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Qianggui Song <qianggui.song@amlogic.com>
>> ---
>> drivers/pinctrl/meson/pinctrl-meson-s4.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/pinctrl/meson/pinctrl-meson-s4.c b/drivers/pinctrl/meson/pinctrl-meson-s4.c
>> index 3c7358f53302..067c6749c849 100644
>> --- a/drivers/pinctrl/meson/pinctrl-meson-s4.c
>> +++ b/drivers/pinctrl/meson/pinctrl-meson-s4.c
>> @@ -575,6 +575,7 @@ static struct meson_pmx_group meson_s4_periphs_groups[] = {
>> GROUP(tdm_d2_c, 4),
>> GROUP(tdm_d3_c, 4),
>> GROUP(tdm_fs1_c, 4),
>> + GROUP(tdm_sclk1_c, 4),
>> GROUP(mclk_1_c, 4),
>> GROUP(tdm_d4_c, 4),
>> GROUP(tdm_d5_c, 4),
>> @@ -937,6 +938,7 @@ static const char * const iso7816_groups[] = {
>>
>> static const char * const tdm_groups[] = {
>> "tdm_d2_c", "tdm_d3_c", "tdm_fs1_c", "tdm_d4_c", "tdm_d5_c",
>> + "tdm_sclk1_c",
>
> Thanks for fixing this.
> Could you please try to keep this list somehow ordered a bit ?
> Here you are adding a new line in the middle with single entry ... it
> looks weird.
>
>> "tdm_fs1_d", "tdm_d4_d", "tdm_d3_d", "tdm_d2_d", "tdm_sclk1_d",
>> "tdm_sclk1_h", "tdm_fs1_h", "tdm_d2_h", "tdm_d3_h", "tdm_d4_h",
>> "tdm_d1", "tdm_d0", "tdm_fs0", "tdm_sclk0", "tdm_fs2", "tdm_sclk2",
>
> .
Just think that put the tdm_sclk1_c in first line make line too long.
Okay, will put it to first line next patch that make one line per bank
for pins in order.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2022-03-29 8:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 6:08 Qianggui Song
2022-03-29 8:21 ` Jerome Brunet
2022-03-29 8:54 ` qianggui.song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5708e46-7169-c2e3-369f-e31b8a5d1b14@amlogic.com \
--to=qianggui.song@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®