From: Robin Murphy <robin.murphy@arm.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Cc: sean@mess.org, mchehab@kernel.org, robh+dt@kernel.org,
khilman@baylibre.com, Neil Armstrong <narmstrong@baylibre.com>,
jbrunet@baylibre.com, linux-media <linux-media@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, rockosov@gmail.com
Subject: Re: [PATCH v6 1/2] media: rc: meson-ir-tx: document device tree bindings
Date: Mon, 19 Jul 2021 11:40:47 +0100 [thread overview]
Message-ID: <a60c3706-fb11-f66c-6c17-d0f960241e03@arm.com> (raw)
In-Reply-To: <CAFBinCBpxcHHDs2cr+V4gDVk48G3+T7V-Lde2CkY6xvVrqixmA@mail.gmail.com>
Hi Martin,
(just reading this patch out of passing curiosity...)
On 2021-07-17 20:57, Martin Blumenstingl wrote:
> Hi Viktor,
>
> On Fri, Jul 16, 2021 at 4:45 PM Viktor Prutyanov
> <viktor.prutyanov@phystech.edu> wrote:
> [...]
>> + amlogic,fifo-threshold:
>> + description: TX FIFO threshold
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + minimum: 0
>> + maximum: 127
> I tried to make sense of this property but I don't understand it yet
> (even after reading the second patch in this series).
> A "FIFO" (in my own words) is some physical property of the IR
> transmitter in these Amlogic SoCs.
> So for one specific SoC there can only be one FIFO size, not a range (0..127).
>
> What about a value of 0: my understanding is that this means that
> there's no FIFO. Will this hardware still work in that case?
>
> From reading the driver code it seems to me that the FIFO size is 128.
> The driver can use fewer FIFO entries if it wants, but this must not
> affect the dt-bindings (as these describe the hardware - they don't
> "configure" the driver).
> If you look at arch/arm64/boot/dts/amlogic/meson-g12.dtsi you'll find
> toddr_a, toddr_b and toddr_c there:
> All three of them use identical circuitry internally, except that
> toddr_a has a bigger FIFO size than the other two. Using a FIFO size
> of 256 for toddr_a is not correct as it's an improper description of
> the toddr_a hardware (that said, the driver can still decide that it
> only wants to use 256 FIFO entries).
In general, a FIFO threshold is not about how much of the FIFO you use
overall, but how often and/or urgently you tend to it. If the only thing
that matters is minimising CPU overhead then the optimum choice is to
wait until the FIFO is entirely full/empty before taking action to
drain/refill it. However, that necessarily creates a pause in
reception/transmission for the time it takes to respond to the
empty/full interrupt, hence why many FIFOs also implement a threshold
interrupt for cases when uninterrupted communication is more desirable
than absolutely minimising interrupts. Typically those are set to fire
at some point shortly *before* the FIFO becomes completely full/empty,
to leave enough remaining buffer for communication to continue during
that time window until the ISR actually gets to respond.
That said, I'm also doubtful about this particular case. If the physical
FIFO depth does actually vary between SoCs, that should be known by the
driver and implicit in the compatible string, definitely not hidden in a
tangential property. Otherwise, it's not apparent how this makes sense
to configure statically on a per-SoC or per-board basis. If anything it
would depend on the transmission rate of whatever IR protocol the user
wishes to use at any given time AFAICS. If it's not sufficient for the
driver to simply assume, say, an 80% threshold as "good enough", then
presumably it has enough information about the clock rate and/or the
parameters of the given Tx request to implement a slightly cleverer
heuristic. If it's desirable to tweak the specific driver behaviour in
cases where the user does know better, then by all means make that a
module parameter, but it's not something which belongs in DT.
Cheers,
Robin.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2021-07-19 10:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 14:45 [PATCH v6 0/2] media: rc: add support for Amlogic Meson IR blaster Viktor Prutyanov
2021-07-16 14:45 ` [PATCH v6 1/2] media: rc: meson-ir-tx: document device tree bindings Viktor Prutyanov
2021-07-17 19:57 ` Martin Blumenstingl
2021-07-19 10:40 ` Robin Murphy [this message]
2021-07-16 14:45 ` [PATCH v6 2/2] media: rc: introduce Meson IR TX driver Viktor Prutyanov
2021-07-16 15:34 ` Sean Young
2021-07-16 16:01 ` Viktor Prutyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a60c3706-fb11-f66c-6c17-d0f960241e03@arm.com \
--to=robin.murphy@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mchehab@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=rockosov@gmail.com \
--cc=sean@mess.org \
--cc=viktor.prutyanov@phystech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®