From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/2] drm: meson: rename driver name to meson-drm
Date: Thu, 2 Feb 2017 11:50:59 +0100 [thread overview]
Message-ID: <a6655fb5-5267-6536-d9b6-5ce0ff9f25ec@baylibre.com> (raw)
In-Reply-To: <20170202104514.nogjnsuimeulml53@phenom.ffwll.local>
On 02/02/2017 11:45 AM, Daniel Vetter wrote:
> On Thu, Feb 02, 2017 at 10:47:44AM +0100, Neil Armstrong wrote:
>> The platform driver name is currently "meson" which can lead to some
>> confusion, this patch renames it to "meson-drm" and removes the owner
>> attribute.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> drivers/gpu/drm/meson/meson_drv.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c
>> index ff1f601..380bde7 100644
>> --- a/drivers/gpu/drm/meson/meson_drv.c
>> +++ b/drivers/gpu/drm/meson/meson_drv.c
>> @@ -329,8 +329,7 @@ static int meson_drv_remove(struct platform_device *pdev)
>> .probe = meson_drv_probe,
>> .remove = meson_drv_remove,
>> .driver = {
>> - .owner = THIS_MODULE,
Hi Daniel,
> I don't get why you remove this, generally that will lead to trouble of
> being able to unload code that's still in use ...
Indeed, but since a (long ?) time, the owner field is now populated by the
platform_driver_register() core code.
>
> Otherwise ack.
>
> Now, do you want to get this landed as part of the small drivers in
> drm-mis experiment?
I have a PR ready, but it can go through this experiment, yes.
> -Daniel
>
>> - .name = DRIVER_NAME,
>> + .name = "meson-drm",
>> .of_match_table = dt_match,
>> },
>> };
>> --
Thanks,
Neil
next prev parent reply other threads:[~2017-02-02 10:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 9:47 [PATCH 0/2] drm: meson: Fixup driver and module name Neil Armstrong
2017-02-02 9:47 ` [PATCH 1/2] drm: meson: rename module name to meson-drm Neil Armstrong
2017-02-02 9:47 ` [PATCH 2/2] drm: meson: rename driver " Neil Armstrong
2017-02-02 10:45 ` Daniel Vetter
2017-02-02 10:50 ` Neil Armstrong [this message]
2017-02-02 12:06 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6655fb5-5267-6536-d9b6-5ce0ff9f25ec@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®