From: narmstrong@baylibre.com (Neil Armstrong)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH u-boot 1/3] boards: amlogic: remove ethernet gpio reset code from boards
Date: Mon, 20 Aug 2018 10:36:55 +0200 [thread overview]
Message-ID: <a8358bc8-70e4-6f53-facd-29b3ceea715e@baylibre.com> (raw)
In-Reply-To: <20180814130754.19294-2-b.galvani@gmail.com>
On 14/08/2018 15:07, Beniamino Galvani wrote:
> The reset is already handled by the designware driver using
> information from device tree.
>
> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> ---
> board/amlogic/nanopi-k2/nanopi-k2.c | 6 ------
> board/amlogic/odroid-c2/odroid-c2.c | 6 ------
> 2 files changed, 12 deletions(-)
>
> diff --git a/board/amlogic/nanopi-k2/nanopi-k2.c b/board/amlogic/nanopi-k2/nanopi-k2.c
> index 339dbb81db..ae29dd6fa4 100644
> --- a/board/amlogic/nanopi-k2/nanopi-k2.c
> +++ b/board/amlogic/nanopi-k2/nanopi-k2.c
> @@ -30,12 +30,6 @@ int misc_init_r(void)
>
> meson_gx_eth_init(PHY_INTERFACE_MODE_RGMII, 0);
>
> - /* Reset PHY on GPIOZ_14 */
> - clrbits_le32(GX_GPIO_EN(3), BIT(14));
> - clrbits_le32(GX_GPIO_OUT(3), BIT(14));
> - mdelay(10);
> - setbits_le32(GX_GPIO_OUT(3), BIT(14));
> -
> if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
> len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
> mac_addr, EFUSE_MAC_SIZE);
> diff --git a/board/amlogic/odroid-c2/odroid-c2.c b/board/amlogic/odroid-c2/odroid-c2.c
> index c47b9ce9cb..2a2755c387 100644
> --- a/board/amlogic/odroid-c2/odroid-c2.c
> +++ b/board/amlogic/odroid-c2/odroid-c2.c
> @@ -30,12 +30,6 @@ int misc_init_r(void)
>
> meson_gx_eth_init(PHY_INTERFACE_MODE_RGMII, 0);
>
> - /* Reset PHY on GPIOZ_14 */
> - clrbits_le32(GX_GPIO_EN(3), BIT(14));
> - clrbits_le32(GX_GPIO_OUT(3), BIT(14));
> - mdelay(10);
> - setbits_le32(GX_GPIO_OUT(3), BIT(14));
> -
> if (!eth_env_get_enetaddr("ethaddr", mac_addr)) {
> len = meson_sm_read_efuse(EFUSE_MAC_OFFSET,
> mac_addr, EFUSE_MAC_SIZE);
>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
next prev parent reply other threads:[~2018-08-20 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 13:07 [PATCH u-boot 0/3] amlogic: clean up board files Beniamino Galvani
2018-08-14 13:07 ` [PATCH u-boot 1/3] boards: amlogic: remove ethernet gpio reset code from boards Beniamino Galvani
2018-08-20 8:36 ` Neil Armstrong [this message]
2018-08-24 20:10 ` [U-Boot, u-boot, " Tom Rini
2018-08-14 13:07 ` [PATCH u-boot 2/3] boards: amlogic: use common function for environment initialization Beniamino Galvani
2018-08-20 8:43 ` Neil Armstrong
2018-08-14 13:07 ` [PATCH u-boot 3/3] arm: meson: null-terminate the serial number Beniamino Galvani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8358bc8-70e4-6f53-facd-29b3ceea715e@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®