From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F022FC7EE22 for ; Tue, 9 May 2023 07:44:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7lDu73hWBynLh54XWrLalbi0rX0ltmTe2uy2qdwR8vg=; b=HUtcZPz3JnLqm+ufHFh73Qk2cs 4IBA/7E1BkBe+n5XHU1TLlvaOqCWTmDX/nwHonHdbjmI/cAHZm7x7/E+O294YSuN7+9SRSWK67FCU dASfE8xQXr04Zv2hrHU7YIhcrym+5sZRsOkfl2G+ws+oBiTF//U1lomrO4NJkhJAi72iy65Y7V/Av TwU+2+F42xikxD+cyKa9jWbKtvPDKOfqXNYwvlB+0noN2cXNV/4SHilRv2SVjklmVT1t+tXW9foMx VdnlLDgpffYgo6yGoXVyPgPGxouwO/ok7Kn5DfzMqHgl3u2IHx6MjAAK1nKbgeSg9WRxksbiGmB3I oAOlCkQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pwI1b-002Xpn-1d; Tue, 09 May 2023 07:44:43 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pwI1Y-002XoP-1X for linux-amlogic@lists.infradead.org; Tue, 09 May 2023 07:44:42 +0000 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3f315735514so195733565e9.1 for ; Tue, 09 May 2023 00:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683618275; x=1686210275; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=/tIWIjCU0WB4+s+0CLXZp3rE/hrVxQbRrR7hGm/i1t8=; b=FS045pxekPIy3zvybkfVPHe6eMBCAkuvJgWnUdb31Avcc4yyadf8jCoDTyTn3dQp7X nJeSCyxtCn23b8AEbg8AUd9eRaIq/xYZcwQAk2hEWCjBTHvAeajabpDyQNklwEMZ58DU Kz4J2Htyn4dGPyzXyy70is1VHwsrsSzx8ia/px/eMY4UWpcUu9piuWERmxYqNasXIL08 N85eWBxxiQxVr0JUNGHr2szdrhhx7g8JzYJjvO4oMM9gngmxNqPElviZpictdF6A+3EF 4wMQzw2SyPMwAPsmI78QFBgadv2JzPwaFe0uk/mPPCK7LBGv3biIhaXQmUyVRtPRVu2Y 96eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683618275; x=1686210275; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/tIWIjCU0WB4+s+0CLXZp3rE/hrVxQbRrR7hGm/i1t8=; b=dt8tobkOzUzgo+e8PUotCTrEdYod9OEicCMVXCJ0qpajES3n30/GVrx7ecVHreYNg5 Jye09gOqm/m8FC3lI+dhwwNmEhGAApHMyL68seWiRLVf6Bp/yHLk/Y7HU4lOcH2kU/xF 67b8HPHP7oaigtMdP3HSj0acc1sE+UDPAXeM+E8RdU6eQDDPVxt+h8tKMnq0FQBbbPTS lYBpKcAzIF+Ro2F8XHtOmvb/7ZflVBV3F5j9EYBAibExVHYKn1Szm8Taj4uxALRejxQS a9ZWvaebanzRBoBQZEtJbjEdW/XN/wqvuSsEDPZ1eDel65DLu4yDiI491QHjqhWw2HWG 8z+Q== X-Gm-Message-State: AC+VfDy96EWijW8aZAdfzfMAuoyCXZ7dL+NndlrR5Gtjz1scxIjTRRzx Kfuw/WBUj2s30OBI5Mpa45xZrQ== X-Google-Smtp-Source: ACHHUZ5azk0AtvIKQkzwUK42XJg0J/YOW/KQyQjpBHJ5Rilppz/v+9dWNUtHMmojYs5nx4Y5u/mbwQ== X-Received: by 2002:adf:e483:0:b0:2ff:801b:dec6 with SMTP id i3-20020adfe483000000b002ff801bdec6mr8605708wrm.20.1683618275426; Tue, 09 May 2023 00:44:35 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:79ab:8da0:d16d:9990? ([2a01:e0a:982:cbb0:79ab:8da0:d16d:9990]) by smtp.gmail.com with ESMTPSA id e15-20020a5d4e8f000000b0030629536e64sm13492065wru.30.2023.05.09.00.44.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 May 2023 00:44:35 -0700 (PDT) Message-ID: Date: Tue, 9 May 2023 09:44:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 From: neil.armstrong@linaro.org Subject: Re: [PATCH v3 5/5] arm64: dts: meson: a1: support USB controller in OTG mode Content-Language: en-US To: Dmitry Rokosov , gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, mturquette@baylibre.com, vkoul@kernel.org, kishon@kernel.org, hminas@synopsys.com, Thinh.Nguyen@synopsys.com Cc: yue.wang@amlogic.com, hanjie.lin@amlogic.com, kernel@sberdevices.ru, rockosov@gmail.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-phy@lists.infradead.org References: <20230426102922.19705-1-ddrokosov@sberdevices.ru> <20230426102922.19705-6-ddrokosov@sberdevices.ru> Organization: Linaro Developer Services In-Reply-To: <20230426102922.19705-6-ddrokosov@sberdevices.ru> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230509_004440_538842_C52E51E8 X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi, On 26/04/2023 12:29, Dmitry Rokosov wrote: > Amlogic A1 SoC family has USB2.0 controller based on dwc2 and dwc3 > heads. It supports otg/host/peripheral modes. > > Signed-off-by: Yue Wang > Signed-off-by: Hanjie Lin > Signed-off-by: Dmitry Rokosov > --- > arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 59 +++++++++++++++++++++++ > 1 file changed, 59 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > index ae7d39cff07a..5588ee602161 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi > @@ -8,6 +8,8 @@ > #include > #include > #include > +#include > +#include > > / { > compatible = "amlogic,a1"; > @@ -169,6 +171,17 @@ gpio_intc: interrupt-controller@0440 { > amlogic,channel-interrupts = > <49 50 51 52 53 54 55 56>; > }; > + > + usb2_phy1: phy@4000 { > + compatible = "amlogic,a1-usb2-phy"; > + clocks = <&clkc CLKID_USB_PHY_IN>; > + clock-names = "xtal"; > + reg = <0x0 0x4000 0x0 0x60>; > + resets = <&reset RESET_USBPHY>; > + reset-names = "phy"; > + #phy-cells = <0>; > + power-domains = <&pwrc PWRC_USB_ID>; > + }; > }; > > gic: interrupt-controller@ff901000 { > @@ -192,6 +205,52 @@ spifc: spi@fd000400 { > #size-cells = <0>; > status = "disabled"; > }; > + > + usb: usb@fe004400 { > + status = "disabled"; > + compatible = "amlogic,meson-a1-usb-ctrl"; > + reg = <0x0 0xfe004400 0x0 0xa0>; > + interrupts = ; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + clocks = <&clkc CLKID_USB_CTRL>, > + <&clkc CLKID_USB_BUS>, > + <&clkc CLKID_USB_CTRL_IN>; > + clock-names = "usb_ctrl", "usb_bus", "xtal_usb_ctrl"; > + resets = <&reset RESET_USBCTRL>; > + reset-name = "usb_ctrl"; > + > + dr_mode = "otg"; > + > + phys = <&usb2_phy1>; > + phy-names = "usb2-phy1"; > + > + dwc2: usb@ff500000 { > + compatible = "amlogic,meson-a1-usb", "snps,dwc2"; > + reg = <0x0 0xff500000 0x0 0x40000>; > + interrupts = ; > + phys = <&usb2_phy1>; > + phy-names = "usb2-phy"; > + clocks = <&clkc CLKID_USB_PHY>; > + clock-names = "otg"; > + dr_mode = "peripheral"; > + g-rx-fifo-size = <192>; > + g-np-tx-fifo-size = <128>; > + g-tx-fifo-size = <128 128 16 16 16>; > + }; > + > + dwc3: usb@ff400000 { > + compatible = "snps,dwc3"; > + reg = <0x0 0xff400000 0x0 0x100000>; > + interrupts = ; > + dr_mode = "host"; > + snps,dis_u2_susphy_quirk; > + snps,quirk-frame-length-adjustment = <0x20>; > + snps,parkmode-disable-ss-quirk; > + }; > + }; > }; > > timer { This patcj is fine, but depends on clock bindings & dt, so now Vinod took the PHY patch, please resend this wiyhout patches 1 & 5, then resend the DT patch later when the clock bindings is merged. Thanks, Neil _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic