From: Neil Armstrong <narmstrong@baylibre.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Linux USB Mailing List <linux-usb@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH] usb: dwc3-meson-g12a: constify drvdata structs
Date: Mon, 7 Mar 2022 09:31:12 +0100 [thread overview]
Message-ID: <ae246f3f-debd-f183-7d77-ab72c9332cd5@baylibre.com> (raw)
In-Reply-To: <a3c178c9-7c33-d7b8-9f6e-734dc28728ab@gmail.com>
On 06/03/2022 21:59, Heiner Kallweit wrote:
> Constify the drvdata structs. This also matches the definition of
> member drvdata in dwc3_meson_g12a.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/usb/dwc3/dwc3-meson-g12a.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c
> index bd814df3b..b282ad0e6 100644
> --- a/drivers/usb/dwc3/dwc3-meson-g12a.c
> +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
> @@ -188,7 +188,7 @@ static int dwc3_meson_gxl_usb_post_init(struct dwc3_meson_g12a *priv);
> * reset to recover usage of the port.
> */
>
> -static struct dwc3_meson_g12a_drvdata gxl_drvdata = {
> +static const struct dwc3_meson_g12a_drvdata gxl_drvdata = {
> .otg_switch_supported = true,
> .otg_phy_host_port_disable = true,
> .clks = meson_gxl_clocks,
> @@ -202,7 +202,7 @@ static struct dwc3_meson_g12a_drvdata gxl_drvdata = {
> .usb_post_init = dwc3_meson_gxl_usb_post_init,
> };
>
> -static struct dwc3_meson_g12a_drvdata gxm_drvdata = {
> +static const struct dwc3_meson_g12a_drvdata gxm_drvdata = {
> .otg_switch_supported = true,
> .otg_phy_host_port_disable = true,
> .clks = meson_gxl_clocks,
> @@ -216,7 +216,7 @@ static struct dwc3_meson_g12a_drvdata gxm_drvdata = {
> .usb_post_init = dwc3_meson_gxl_usb_post_init,
> };
>
> -static struct dwc3_meson_g12a_drvdata axg_drvdata = {
> +static const struct dwc3_meson_g12a_drvdata axg_drvdata = {
> .otg_switch_supported = true,
> .clks = meson_gxl_clocks,
> .num_clks = ARRAY_SIZE(meson_gxl_clocks),
> @@ -229,7 +229,7 @@ static struct dwc3_meson_g12a_drvdata axg_drvdata = {
> .usb_post_init = dwc3_meson_gxl_usb_post_init,
> };
>
> -static struct dwc3_meson_g12a_drvdata g12a_drvdata = {
> +static const struct dwc3_meson_g12a_drvdata g12a_drvdata = {
> .otg_switch_supported = true,
> .clks = meson_g12a_clocks,
> .num_clks = ARRAY_SIZE(meson_g12a_clocks),
> @@ -241,7 +241,7 @@ static struct dwc3_meson_g12a_drvdata g12a_drvdata = {
> .usb_init = dwc3_meson_g12a_usb_init,
> };
>
> -static struct dwc3_meson_g12a_drvdata a1_drvdata = {
> +static const struct dwc3_meson_g12a_drvdata a1_drvdata = {
> .otg_switch_supported = false,
> .clks = meson_a1_clocks,
> .num_clks = ARRAY_SIZE(meson_a1_clocks),
Looks good:
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2022-03-07 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-06 20:59 Heiner Kallweit
2022-03-07 8:31 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae246f3f-debd-f183-7d77-ab72c9332cd5@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®